mambax7 / alumni-26x

class/groupperm.php

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * page module
 *
 * @copyright       XOOPS Project https://xoops.org/
 * @license         GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
 * @package         page
 * @since           2.6.0
 * @author          DuGris (aka Laurent JEN)
 * @author          John Mordo (jlm69)
 * @version         $Id$
 */

use Xoops\Core\Kernel\Handlers\XoopsGroupPermHandler;

defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');

/**
 * Class AlumniGroupPermHandler
 */
class AlumniGroupPermHandler extends XoopsGroupPermHandler
{
    /**
     * Check permission
     *
     * @param string    $gperm_name
     * @param int       $gperm_itemid
     * @param array|int $gperm_groupid
     * @param int       $gperm_modid
     * @param bool      $trueifadmin
     *
     * @return bool
     */
    public function checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid = 1, $trueifadmin = true)
    {
        return parent::checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid, $trueifadmin);
    }

    /**
     * @param       $cid
     * @param array $groups
     */
    public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
        $groups_exists = array_values($groups_exists);
        $groups_delete = array_diff(array_values($groups_exists), $groups);
        $groups_add    = array_diff($groups, array_values($groups_exists));

        $groups1_exists = parent::getGroupIds('alumni_submit', $cid, $module_id);
        $groups1_exists = array_values($groups1_exists);
        $groups1_delete = array_diff(array_values($groups1_exists), $groups);
        $groups1_add    = array_diff($groups, array_values($groups1_exists));

        $groups2_exists = parent::getGroupIds('alumni_premium', $cid, $module_id);
        $groups2_exists = array_values($groups2_exists);
        $groups2_delete = array_diff(array_values($groups2_exists), $groups);
        $groups2_add    = array_diff($groups, array_values($groups2_exists));

        // delete alumni_view
        if (0 != count($groups_delete)) {

This code seems to be duplicated across your project.

            $criteria = $criteria = new CriteriaCompo();
            $criteria->add(new Criteria('gperm_itemid', $cid));
            $criteria->add(new Criteria('gperm_modid', $module_id));
            $criteria->add(new Criteria('gperm_name', 'alumni_view', '='));
            $criteria->add(new Criteria('gperm_groupid', '(' . implode(', ', $groups_delete) . ')', 'IN'));
            if (parent::deleteAll($criteria)) {
            }
        }

        // delete alumni_view
        if (0 != count($groups1_delete)) {

This code seems to be duplicated across your project.

            $criteria = $criteria = new CriteriaCompo();
            $criteria->add(new Criteria('gperm_itemid', $cid));
            $criteria->add(new Criteria('gperm_modid', $module_id));
            $criteria->add(new Criteria('gperm_name', 'alumni_submit', '='));
            $criteria->add(new Criteria('gperm_groupid', '(' . implode(', ', $groups1_delete) . ')', 'IN'));
            if (parent::deleteAll($criteria)) {
            }
        }

        // delete alumni_view
        if (0 != count($groups2_delete)) {

This code seems to be duplicated across your project.

            $criteria = $criteria = new CriteriaCompo();
            $criteria->add(new Criteria('gperm_itemid', $cid));
            $criteria->add(new Criteria('gperm_modid', $module_id));
            $criteria->add(new Criteria('gperm_name', 'alumni_premium', '='));
            $criteria->add(new Criteria('gperm_groupid', '(' . implode(', ', $groups2_delete) . ')', 'IN'));
            if (parent::deleteAll($criteria)) {
            }
        }

        // Add alumni_view
        if (0 != count($groups_add)) {
            foreach ($groups_add as $group_id) {
                parent::addRight('alumni_view', $cid, $group_id, $module_id);
            }
        }

        // Add alumni_submit
        if (0 != count($groups1_add)) {
            foreach ($groups1_add as $group_id) {
                parent::addRight('alumni_submit', $cid, $group_id, $module_id);
            }
        }

        // Add alumni_submit
        if (0 != count($groups2_add)) {
            foreach ($groups2_add as $group_id) {
                parent::addRight('alumni_premium', $cid, $group_id, $module_id);
            }
        }
    }
}