AlumniGroupPermHandler

Complexity

Total Complexity

14

Size/Duplication

Total Lines	96
Duplicated Lines	28.13 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	checkRight()	0	4	1
D	updatePerms()	27	73	13

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 31 and the first side effect is on line 26.

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * page module
 *
 * @copyright       XOOPS Project https://xoops.org/
 * @license         GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
 * @package         page
 * @since           2.6.0
 * @author          DuGris (aka Laurent JEN)
 * @author          John Mordo (jlm69)
 * @version         $Id$
 */

use Xoops\Core\Kernel\Handlers\XoopsGroupPermHandler;

defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');

/**
 * Class AlumniGroupPermHandler
 */
class AlumniGroupPermHandler extends XoopsGroupPermHandler

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * Check permission
     *
     * @param string    $gperm_name
     * @param int       $gperm_itemid
     * @param array|int $gperm_groupid
     * @param int       $gperm_modid
     * @param bool      $trueifadmin
     *
     * @return bool
     */
    public function checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid = 1, $trueifadmin = true)

function checkRight() does not seem to conform to the naming convention (^(?:is|has|should|may|supports)).

$gperm_name does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    {
        return parent::checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid, $trueifadmin);

$gperm_name does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    }

    /**
     * @param       $cid
     * @param array $groups
     */
    public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

$module_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);

$groups_exists does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

It seems like you call parent on a different method (getGroupIds() instead of updatePerms()). Are you sure this is correct? If so, you might want to change this to $this->getGroupIds().

        $groups_exists = array_values($groups_exists);

$groups_exists does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $groups_delete = array_diff(array_values($groups_exists), $groups);

$groups_delete does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $groups_add    = array_diff($groups, array_values($groups_exists));

$groups_add does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $groups1_exists = parent::getGroupIds('alumni_submit', $cid, $module_id);

$groups1_exists does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

It seems like you call parent on a different method (getGroupIds() instead of updatePerms()). Are you sure this is correct? If so, you might want to change this to $this->getGroupIds().

        $groups1_exists = array_values($groups1_exists);

$groups1_exists does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $groups1_delete = array_diff(array_values($groups1_exists), $groups);

$groups1_delete does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $groups1_add    = array_diff($groups, array_values($groups1_exists));

$groups1_add does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $groups2_exists = parent::getGroupIds('alumni_premium', $cid, $module_id);

$groups2_exists does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

It seems like you call parent on a different method (getGroupIds() instead of updatePerms()). Are you sure this is correct? If so, you might want to change this to $this->getGroupIds().

        $groups2_exists = array_values($groups2_exists);

$groups2_exists does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $groups2_delete = array_diff(array_values($groups2_exists), $groups);

$groups2_delete does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $groups2_add    = array_diff($groups, array_values($groups2_exists));

$groups2_add does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        // delete alumni_view
        if (0 != count($groups_delete)) {

$groups_delete does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

This code seems to be duplicated across your project.

            $criteria = $criteria = new CriteriaCompo();
            $criteria->add(new Criteria('gperm_itemid', $cid));
            $criteria->add(new Criteria('gperm_modid', $module_id));

$module_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $criteria->add(new Criteria('gperm_name', 'alumni_view', '='));
            $criteria->add(new Criteria('gperm_groupid', '(' . implode(', ', $groups_delete) . ')', 'IN'));

$groups_delete does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            if (parent::deleteAll($criteria)) {

It seems like you call parent on a different method (deleteAll() instead of updatePerms()). Are you sure this is correct? If so, you might want to change this to $this->deleteAll().

This if statement is empty and can be removed.

            }
        }

        // delete alumni_view
        if (0 != count($groups1_delete)) {

$groups1_delete does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

This code seems to be duplicated across your project.

            $criteria = $criteria = new CriteriaCompo();
            $criteria->add(new Criteria('gperm_itemid', $cid));
            $criteria->add(new Criteria('gperm_modid', $module_id));

$module_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $criteria->add(new Criteria('gperm_name', 'alumni_submit', '='));
            $criteria->add(new Criteria('gperm_groupid', '(' . implode(', ', $groups1_delete) . ')', 'IN'));

$groups1_delete does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            if (parent::deleteAll($criteria)) {

It seems like you call parent on a different method (deleteAll() instead of updatePerms()). Are you sure this is correct? If so, you might want to change this to $this->deleteAll().

This if statement is empty and can be removed.

            }
        }

        // delete alumni_view
        if (0 != count($groups2_delete)) {

$groups2_delete does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

This code seems to be duplicated across your project.

            $criteria = $criteria = new CriteriaCompo();
            $criteria->add(new Criteria('gperm_itemid', $cid));
            $criteria->add(new Criteria('gperm_modid', $module_id));

$module_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $criteria->add(new Criteria('gperm_name', 'alumni_premium', '='));
            $criteria->add(new Criteria('gperm_groupid', '(' . implode(', ', $groups2_delete) . ')', 'IN'));

$groups2_delete does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            if (parent::deleteAll($criteria)) {

It seems like you call parent on a different method (deleteAll() instead of updatePerms()). Are you sure this is correct? If so, you might want to change this to $this->deleteAll().

This if statement is empty and can be removed.

            }
        }

        // Add alumni_view
        if (0 != count($groups_add)) {

$groups_add does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            foreach ($groups_add as $group_id) {

$groups_add does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                parent::addRight('alumni_view', $cid, $group_id, $module_id);

$group_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

It seems like you call parent on a different method (addRight() instead of updatePerms()). Are you sure this is correct? If so, you might want to change this to $this->addRight().

            }
        }

        // Add alumni_submit
        if (0 != count($groups1_add)) {

$groups1_add does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            foreach ($groups1_add as $group_id) {

$groups1_add does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                parent::addRight('alumni_submit', $cid, $group_id, $module_id);

$group_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

It seems like you call parent on a different method (addRight() instead of updatePerms()). Are you sure this is correct? If so, you might want to change this to $this->addRight().

            }
        }

        // Add alumni_submit
        if (0 != count($groups2_add)) {

$groups2_add does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            foreach ($groups2_add as $group_id) {

$groups2_add does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                parent::addRight('alumni_premium', $cid, $group_id, $module_id);

$group_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

It seems like you call parent on a different method (addRight() instead of updatePerms()). Are you sure this is correct? If so, you might want to change this to $this->addRight().

            }
        }
    }
}