Issues in groupperm.php (master) - Issues in master - mambax7/alumni-26x - Measure and Improve Code Quality continuously with Scrutinizer

Issues (884)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/groupperm.php (3 issues)

Labels

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * page module
 *
 * @copyright       XOOPS Project https://xoops.org/
 * @license         GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
 * @package         page
 * @since           2.6.0
 * @author          DuGris (aka Laurent JEN)
 * @author          John Mordo (jlm69)
 * @version         $Id$
 */

use Xoops\Core\Kernel\Handlers\XoopsGroupPermHandler;

defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');

/**
 * Class AlumniGroupPermHandler
 */
class AlumniGroupPermHandler extends XoopsGroupPermHandler
{
    /**
     * Check permission
     *
     * @param string    $gperm_name
     * @param int       $gperm_itemid
     * @param array|int $gperm_groupid
     * @param int       $gperm_modid
     * @param bool      $trueifadmin
     *
     * @return bool
     */
    public function checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid = 1, $trueifadmin = true)
    {
        return parent::checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid, $trueifadmin);
    }

    /**
     * @param       $cid
     * @param array $groups
     */
    public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
        $groups_exists = array_values($groups_exists);
        $groups_delete = array_diff(array_values($groups_exists), $groups);
        $groups_add    = array_diff($groups, array_values($groups_exists));

        $groups1_exists = parent::getGroupIds('alumni_submit', $cid, $module_id);
        $groups1_exists = array_values($groups1_exists);
        $groups1_delete = array_diff(array_values($groups1_exists), $groups);
        $groups1_add    = array_diff($groups, array_values($groups1_exists));

        $groups2_exists = parent::getGroupIds('alumni_premium', $cid, $module_id);
        $groups2_exists = array_values($groups2_exists);
        $groups2_delete = array_diff(array_values($groups2_exists), $groups);
        $groups2_add    = array_diff($groups, array_values($groups2_exists));

        // delete alumni_view
        if (0 != count($groups_delete)) {
            $criteria = $criteria = new CriteriaCompo();
            $criteria->add(new Criteria('gperm_itemid', $cid));
            $criteria->add(new Criteria('gperm_modid', $module_id));
            $criteria->add(new Criteria('gperm_name', 'alumni_view', '='));
            $criteria->add(new Criteria('gperm_groupid', '(' . implode(', ', $groups_delete) . ')', 'IN'));
            if (parent::deleteAll($criteria)) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            }
        }

        // delete alumni_view
        if (0 != count($groups1_delete)) {
            $criteria = $criteria = new CriteriaCompo();
            $criteria->add(new Criteria('gperm_itemid', $cid));
            $criteria->add(new Criteria('gperm_modid', $module_id));
            $criteria->add(new Criteria('gperm_name', 'alumni_submit', '='));
            $criteria->add(new Criteria('gperm_groupid', '(' . implode(', ', $groups1_delete) . ')', 'IN'));
            if (parent::deleteAll($criteria)) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            }
        }

        // delete alumni_view
        if (0 != count($groups2_delete)) {
            $criteria = $criteria = new CriteriaCompo();
            $criteria->add(new Criteria('gperm_itemid', $cid));
            $criteria->add(new Criteria('gperm_modid', $module_id));
            $criteria->add(new Criteria('gperm_name', 'alumni_premium', '='));
            $criteria->add(new Criteria('gperm_groupid', '(' . implode(', ', $groups2_delete) . ')', 'IN'));
            if (parent::deleteAll($criteria)) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            }
        }

        // Add alumni_view
        if (0 != count($groups_add)) {
            foreach ($groups_add as $group_id) {
                parent::addRight('alumni_view', $cid, $group_id, $module_id);
            }
        }

        // Add alumni_submit
        if (0 != count($groups1_add)) {
            foreach ($groups1_add as $group_id) {
                parent::addRight('alumni_submit', $cid, $group_id, $module_id);
            }
        }

        // Add alumni_submit
        if (0 != count($groups2_add)) {
            foreach ($groups2_add as $group_id) {
                parent::addRight('alumni_premium', $cid, $group_id, $module_id);
            }
        }
    }
}


1		<?php
2		/*
3		You may not change or alter any portion of this comment or credits
4		of supporting developers from this source code or any supporting source code
5		which is considered copyrighted (c) material of the original comment or credit authors.
6
7		This program is distributed in the hope that it will be useful,
8		but WITHOUT ANY WARRANTY; without even the implied warranty of
9		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10		*/
11
12		/**
13		* page module
14		*
15		* @copyright XOOPS Project https://xoops.org/
16		* @license GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
17		* @package page
18		* @since 2.6.0
19		* @author DuGris (aka Laurent JEN)
20		* @author John Mordo (jlm69)
21		* @version $Id$
22		*/
23
24		use Xoops\Core\Kernel\Handlers\XoopsGroupPermHandler;
25
26		defined('XOOPS_ROOT_PATH') \|\| exit('XOOPS root path not defined');
27
28		/**
29		* Class AlumniGroupPermHandler
30		*/
31		class AlumniGroupPermHandler extends XoopsGroupPermHandler
32		{
33		/**
34		* Check permission
35		*
36		* @param string $gperm_name
37		* @param int $gperm_itemid
38		* @param array\|int $gperm_groupid
39		* @param int $gperm_modid
40		* @param bool $trueifadmin
41		*
42		* @return bool
43		*/
44		public function checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid = 1, $trueifadmin = true)
45		{
46		return parent::checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid, $trueifadmin);
47		}
48
49		/**
50		* @param $cid
51		* @param array $groups
52		*/
53		public function updatePerms($cid, $groups = [])
54		{
55		$module_id = Alumni::getInstance()->getModule()->getVar('mid');
56
57		$groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
58		$groups_exists = array_values($groups_exists);
59		$groups_delete = array_diff(array_values($groups_exists), $groups);
60		$groups_add = array_diff($groups, array_values($groups_exists));
61
62		$groups1_exists = parent::getGroupIds('alumni_submit', $cid, $module_id);
63		$groups1_exists = array_values($groups1_exists);
64		$groups1_delete = array_diff(array_values($groups1_exists), $groups);
65		$groups1_add = array_diff($groups, array_values($groups1_exists));
66
67		$groups2_exists = parent::getGroupIds('alumni_premium', $cid, $module_id);
68		$groups2_exists = array_values($groups2_exists);
69		$groups2_delete = array_diff(array_values($groups2_exists), $groups);
70		$groups2_add = array_diff($groups, array_values($groups2_exists));
71
72		// delete alumni_view
73	View Code Duplication	if (0 != count($groups_delete)) {
74		$criteria = $criteria = new CriteriaCompo();
75		$criteria->add(new Criteria('gperm_itemid', $cid));
76		$criteria->add(new Criteria('gperm_modid', $module_id));
77		$criteria->add(new Criteria('gperm_name', 'alumni_view', '='));
78		$criteria->add(new Criteria('gperm_groupid', '(' . implode(', ', $groups_delete) . ')', 'IN'));
79		if (parent::deleteAll($criteria)) {
		0 ignored issues – show Unused Code introduced 2017-05-24 04:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
80		}
81		}
82
83		// delete alumni_view
84	View Code Duplication	if (0 != count($groups1_delete)) {
85		$criteria = $criteria = new CriteriaCompo();
86		$criteria->add(new Criteria('gperm_itemid', $cid));
87		$criteria->add(new Criteria('gperm_modid', $module_id));
88		$criteria->add(new Criteria('gperm_name', 'alumni_submit', '='));
89		$criteria->add(new Criteria('gperm_groupid', '(' . implode(', ', $groups1_delete) . ')', 'IN'));
90		if (parent::deleteAll($criteria)) {
		0 ignored issues – show Unused Code introduced 2017-05-24 04:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
91		}
92		}
93
94		// delete alumni_view
95	View Code Duplication	if (0 != count($groups2_delete)) {
96		$criteria = $criteria = new CriteriaCompo();
97		$criteria->add(new Criteria('gperm_itemid', $cid));
98		$criteria->add(new Criteria('gperm_modid', $module_id));
99		$criteria->add(new Criteria('gperm_name', 'alumni_premium', '='));
100		$criteria->add(new Criteria('gperm_groupid', '(' . implode(', ', $groups2_delete) . ')', 'IN'));
101		if (parent::deleteAll($criteria)) {
		0 ignored issues – show Unused Code introduced 2017-05-24 04:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
102		}
103		}
104
105		// Add alumni_view
106		if (0 != count($groups_add)) {
107		foreach ($groups_add as $group_id) {
108		parent::addRight('alumni_view', $cid, $group_id, $module_id);
109		}
110		}
111
112		// Add alumni_submit
113		if (0 != count($groups1_add)) {
114		foreach ($groups1_add as $group_id) {
115		parent::addRight('alumni_submit', $cid, $group_id, $module_id);
116		}
117		}
118
119		// Add alumni_submit
120		if (0 != count($groups2_add)) {
121		foreach ($groups2_add as $group_id) {
122		parent::addRight('alumni_premium', $cid, $group_id, $module_id);
123		}
124		}
125		}
126		}
127

mambax7 / alumni-26x

Issues (884)

Security Analysis no request data

class/groupperm.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like