mambax7 / alumni-26x

class/form/search.php

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 31 and the first side effect is on line 24.

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * Alumni module for Xoops
 *
 * @copyright       XOOPS Project https://xoops.org/
 * @license         GPL 2.0 or later
 * @package         alumni
 * @since           2.6.x
 * @author          John Mordo (jlm69)
 */

use Xoops\Core\Request;

defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');
$moduleDirName = basename(dirname(dirname(__DIR__)));
include_once XOOPS_ROOT_PATH . "/modules/{$moduleDirName}/class/alumni_tree.php";

/**
 * Class AlumniSearchForm
 */
class AlumniSearchForm extends XoopsThemeForm

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * We are not using this for objects but we need to override the constructor
     * @param null $obj
     */
    public function __construct($obj = null)
    {
    }

    /**
     * @param $andor
     * @param $queries
     * @param $mids
     * @param $mid
     * @param $bycat
     * @return $this
     */
    public function alumni_getSearchFrom($andor, $queries, $mids, $mid, $bycat)

function alumni_getSearchFrom() does not seem to conform to the naming convention (^(?:[a-z]|__)[a-zA-Z0-9]*$).

    {
        $xoops  = Xoops::getInstance();
        $alumni = Alumni::getInstance();
        // create form
        parent::__construct(XoopsLocale::SEARCH, 'alumni', 'search.php', 'get');

It seems like you call parent on a different method (__construct() instead of alumni_getSearchFrom()). Are you sure this is correct? If so, you might want to change this to $this->__construct().

        // create form elements
        $this->addElement(new XoopsFormText(XoopsLocale::KEYWORDS, 'query', 30, 255, htmlspecialchars(stripslashes(implode(' ', $queries)), ENT_QUOTES)), true);
        $type_select = new XoopsFormSelect(XoopsLocale::TYPE, 'andor', $andor);

$type_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $type_select->addOptionArray([

$type_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                                         'AND'   => XoopsLocale::ALL_AND,
                                         'OR'    => XoopsLocale::ANY_OR,
                                         'exact' => XoopsLocale::EXACT_MATCH
                                     ]);
        $this->addElement($type_select);

$type_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $by_cat = Request::getInt('by_cat', 0);

$by_cat does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $categoriesHandler = $xoops->getModuleHandler('category', 'alumni');
        $search            = Search::getInstance();

        $module_id  = $xoops->module->getVar('mid');

$module_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $groups     = $xoops->isUser() ? $xoops->user->getGroups() : '3';
        $alumni_ids = $alumni->getGrouppermHandler()->getItemIds('alumni_view', $groups, $module_id);

$alumni_ids does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $criteria   = new CriteriaCompo();
        $criteria->add(new Criteria('cid', '(' . implode(', ', $alumni_ids) . ')', 'IN'));

$alumni_ids does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $criteria->setOrder($xoops->getModuleConfig('alumni_csortorder'));

        $category_arr = $categoriesHandler->getAll($criteria);

$category_arr does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        foreach (array_keys($category_arr) as $i) {

$category_arr does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $cid   = $category_arr[$i]->getVar('cid');

$category_arr does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $pid   = $category_arr[$i]->getVar('pid');

$category_arr does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$pid is not used, you could remove the assignment.

            $title = $category_arr[$i]->getVar('title');

$category_arr does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }

        $categories      = $alumni->getCategoryHandler()->getCategoriesForSearch();
        $category_select = new XoopsFormSelect(AlumniLocale::L_ALUMNI_CATEGORIES, 'by_cat', $by_cat);

$category_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        foreach ($categories as $cid => $title) {
            $category_select->addOption('0', XoopsLocale::ALL);

$category_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $category_select->addOptionArray([$cid => $title]);

$category_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }
        $this->addElement($category_select);

$category_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if (!empty($mids)) {
            $mods_checkbox = new XoopsFormCheckBox(XoopsLocale::SEARCH_IN, 'mids[]', $mids);

$mods_checkbox does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        } else {
            $mods_checkbox = new XoopsFormCheckBox(XoopsLocale::SEARCH_IN, 'mids[]', $mid);

$mods_checkbox does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }
        if (empty($modules)) {

The variable $modules seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

            $gperm_handler     = $xoops->getHandlerGroupPermission();

$gperm_handler does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $available_modules = $gperm_handler->getItemIds('module_read', $xoops->getUserGroups());

$available_modules does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $available_plugins = Xoops\Module\Plugin::getPlugins('search');

$available_plugins does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $criteria = new CriteriaCompo();
            $criteria->add(new Criteria('dirname', '(\'' . implode('\',\'', array_keys($available_plugins)) . '\')', 'IN'));

$available_plugins does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            if (null !== $available_modules && !empty($available_modules)) {

$available_modules does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $criteria->add(new Criteria('mid', '(' . implode(',', $available_modules) . ')', 'IN'));

$available_modules does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            }
            $moduleHandler = $xoops->getHandlerModule();
            $mods_checkbox->addOptionArray($moduleHandler->getNameList($criteria));

$mods_checkbox does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        } else {
            /* @var $module XoopsModule */
            $module_array = [];

$module_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            foreach ($modules as $mid => $module) {
                $module_array[$mid] = $module->getVar('name');

$module_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            }
            $mods_checkbox->addOptionArray($module_array);

$mods_checkbox does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }
        $this->addElement($mods_checkbox);

$mods_checkbox does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if ($search->getConfig('keyword_min') > 0) {
            $this->addElement(new XoopsFormLabel(XoopsLocale::SEARCH_RULE, sprintf(XoopsLocale::EF_KEYWORDS_MUST_BE_GREATER_THAN, $search->getConfig('keyword_min'))));
        }
        $this->addElement(new XoopsFormHidden('action', 'results'));
        $this->addElement(new XoopsFormHiddenToken('id'));
        $this->addElement(new XoopsFormButton('', 'submit', XoopsLocale::SEARCH, 'submit'));

        return $this;
    }
}