+global\AlumniSearchForm::alumni_getSearchFrom()

Complexity

Conditions	10
Paths	128

Size

Total Lines	80
Code Lines	57

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function alumni_getSearchFrom($andor, $queries, $mids, $mid, $bycat)

function alumni_getSearchFrom() does not seem to conform to the naming convention (^(?:[a-z]|__)[a-zA-Z0-9]*$).

    {
        $xoops  = Xoops::getInstance();
        $alumni = Alumni::getInstance();
        // create form
        parent::__construct(XoopsLocale::SEARCH, 'alumni', 'search.php', 'get');

It seems like you call parent on a different method (__construct() instead of alumni_getSearchFrom()). Are you sure this is correct? If so, you might want to change this to $this->__construct().

        // create form elements
        $this->addElement(new XoopsFormText(XoopsLocale::KEYWORDS, 'query', 30, 255, htmlspecialchars(stripslashes(implode(' ', $queries)), ENT_QUOTES)), true);
        $type_select = new XoopsFormSelect(XoopsLocale::TYPE, 'andor', $andor);

$type_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $type_select->addOptionArray([

$type_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                                         'AND'   => XoopsLocale::ALL_AND,
                                         'OR'    => XoopsLocale::ANY_OR,
                                         'exact' => XoopsLocale::EXACT_MATCH
                                     ]);
        $this->addElement($type_select);

$type_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $by_cat = Request::getInt('by_cat', 0);

$by_cat does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $categoriesHandler = $xoops->getModuleHandler('category', 'alumni');
        $search            = Search::getInstance();

        $module_id  = $xoops->module->getVar('mid');

$module_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $groups     = $xoops->isUser() ? $xoops->user->getGroups() : '3';
        $alumni_ids = $alumni->getGrouppermHandler()->getItemIds('alumni_view', $groups, $module_id);

$alumni_ids does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $criteria   = new CriteriaCompo();
        $criteria->add(new Criteria('cid', '(' . implode(', ', $alumni_ids) . ')', 'IN'));

$alumni_ids does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $criteria->setOrder($xoops->getModuleConfig('alumni_csortorder'));

        $category_arr = $categoriesHandler->getAll($criteria);

$category_arr does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        foreach (array_keys($category_arr) as $i) {

$category_arr does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $cid   = $category_arr[$i]->getVar('cid');

$category_arr does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $pid   = $category_arr[$i]->getVar('pid');

$category_arr does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$pid is not used, you could remove the assignment.

            $title = $category_arr[$i]->getVar('title');

$category_arr does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }

        $categories      = $alumni->getCategoryHandler()->getCategoriesForSearch();
        $category_select = new XoopsFormSelect(AlumniLocale::L_ALUMNI_CATEGORIES, 'by_cat', $by_cat);

$category_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        foreach ($categories as $cid => $title) {
            $category_select->addOption('0', XoopsLocale::ALL);

$category_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $category_select->addOptionArray([$cid => $title]);

$category_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }
        $this->addElement($category_select);

$category_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if (!empty($mids)) {
            $mods_checkbox = new XoopsFormCheckBox(XoopsLocale::SEARCH_IN, 'mids[]', $mids);

$mods_checkbox does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        } else {
            $mods_checkbox = new XoopsFormCheckBox(XoopsLocale::SEARCH_IN, 'mids[]', $mid);

$mods_checkbox does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }
        if (empty($modules)) {

The variable $modules seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

            $gperm_handler     = $xoops->getHandlerGroupPermission();

$gperm_handler does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $available_modules = $gperm_handler->getItemIds('module_read', $xoops->getUserGroups());

$available_modules does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $available_plugins = Xoops\Module\Plugin::getPlugins('search');

$available_plugins does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $criteria = new CriteriaCompo();
            $criteria->add(new Criteria('dirname', '(\'' . implode('\',\'', array_keys($available_plugins)) . '\')', 'IN'));

$available_plugins does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            if (null !== $available_modules && !empty($available_modules)) {

$available_modules does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $criteria->add(new Criteria('mid', '(' . implode(',', $available_modules) . ')', 'IN'));

$available_modules does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            }
            $moduleHandler = $xoops->getHandlerModule();
            $mods_checkbox->addOptionArray($moduleHandler->getNameList($criteria));

$mods_checkbox does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        } else {
            /* @var $module XoopsModule */
            $module_array = [];

$module_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            foreach ($modules as $mid => $module) {
                $module_array[$mid] = $module->getVar('name');

$module_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            }
            $mods_checkbox->addOptionArray($module_array);

$mods_checkbox does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }
        $this->addElement($mods_checkbox);

$mods_checkbox does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if ($search->getConfig('keyword_min') > 0) {
            $this->addElement(new XoopsFormLabel(XoopsLocale::SEARCH_RULE, sprintf(XoopsLocale::EF_KEYWORDS_MUST_BE_GREATER_THAN, $search->getConfig('keyword_min'))));
        }
        $this->addElement(new XoopsFormHidden('action', 'results'));
        $this->addElement(new XoopsFormHiddenToken('id'));
        $this->addElement(new XoopsFormButton('', 'submit', XoopsLocale::SEARCH, 'submit'));

        return $this;
    }
}