maikgreubel / phpgenerics

src/Generics/Client/HttpHeadersTrait.php

Doc Comments +3 added lines

@@ -24,6 +24,8 @@ 
      *
      * {@inheritdoc}
      * @see \Generics\Streams\HttpStream::setHeader()
+     * @param string $headerName
+     * @param string $headerValue
      * @return HttpClient
      */
     public function setHeader($headerName, $headerValue)
@@ -61,6 +63,7 @@ 
 
     /**
      * Adjust the headers by injecting default values for missing keys.
+     * @param string $requestType
      */
     private function adjustHeaders($requestType)
     {

Spacing +5 added lines, -5 removed lines

@@ -64,23 +64,23 @@
      */
     private function adjustHeaders($requestType)
     {
-        if (! array_key_exists('Accept', $this->headers) && $requestType != 'HEAD') {
+        if (!array_key_exists('Accept', $this->headers) && $requestType != 'HEAD') {
             $this->setHeader('Accept', 'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8');
         }
         
-        if (! array_key_exists('Accept-Language', $this->headers) && $requestType != 'HEAD') {
+        if (!array_key_exists('Accept-Language', $this->headers) && $requestType != 'HEAD') {
             $this->setHeader('Accept-Language', 'en-US;q=0.7,en;q=0.3');
         }
         
-        if (! array_key_exists('User-Agent', $this->headers) && $requestType != 'HEAD') {
+        if (!array_key_exists('User-Agent', $this->headers) && $requestType != 'HEAD') {
             $this->setHeader('User-Agent', 'phpGenerics 1.0');
         }
         
-        if (! array_key_exists('Connection', $this->headers) || strlen($this->headers['Connection']) == 0) {
+        if (!array_key_exists('Connection', $this->headers) || strlen($this->headers['Connection']) == 0) {
             $this->adjustConnectionHeader($requestType);
         }
         
-        if (! array_key_exists('Accept-Encoding', $this->headers)) {
+        if (!array_key_exists('Accept-Encoding', $this->headers)) {
             $encoding = "";
             if (function_exists('gzinflate')) {
                 $encoding = 'gzip, deflate';

Braces +6 added lines, -3 removed lines

@@ -84,7 +84,8 @@ 
             $encoding = "";
             if (function_exists('gzinflate')) {
                 $encoding = 'gzip, deflate';
-            } else {
+            }
+            else {
                 $encoding = 'identity';
             }
             $this->setHeader('Accept-Encoding', $encoding);
@@ -101,7 +102,8 @@ 
     {
         if ($requestType == 'HEAD') {
             $this->setHeader('Connection', 'close');
-        } else {
+        }
+        else {
             $this->setHeader('Connection', 'keep-alive');
         }
     }
@@ -115,7 +117,8 @@ 
     {
         if (strpos($line, ':') === false) {
             $this->responseCode = HttpStatus::parseStatus($line)->getCode();
-        } else {
+        }
+        else {
             $line = trim($line);
             list ($headerName, $headerValue) = explode(':', $line, 2);
             $this->headers[$headerName] = trim($headerValue);

src/Generics/Socket/ClientSocket.php

Spacing +4 added lines, -4 removed lines

@@ -36,7 +36,7 @@ 
         $this->handle = $clientHandle;
         $this->conntected = false;
         
-        if (! is_resource($clientHandle)) {
+        if (!is_resource($clientHandle)) {
             parent::__construct($endpoint);
         }
     }
@@ -51,7 +51,7 @@ 
         if (!is_resource($this->handle)) {
             throw new SocketException("Socket is not available");
         }
-        if (! @socket_connect($this->handle, $this->endpoint->getAddress(), $this->endpoint->getPort())) {
+        if (!@socket_connect($this->handle, $this->endpoint->getAddress(), $this->endpoint->getPort())) {
             $code = socket_last_error($this->handle);
             throw new SocketException(socket_strerror($code), array(), $code);
         }
@@ -65,7 +65,7 @@ 
      */
     public function disconnect()
     {
-        if (! $this->conntected) {
+        if (!$this->conntected) {
             throw new SocketException("Socket is not connected");
         }
         
@@ -99,7 +99,7 @@ 
      */
     public function isWriteable():bool
     {
-        if (! $this->isConnected()) {
+        if (!$this->isConnected()) {
             return false;
         }
         

src/Generics/Socket/SecureClientSocket.php

Spacing +3 added lines, -3 removed lines

@@ -24,7 +24,7 @@ 
         $this->handle = $clientHandle;
         $this->conntected = false;
         
-        if (! is_resource($clientHandle)) {
+        if (!is_resource($clientHandle)) {
             parent::__construct($endpoint);
         }
     }
@@ -46,7 +46,7 @@ 
      */
     public function disconnect()
     {
-        if (! $this->conntected) {
+        if (!$this->conntected) {
             throw new SocketException("Socket is not connected");
         }
         
@@ -80,7 +80,7 @@ 
      */
     public function isWriteable():bool
     {
-        if (! $this->isConnected()) {
+        if (!$this->isConnected()) {
             return false;
         }
         

src/Generics/Socket/SecureSocket.php

Spacing +7 added lines, -7 removed lines

@@ -50,7 +50,7 @@ 
      */
     public function read($length = 1, $offset = null): string
     {
-        return stream_get_contents($this->handle, $length, $offset == null ? - 1 : intval($offset));
+        return stream_get_contents($this->handle, $length, $offset == null ? -1 : intval($offset));
     }
 
     /**
@@ -60,7 +60,7 @@ 
      */
     public function isOpen(): bool
     {
-        return is_resource($this->handle) && ! feof($this->handle);
+        return is_resource($this->handle) && !feof($this->handle);
     }
 
     /**
@@ -80,7 +80,7 @@ 
      */
     public function ready(): bool
     {
-        if (! is_resource($this->handle)) {
+        if (!is_resource($this->handle)) {
             return false;
         }
         
@@ -100,7 +100,7 @@ 
             return false;
         }
         
-        if (! in_array($this->handle, $read)) {
+        if (!in_array($this->handle, $read)) {
             return false;
         }
         
@@ -159,7 +159,7 @@ 
      */
     public function write($buffer)
     {
-        if(!$this->isWriteable()) {
+        if (!$this->isWriteable()) {
             throw new SocketException("Stream is not ready for writing");
         }
         $len = strlen($buffer);
@@ -183,7 +183,7 @@ 
      */
     public function isWriteable(): bool
     {
-        if (! is_resource($this->handle)) {
+        if (!is_resource($this->handle)) {
             return false;
         }
         
@@ -203,7 +203,7 @@ 
             return false;
         }
         
-        if (! in_array($this->handle, $write)) {
+        if (!in_array($this->handle, $write)) {
             return false;
         }
         

Braces +2 added lines, -1 removed lines

@@ -234,7 +234,8 @@
         
         if (is_dir($caPath)) {
             $opts['ssl']['capath'] = $caPath;
-        } else {
+        }
+        else {
             $opts['ssl']['cafile'] = $caPath;
         }
         

src/Generics/Client/HttpClientTrait.php

Spacing +5 added lines, -5 removed lines

@@ -129,7 +129,7 @@ 
             'rqtype' => $requestType,
             'path' => $this->path,
             'proto' => $this->protocol,
-            'query' => (strlen($this->queryString) ? '?' . $this->queryString : '')
+            'query' => (strlen($this->queryString) ? '?'.$this->queryString : '')
         ));
         
         // Add the host part
@@ -184,7 +184,7 @@ 
         $numBytes = 1;
         $start = time();
         while (true) {
-            if (! $this->checkConnection($start)) {
+            if (!$this->checkConnection($start)) {
                 continue;
             }
             
@@ -197,7 +197,7 @@ 
             $start = time(); // we have readen something => adjust timeout start point
             $tmp .= $c;
             
-            if (! $delimiterFound) {
+            if (!$delimiterFound) {
                 $this->handleHeader($delimiterFound, $numBytes, $tmp);
             }
             
@@ -305,7 +305,7 @@ 
         
         $ms = $this->appendPayloadToRequest($ms);
         
-        if (! $this->isConnected()) {
+        if (!$this->isConnected()) {
             $this->connect();
         }
         
@@ -330,7 +330,7 @@ 
      */
     private function checkConnection($start): bool
     {
-        if (! $this->ready()) {
+        if (!$this->ready()) {
             if (time() - $start > $this->timeout) {
                 $this->disconnect();
                 throw new HttpException("Connection timed out!");