Completed
Push — master ( 4b63da...c3f322 )
by Maik
05:53
created
src/Mvc/View/Controls/Form.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
     private function renderFields($rendered, $fields)
28 28
     {
29 29
         foreach ($fields as $field) {
30
-            if (! isset($field['name'])) {
30
+            if (!isset($field['name'])) {
31 31
                 throw new ControlException("Field must have at least a name!");
32 32
             }
33 33
             $fieldType = isset($field['type']) ? $field['type'] : 'text';
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     private function renderButtons($rendered, $buttons)
55 55
     {
56 56
         foreach ($buttons as $button) {
57
-            if (! isset($button['name'])) {
57
+            if (!isset($button['name'])) {
58 58
                 throw new ControlException("Button must have at least a name!");
59 59
             }
60 60
             $buttonType = isset($button['type']) ? $button['type'] : "submit";
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
     public function render(Request $request, $parameters = array())
77 77
     {
78 78
         $contentPrefix = "/";
79
-        if (! is_null($request->getContextPrefix())) {
79
+        if (!is_null($request->getContextPrefix())) {
80 80
             $contentPrefix = $request->getContextPrefix();
81 81
         }
82 82
         
Please login to merge, or discard this patch.
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
             $class = isset($field['class']) ? $field['class'] : $field['name'];
36 36
             
37 37
             $rendered .= sprintf('<input type="%s" id="%s" class="%s" name="%s"/>',
38
-            		$fieldType, $id, $class, $field['name']);
38
+                    $fieldType, $id, $class, $field['name']);
39 39
         }
40 40
         
41 41
         return $rendered;
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
             $label = isset($button['label']) ? $button['label'] : $button['name'];
65 65
             
66 66
             $rendered .= sprintf('<button type="%s" id="%s" class="%s" name="%s">%s</button>',
67
-            		$buttonType, $id, $class, $button['name'], $label);
67
+                    $buttonType, $id, $class, $button['name'], $label);
68 68
         }
69 69
         
70 70
         return $rendered;
@@ -83,16 +83,16 @@  discard block
 block discarded – undo
83 83
         }
84 84
         
85 85
         $formAction = sprintf("%s%s/%s", $contentPrefix, isset($parameters['controller']) ?
86
-        		$parameters['controller'] : lcfirst($request->getController()), isset($parameters['action']) ?
87
-        			$parameters['action'] : lcfirst($request->getAction()));
86
+                $parameters['controller'] : lcfirst($request->getController()), isset($parameters['action']) ?
87
+                    $parameters['action'] : lcfirst($request->getAction()));
88 88
         
89 89
         if (isset($parameters['formAction'])) {
90 90
             $formAction = $parameters['formAction'];
91 91
         }
92 92
         
93 93
         $rendered = sprintf('<form action="%s" method="%s"%s>', $formAction, isset($parameters['formMethod']) ?
94
-        		$parameters['formMethod'] : "POST", isset($parameters['formClass']) ?
95
-        		(sprintf(' class="%s"', $parameters['formClass'])) : "");
94
+                $parameters['formMethod'] : "POST", isset($parameters['formClass']) ?
95
+                (sprintf(' class="%s"', $parameters['formClass'])) : "");
96 96
         
97 97
         $rendered = $this->renderFields($rendered, $parameters['fields']);
98 98
         
Please login to merge, or discard this patch.
src/Mvc/View/AbstractView.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@
 block discarded – undo
78 78
      *
79 79
      * @see \Nkey\Caribu\Mvc\View\View::render()
80 80
      */
81
-    abstract public function render(Response &$response, Request $request, $parameters = array());
81
+    abstract public function render(Response & $response, Request $request, $parameters = array());
82 82
 
83 83
     /**
84 84
      * Retrieve the settings from view
Please login to merge, or discard this patch.
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -120,8 +120,8 @@  discard block
 block discarded – undo
120 120
     final public function matchController($controller)
121 121
     {
122 122
         return (in_array($controller, $this->controllers) ||
123
-				in_array('any', $this->controllers) ||
124
-				count($this->controllers) == 0);
123
+                in_array('any', $this->controllers) ||
124
+                count($this->controllers) == 0);
125 125
     }
126 126
 
127 127
     /**
@@ -132,8 +132,8 @@  discard block
 block discarded – undo
132 132
     final public function matchAction($action)
133 133
     {
134 134
         return (in_array($action, $this->actions) ||
135
-        		in_array('any', $this->actions) ||
136
-        		count($this->actions) == 0);
135
+                in_array('any', $this->actions) ||
136
+                count($this->actions) == 0);
137 137
     }
138 138
 
139 139
     /**
Please login to merge, or discard this patch.
src/Mvc/View/DefaultView.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
      *
38 38
      * @see \Nkey\Caribu\Mvc\View\AbstractView::render()
39 39
      */
40
-    public function render(Response &$response, Request $request, $parameters = array())
40
+    public function render(Response & $response, Request $request, $parameters = array())
41 41
     {
42 42
         if ($response->getType() == 'text/html') {
43 43
             $html = sprintf("
Please login to merge, or discard this patch.
src/Mvc/Application.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -203,14 +203,14 @@  discard block
 block discarded – undo
203 203
      */
204 204
     public function registerView($view, $order = null, $applicationName = 'default')
205 205
     {
206
-        if (! class_exists($view)) {
206
+        if (!class_exists($view)) {
207 207
             throw new ViewException("No such view class {view} found", array(
208 208
                 'view' => $view
209 209
             ));
210 210
         }
211 211
         
212 212
         $v = new $view();
213
-        if (! $v instanceof View) {
213
+        if (!$v instanceof View) {
214 214
             throw new ViewException("View {view} is not in application scope", array(
215 215
                 'view' => $view
216 216
             ));
@@ -310,13 +310,13 @@  discard block
 block discarded – undo
310 310
      */
311 311
     public function registerController($controller, $applicationName = 'default')
312 312
     {
313
-        if (! class_exists($controller)) {
313
+        if (!class_exists($controller)) {
314 314
             throw new ControllerException("No such controller class {controller} found", array(
315 315
                 'controller' => $controller
316 316
             ));
317 317
         }
318 318
         $c = new $controller();
319
-        if (! ($c instanceof AbstractController)) {
319
+        if (!($c instanceof AbstractController)) {
320 320
             throw new ControllerException("Controller {controller} is not in application scope", array(
321 321
                 'controller' => $controller
322 322
             ));
@@ -365,7 +365,7 @@  discard block
 block discarded – undo
365 365
             'action' => $action
366 366
         ));
367 367
         
368
-        if (! isset($this->controllers[$applicationName][$controller])) {
368
+        if (!isset($this->controllers[$applicationName][$controller])) {
369 369
             $this->getLogger()->error("[{remote}] No such controller {controller}", array(
370 370
                 'remote' => $request->getRemoteHost(),
371 371
                 'controller' => $controller
@@ -376,7 +376,7 @@  discard block
 block discarded – undo
376 376
         
377 377
         $controllerInstance = $this->controllers[$applicationName][$controller];
378 378
         assert($controllerInstance instanceof AbstractController);
379
-        if (! $controllerInstance->hasAction($action)) {
379
+        if (!$controllerInstance->hasAction($action)) {
380 380
             $this->getLogger()->error("[{remote}] No such action {action}", array(
381 381
                 'remote' => $request->getRemoteHost(),
382 382
                 'action' => $action
Please login to merge, or discard this patch.
src/Mvc/Util/Session.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
         if (null === $namespace) {
47 47
             $this->sessionData = $_SESSION;
48 48
         } else {
49
-            if (! isset($_SESSION[$namespace])) {
49
+            if (!isset($_SESSION[$namespace])) {
50 50
                 $_SESSION[$namespace] = array();
51 51
             }
52 52
             $this->sessionData = $_SESSION[$namespace];
Please login to merge, or discard this patch.
src/Mvc/Util/RequestParser.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
      * @return array Parsed parts for later usage
52 52
      */
53 53
     private static function parseUri(Request &$request,
54
-    		$uri, $defaultController, $defaultAction)
54
+            $uri, $defaultController, $defaultAction)
55 55
     {
56 56
         // All beyond the context prefix is our application request uri
57 57
         $contextUri = $uri;
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
      *            The destination parameter name
103 103
      */
104 104
     private static function parseElement(Request &$req,
105
-    		$serverVars, $elementName, $paramName)
105
+            $serverVars, $elementName, $paramName)
106 106
     {
107 107
         if (isset($serverVars[$elementName])) {
108 108
             $req->params[$paramName] = $serverVars[$elementName];
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -19,11 +19,11 @@  discard block
 block discarded – undo
19 19
      *
20 20
      * @param Request $request
21 21
      */
22
-    private static function parseContextPrefix(Request &$request, $serverVars = array())
22
+    private static function parseContextPrefix(Request & $request, $serverVars = array())
23 23
     {
24 24
         // Since apache 2.3.13 we have now an additional index which provides the context
25 25
         if (isset($serverVars['CONTEXT_PREFIX']) && $serverVars['CONTEXT_PREFIX'] != '') {
26
-            $request->contextPrefix = $serverVars['CONTEXT_PREFIX'] . '/';
26
+            $request->contextPrefix = $serverVars['CONTEXT_PREFIX'].'/';
27 27
         } elseif (isset($serverVars['REDIRECT_BASE'])) {
28 28
             // Try to determine the context from redirect base
29 29
             $request->contextPrefix = $serverVars['REDIRECT_BASE'];
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
      *
51 51
      * @return array Parsed parts for later usage
52 52
      */
53
-    private static function parseUri(Request &$request,
53
+    private static function parseUri(Request & $request,
54 54
     		$uri, $defaultController, $defaultAction)
55 55
     {
56 56
         // All beyond the context prefix is our application request uri
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         if (count($parts) > 0) {
73 73
             $request->controller = ucfirst(trim($parts[0]));
74 74
             array_shift($parts);
75
-            if (! $request->controller) {
75
+            if (!$request->controller) {
76 76
                 $request->controller = $defaultController;
77 77
             }
78 78
         }
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         if (count($parts) > 0) {
82 82
             $request->action = trim($parts[0]);
83 83
             array_shift($parts);
84
-            if (! $request->action) {
84
+            if (!$request->action) {
85 85
                 $request->action = $defaultAction;
86 86
             }
87 87
         }
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
      * @param string $paramName
102 102
      *            The destination parameter name
103 103
      */
104
-    private static function parseElement(Request &$req,
104
+    private static function parseElement(Request & $req,
105 105
     		$serverVars, $elementName, $paramName)
106 106
     {
107 107
         if (isset($serverVars[$elementName])) {
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
      * @param array $serverVars
118 118
      *            The server variables provided by sapi
119 119
      */
120
-    private static function parseParameters(Request &$req, $serverVars)
120
+    private static function parseParameters(Request & $req, $serverVars)
121 121
     {
122 122
         self::parseElement($req, $serverVars, 'HTTP_ACCEPT', 'Accept');
123 123
         self::parseElement($req, $serverVars, 'HTTP_ACCEPT_LANGUAGE', 'Accept-Language');
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      *
149 149
      * @param Request $request
150 150
      */
151
-    private static function parseRemoteHost(Request &$request, $serverVars = array())
151
+    private static function parseRemoteHost(Request & $request, $serverVars = array())
152 152
     {
153 153
         if (isset($serverVars['REMOTE_ADDR'])) {
154 154
             $request->remoteHost = $serverVars['REMOTE_ADDR'];
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      * @param Request $request
165 165
      *            Request object to put the parameters in
166 166
      */
167
-    private static function parseGetPostSessionCookie(Request &$request)
167
+    private static function parseGetPostSessionCookie(Request & $request)
168 168
     {
169 169
         foreach ($_GET as $name => $value) {
170 170
             $request->params[$name] = $value;
Please login to merge, or discard this patch.
src/Mvc/View/View.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
      *
29 29
      * @return void
30 30
      */
31
-    public function render(Response &$response, Request $request, $parameters = array());
31
+    public function render(Response & $response, Request $request, $parameters = array());
32 32
 
33 33
     /**
34 34
      * Retrieve the order of view in best-match list
Please login to merge, or discard this patch.
src/Mvc/Controller/Request.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      */
149 149
     public static function parseFromServerRequest($serverVars, $defaultController = 'Index', $defaultAction = 'index')
150 150
     {
151
-        if (! isset($serverVars['REQUEST_URI'])) {
151
+        if (!isset($serverVars['REQUEST_URI'])) {
152 152
             throw new InvalidUrlException("No such uri provided");
153 153
         }
154 154
         return self::parse($serverVars['REQUEST_URI'], $serverVars, $defaultController, $defaultAction);
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
         switch ($typeOf) {
243 243
             case 'bool':
244 244
             case 'boolean':
245
-                $result = function_exists('boolval') ? boolval($result) : (bool) $result;
245
+                $result = function_exists('boolval') ? boolval($result) : (bool)$result;
246 246
                 break;
247 247
             
248 248
             case 'double':
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
      */
278 278
     public function setParam($name, $value)
279 279
     {
280
-        if (! $this->hasParam($name)) {
280
+        if (!$this->hasParam($name)) {
281 281
             throw new ControllerException("Parameter {param} does not exist", array(
282 282
                 'param' => $name
283 283
             ));
Please login to merge, or discard this patch.
src/Mvc/Controller/AbstractController.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -215,7 +215,7 @@
 block discarded – undo
215 215
             $currentBody = $response->getBody();
216 216
             
217 217
             if (! isset($this->viewParams[$controlIdentifier][$controlName])
218
-				|| ! $view->hasControl($controlIdentifier)) {
218
+                || ! $view->hasControl($controlIdentifier)) {
219 219
                 $response->setBody(str_replace($matches[0], '', $currentBody));
220 220
                 continue;
221 221
             }
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
         
81 81
         $param = $params[0];
82 82
         assert($param instanceof \ReflectionParameter);
83
-        if (! ($class = $param->getClass()) || $class->getName() != 'Nkey\Caribu\Mvc\Controller\Request') {
83
+        if (!($class = $param->getClass()) || $class->getName() != 'Nkey\Caribu\Mvc\Controller\Request') {
84 84
             return false;
85 85
         }
86 86
         
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
             return;
107 107
         }
108 108
         
109
-        if (! $this->parseParameters($action)) {
109
+        if (!$this->parseParameters($action)) {
110 110
             return;
111 111
         }
112 112
         
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
      * @param View $view
206 206
      *            The View instance to use for rendering
207 207
      */
208
-    protected function addControls(Response &$response, Request $request, View $view)
208
+    protected function addControls(Response & $response, Request $request, View $view)
209 209
     {
210 210
         $matches = array();
211 211
         
@@ -214,8 +214,8 @@  discard block
 block discarded – undo
214 214
             $controlName = $matches[2];
215 215
             $currentBody = $response->getBody();
216 216
             
217
-            if (! isset($this->viewParams[$controlIdentifier][$controlName])
218
-				|| ! $view->hasControl($controlIdentifier)) {
217
+            if (!isset($this->viewParams[$controlIdentifier][$controlName])
218
+				|| !$view->hasControl($controlIdentifier)) {
219 219
                 $response->setBody(str_replace($matches[0], '', $currentBody));
220 220
                 continue;
221 221
             }
Please login to merge, or discard this patch.