Passed
Pull Request — develop (#52)
by Kevin
06:37
created
lib/Config/Storage/RelationalDatabase.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@
 block discarded – undo
128 128
         $table->addColumn(new Text('value'));
129 129
         $table->addColumn(new Varchar('context', 255));
130 130
         $table->addConstraint(
131
-            new UniqueKey(['path','context'], 'configuration_uniqueness_index')
131
+            new UniqueKey(['path', 'context'], 'configuration_uniqueness_index')
132 132
         );
133 133
 
134 134
         $sql = new Sql($this->adapter);
Please login to merge, or discard this patch.
lib/Console/Command/ConfigurationSet.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -3,13 +3,9 @@
 block discarded – undo
3 3
 namespace Magium\Configuration\Console\Command;
4 4
 
5 5
 use Magium\Configuration\Config\ConfigurationRepository;
6
-use Magium\Configuration\Config\ConfigInterface;
7
-use Magium\Configuration\MagiumConfigurationFactory;
8
-use Magium\Configuration\MagiumConfigurationFactoryInterface;
9 6
 use Symfony\Component\Console\Command\Command;
10 7
 use Symfony\Component\Console\Input\InputArgument;
11 8
 use Symfony\Component\Console\Input\InputInterface;
12
-use Symfony\Component\Console\Input\InputOption;
13 9
 use Symfony\Component\Console\Output\OutputInterface;
14 10
 
15 11
 class ConfigurationSet extends Command
Please login to merge, or discard this patch.
lib/Console/Command/CreateTable.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -2,11 +2,7 @@
 block discarded – undo
2 2
 
3 3
 namespace Magium\Configuration\Console\Command;
4 4
 
5
-use Magium\Configuration\Config\ConfigurationRepository;
6
-use Magium\Configuration\Config\InvalidContextException;
7
-use Magium\Configuration\MagiumConfigurationFactory;
8 5
 use Symfony\Component\Console\Command\Command;
9
-use Symfony\Component\Console\Input\InputArgument;
10 6
 use Symfony\Component\Console\Input\InputInterface;
11 7
 use Symfony\Component\Console\Output\OutputInterface;
12 8
 
Please login to merge, or discard this patch.
lib/File/Configuration/ConfigurationFileRepository.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use Magium\Configuration\Config\InvalidConfigurationLocationException;
6 6
 use Magium\Configuration\Config\InvalidDirectoryException;
7 7
 use Magium\Configuration\File\AdapterInterface;
8
-use Magium\Configuration\File\InvalidFileException;
9 8
 
10 9
 class ConfigurationFileRepository implements \ArrayAccess, \Iterator, \Countable
11 10
 {
Please login to merge, or discard this patch.
lib/Config/Builder.php 2 patches
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
     }
102 102
 
103 103
     /**
104
-     * @param ConfigurationRepository|null $config
104
+     * @param null|ConfigInterface $config
105 105
      * @return ConfigurationRepository
106 106
      * @throws InvalidConfigurationLocationException
107 107
      * @throws InvalidFileException
@@ -158,6 +158,9 @@  discard block
 block discarded – undo
158 158
         return $structure;
159 159
     }
160 160
 
161
+    /**
162
+     * @param string $callbackString
163
+     */
161 164
     protected function executeCallback($callbackString, $value)
162 165
     {
163 166
         if (function_exists($callbackString)) {
@@ -198,7 +201,8 @@  discard block
 block discarded – undo
198 201
 
199 202
     /**
200 203
      * @param \SimpleXMLElement $structure The object representing the merged configuration structure
201
-     * @param \SimpleXmlElement $config An empty config object to be populated
204
+     * @param ConfigInterface $config An empty config object to be populated
205
+     * @param string $context
202 206
      * @return ConfigurationRepository The resulting configuration object
203 207
      */
204 208
 
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,6 @@
 block discarded – undo
8 8
 use Magium\Configuration\Container\GenericContainer;
9 9
 use Magium\Configuration\File\AdapterInterface;
10 10
 use Magium\Configuration\File\Configuration\ConfigurationFileRepository;
11
-use Magium\Configuration\File\Configuration\UnsupportedFileTypeException;
12 11
 use Magium\Configuration\File\InvalidFileException;
13 12
 use Magium\Configuration\InvalidConfigurationException;
14 13
 use Zend\Cache\Storage\StorageInterface;
Please login to merge, or discard this patch.
lib/Container/GenericContainer.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -43,6 +43,9 @@
 block discarded – undo
43 43
         return $this->container[$id];
44 44
     }
45 45
 
46
+    /**
47
+     * @param string $type
48
+     */
46 49
     public function newInstance($type)
47 50
     {
48 51
         $reflection = new \ReflectionClass($type);
Please login to merge, or discard this patch.