magium / MagiumMagento

lib/Magento/AbstractMagentoTestCase.php

Doc Comments +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
     }
 
     /**
-     * @param $method
+     * @param string $method
      * @return \Magium\Magento\Actions\Checkout\PaymentMethods\PaymentMethodInterface
      */
 

Spacing +7 added lines, -7 removed lines

@@ -27,7 +27,7 @@ 
 
         // If we are passed just the class name we will prepend it with Magium\Magento\Actions\Checkout\PaymentMethods
         if (strpos($method, '\\') === false) {
-            $method = 'Magium\Magento\Actions\Checkout\PaymentMethods\\' . $method;
+            $method = 'Magium\Magento\Actions\Checkout\PaymentMethods\\'.$method;
         }
 
         if (is_subclass_of($method, 'Magium\Magento\Actions\Checkout\PaymentMethods\PaymentMethodInterface')) {
@@ -69,7 +69,7 @@ 
 
         // If we are passed just the class name we will prepend it with Magium\Magento\Actions\Checkout\PaymentMethods
         if (strpos($method, '\\') === false) {
-            $method = 'Magium\Magento\Actions\Checkout\ShippingMethods\\' . $method;
+            $method = 'Magium\Magento\Actions\Checkout\ShippingMethods\\'.$method;
         }
 
         if (is_subclass_of($method, 'Magium\Magento\Actions\Checkout\ShippingMethods\ShippingMethodInterface')) {
@@ -86,12 +86,12 @@ 
         if ($reflection->isSubclassOf('Magium\Magento\Themes\NavigableThemeInterface')) {
             // Not entirely sure of hardcoding the various interface types.  May make this configurable
             parent::switchThemeConfiguration($fullyQualifiedClassName);
-            $this->setTypePreference('Magium\Magento\Themes\AbstractThemeConfiguration',$fullyQualifiedClassName);
-            $this->setTypePreference('Magium\Magento\Themes\NavigableThemeInterface',$fullyQualifiedClassName);
-            $this->setTypePreference('Magium\Themes\BaseThemeInterface',$fullyQualifiedClassName);
+            $this->setTypePreference('Magium\Magento\Themes\AbstractThemeConfiguration', $fullyQualifiedClassName);
+            $this->setTypePreference('Magium\Magento\Themes\NavigableThemeInterface', $fullyQualifiedClassName);
+            $this->setTypePreference('Magium\Themes\BaseThemeInterface', $fullyQualifiedClassName);
 
-            $this->setTypePreference('Magium\Magento\Themes\Customer\AbstractThemeConfiguration',$this->getTheme()->getCustomerThemeClass());
-            $this->setTypePreference('Magium\Magento\Themes\OnePageCheckout\AbstractThemeConfiguration',$this->getTheme()->getCheckoutThemeClass());
+            $this->setTypePreference('Magium\Magento\Themes\Customer\AbstractThemeConfiguration', $this->getTheme()->getCustomerThemeClass());
+            $this->setTypePreference('Magium\Magento\Themes\OnePageCheckout\AbstractThemeConfiguration', $this->getTheme()->getCheckoutThemeClass());
 
 
         } else {

lib/Magento/Actions/Admin/Configuration/PaymentMethods/CashOnDelivery.php

Doc Comments -1 removed lines

@@ -23,7 +23,6 @@
     ];
 
     /**
-     * @param string $active
      */
     public function setEnabled($enabled)
     {

Spacing +1 added lines, -1 removed lines

@@ -8,7 +8,7 @@
     const NAME = 'Cash On Delivery Payment';
     const ACTION = 'Admin\Configuration\PaymentMethods\CashOnDelivery';
 
-    protected $section = 'Payment Methods/' . self::NAME;
+    protected $section = 'Payment Methods/'.self::NAME;
 
     protected $settings = [
         'payment_cashondelivery_active'             => 0,

lib/Magento/Actions/Admin/Configuration/SettingModifier.php

Doc Comments +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
      * * Tab/Section::name=Text Of Setting (will ensure that the correct section is navigated to, uses setting name (exact), not ID)
      * * name=Text Of Setting (will not navigate, uses setting name (exact) not ID)
      *
-     * @param $identifier
+     * @param string $identifier
      * @param $value
      * @throws \Magium\InvalidInstructionException
      */

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace Magium\Magento\Actions\Admin\Configuration;
 
-use Facebook\WebDriver\WebDriverElement;
-use Facebook\WebDriver\WebDriverSelect;
 use Magium\Magento\AbstractMagentoTestCase;
 use Magium\Magento\Navigators\Admin\SystemConfiguration;
 use Magium\Magento\Themes\Admin\ThemeConfiguration;

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
             $xpath = '';
             if (count($xpath) === 2) {
                 $nav = explode('/', $parts[0]);
-                $xpath = $this->themeConfiguration->getSystemConfigSectionDisplayCheckXpath($nav[1]) . '/descendant::';
+                $xpath = $this->themeConfiguration->getSystemConfigSectionDisplayCheckXpath($nav[1]).'/descendant::';
             }
             $xpath .= $this->themeConfiguration->getSystemConfigSettingLabelXpath($matches[1]);
             $labelElement = $this->webDriver->byXpath($xpath);

lib/Magento/Actions/Cart/AddConfigurableProductToCart.php

Unused Use Statements -2 removed lines

@@ -2,10 +2,8 @@
 
 namespace Magium\Magento\Actions\Cart;
 
-use Magium\Actions\WaitForPageLoaded;
 use Magium\Magento\Extractors\Catalog\Cart\AddToCart;
 use Magium\Magento\Extractors\Catalog\Product\ConfigurableProductOptions;
-use Magium\Magento\Extractors\Catalog\Product\Swatch;
 use Magium\Magento\Extractors\Catalog\Product\Option;
 use Magium\Magento\Extractors\Catalog\Product\SwatchValue;
 use Magium\Magento\Extractors\Catalog\Product\Value;

Spacing +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
                 // The options are sorted by  their entry into the setOption() method.  Need to have it ordered by the page order
 
                 if (!$elementOption instanceof Option) {
-                    throw new InvalidConfigurableOptionException('Missing the attribute: ' . $attributeName);
+                    throw new InvalidConfigurableOptionException('Missing the attribute: '.$attributeName);
                 }
                 $element = $elementOption->getValue($this->getOption($attributeName));
                 if (!$element instanceof Value) {

Braces +3 added lines, -1 removed lines

@@ -57,7 +57,9 @@
             $attributes = $this->option->getOptionNames();
             foreach ($attributes as $attributeName) {
                 $elementOption = $this->option->getOption($attributeName);
-                if (!$elementOption) continue;
+                if (!$elementOption) {
+                    continue;
+                }
                 // The options are sorted by  their entry into the setOption() method.  Need to have it ordered by the page order
 
                 if (!$elementOption instanceof Option) {

lib/Magento/Actions/Cart/AddItemToCart.php

Doc Comments -1 removed lines

@@ -96,7 +96,6 @@
     /**
      * Adds as configurable product to the cart from the product page.
      * 
-     * @param array $options
      */
     
     public function addConfigurableItemToCartFromProductPage($categoryNavigationPath = null)

lib/Magento/Actions/Checkout/CustomerCheckout.php

Unused Use Statements -2 removed lines

@@ -6,8 +6,6 @@
 use Magium\Magento\Actions\Checkout\Steps\LogInCustomer;
 use Magium\Magento\Actions\Checkout\Steps\PaymentMethod;
 use Magium\Magento\Actions\Checkout\Steps\PlaceOrder;
-use Magium\Magento\Actions\Checkout\Steps\ReviewOrder;
-use Magium\Magento\Actions\Checkout\Steps\SelectCustomerCheckout;
 use Magium\Magento\Actions\Checkout\Steps\ShippingAddress;
 use Magium\Magento\Actions\Checkout\Steps\ShippingMethod;
 use Magium\Magento\Extractors\Checkout\CartSummary;

lib/Magento/Actions/Checkout/GuestCheckout.php

Unused Use Statements -2 removed lines

@@ -5,7 +5,6 @@ 
 use Magium\Magento\Actions\Checkout\Steps\BillingAddress;
 use Magium\Magento\Actions\Checkout\Steps\PaymentMethod;
 use Magium\Magento\Actions\Checkout\Steps\PlaceOrder;
-use Magium\Magento\Actions\Checkout\Steps\ReviewOrder;
 use Magium\Magento\Actions\Checkout\Steps\SelectGuestCheckout;
 use Magium\Magento\Actions\Checkout\Steps\ShippingAddress;
 use Magium\Magento\Actions\Checkout\Steps\ShippingMethod;
@@ -14,7 +13,6 @@ 
 use Magium\Magento\Navigators\Checkout\Checkout;
 use Magium\Magento\Navigators\Checkout\CheckoutStart;
 use Magium\Magento\Themes\OnePageCheckout\AbstractThemeConfiguration;
-use Magium\Magento\Themes\OnePageCheckout\ThemeConfiguration as OnePageCheckoutTheme;
 
 class GuestCheckout extends AbstractCheckout
 {

lib/Magento/Actions/Checkout/RegisterNewCustomerCheckout.php

Unused Use Statements -3 removed lines

@@ -6,8 +6,6 @@ 
 use Magium\Magento\Actions\Checkout\Steps\NewCustomerPassword;
 use Magium\Magento\Actions\Checkout\Steps\PaymentMethod;
 use Magium\Magento\Actions\Checkout\Steps\PlaceOrder;
-use Magium\Magento\Actions\Checkout\Steps\ReviewOrder;
-use Magium\Magento\Actions\Checkout\Steps\SelectCustomerCheckout;
 use Magium\Magento\Actions\Checkout\Steps\SelectRegisterNewCustomerCheckout;
 use Magium\Magento\Actions\Checkout\Steps\ShippingAddress;
 use Magium\Magento\Actions\Checkout\Steps\ShippingMethod;
@@ -16,7 +14,6 @@ 
 use Magium\Magento\Navigators\Checkout\Checkout;
 use Magium\Magento\Navigators\Checkout\CheckoutStart;
 use Magium\Magento\Themes\OnePageCheckout\AbstractThemeConfiguration;
-use Magium\Magento\Themes\OnePageCheckout\ThemeConfiguration as OnePageCheckoutTheme;
 
 class RegisterNewCustomerCheckout extends AbstractCheckout
 {

lib/Magento/Extractors/Admin/Login/Messages.php

Doc Comments +3 added lines

@@ -43,6 +43,9 @@
         return $this->messages;
     }
 
+    /**
+     * @param string $message
+     */
     public function addMessage($message)
     {
         $this->messages[] = $message;