magium / MagiumMagento

lib/Magento/Actions/Admin/Configuration/SettingModifier.php

Doc Comments +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
      * * Tab/Section::name=Text Of Setting (will ensure that the correct section is navigated to, uses setting name (exact), not ID)
      * * name=Text Of Setting (will not navigate, uses setting name (exact) not ID)
      *
-     * @param $identifier
+     * @param string $identifier
      * @param $value
      * @throws \Magium\InvalidInstructionException
      */

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace Magium\Magento\Actions\Admin\Configuration;
 
-use Facebook\WebDriver\WebDriverElement;
-use Facebook\WebDriver\WebDriverSelect;
 use Magium\Magento\AbstractMagentoTestCase;
 use Magium\Magento\Navigators\Admin\SystemConfiguration;
 use Magium\Magento\Themes\Admin\ThemeConfiguration;

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
             $xpath = '';
             if (count($xpath) === 2) {
                 $nav = explode('/', $parts[0]);
-                $xpath = $this->themeConfiguration->getSystemConfigSectionDisplayCheckXpath($nav[1]) . '/descendant::';
+                $xpath = $this->themeConfiguration->getSystemConfigSectionDisplayCheckXpath($nav[1]).'/descendant::';
             }
             $xpath .= $this->themeConfiguration->getSystemConfigSettingLabelXpath($matches[1]);
             $labelElement = $this->webDriver->byXpath($xpath);

lib/Magento/Actions/Cart/AddConfigurableProductToCart.php

Unused Use Statements -2 removed lines

@@ -2,10 +2,8 @@
 
 namespace Magium\Magento\Actions\Cart;
 
-use Magium\Actions\WaitForPageLoaded;
 use Magium\Magento\Extractors\Catalog\Cart\AddToCart;
 use Magium\Magento\Extractors\Catalog\Product\ConfigurableProductOptions;
-use Magium\Magento\Extractors\Catalog\Product\Swatch;
 use Magium\Magento\Extractors\Catalog\Product\Option;
 use Magium\Magento\Extractors\Catalog\Product\SwatchValue;
 use Magium\Magento\Extractors\Catalog\Product\Value;

Spacing +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
                 // The options are sorted by  their entry into the setOption() method.  Need to have it ordered by the page order
 
                 if (!$elementOption instanceof Option) {
-                    throw new InvalidConfigurableOptionException('Missing the attribute: ' . $attributeName);
+                    throw new InvalidConfigurableOptionException('Missing the attribute: '.$attributeName);
                 }
                 $element = $elementOption->getValue($this->getOption($attributeName));
                 if (!$element instanceof Value) {

Braces +3 added lines, -1 removed lines

@@ -57,7 +57,9 @@
             $attributes = $this->option->getOptionNames();
             foreach ($attributes as $attributeName) {
                 $elementOption = $this->option->getOption($attributeName);
-                if (!$elementOption) continue;
+                if (!$elementOption) {
+                    continue;
+                }
                 // The options are sorted by  their entry into the setOption() method.  Need to have it ordered by the page order
 
                 if (!$elementOption instanceof Option) {

lib/Magento/Actions/Checkout/CustomerCheckout.php

Unused Use Statements -2 removed lines

@@ -6,8 +6,6 @@
 use Magium\Magento\Actions\Checkout\Steps\LogInCustomer;
 use Magium\Magento\Actions\Checkout\Steps\PaymentMethod;
 use Magium\Magento\Actions\Checkout\Steps\PlaceOrder;
-use Magium\Magento\Actions\Checkout\Steps\ReviewOrder;
-use Magium\Magento\Actions\Checkout\Steps\SelectCustomerCheckout;
 use Magium\Magento\Actions\Checkout\Steps\ShippingAddress;
 use Magium\Magento\Actions\Checkout\Steps\ShippingMethod;
 use Magium\Magento\Extractors\Checkout\CartSummary;

lib/Magento/Actions/Checkout/GuestCheckout.php

Unused Use Statements -2 removed lines

@@ -5,7 +5,6 @@ 
 use Magium\Magento\Actions\Checkout\Steps\BillingAddress;
 use Magium\Magento\Actions\Checkout\Steps\PaymentMethod;
 use Magium\Magento\Actions\Checkout\Steps\PlaceOrder;
-use Magium\Magento\Actions\Checkout\Steps\ReviewOrder;
 use Magium\Magento\Actions\Checkout\Steps\SelectGuestCheckout;
 use Magium\Magento\Actions\Checkout\Steps\ShippingAddress;
 use Magium\Magento\Actions\Checkout\Steps\ShippingMethod;
@@ -14,7 +13,6 @@ 
 use Magium\Magento\Navigators\Checkout\Checkout;
 use Magium\Magento\Navigators\Checkout\CheckoutStart;
 use Magium\Magento\Themes\OnePageCheckout\AbstractThemeConfiguration;
-use Magium\Magento\Themes\OnePageCheckout\ThemeConfiguration as OnePageCheckoutTheme;
 
 class GuestCheckout extends AbstractCheckout
 {

lib/Magento/Actions/Checkout/RegisterNewCustomerCheckout.php

Unused Use Statements -3 removed lines

@@ -6,8 +6,6 @@ 
 use Magium\Magento\Actions\Checkout\Steps\NewCustomerPassword;
 use Magium\Magento\Actions\Checkout\Steps\PaymentMethod;
 use Magium\Magento\Actions\Checkout\Steps\PlaceOrder;
-use Magium\Magento\Actions\Checkout\Steps\ReviewOrder;
-use Magium\Magento\Actions\Checkout\Steps\SelectCustomerCheckout;
 use Magium\Magento\Actions\Checkout\Steps\SelectRegisterNewCustomerCheckout;
 use Magium\Magento\Actions\Checkout\Steps\ShippingAddress;
 use Magium\Magento\Actions\Checkout\Steps\ShippingMethod;
@@ -16,7 +14,6 @@ 
 use Magium\Magento\Navigators\Checkout\Checkout;
 use Magium\Magento\Navigators\Checkout\CheckoutStart;
 use Magium\Magento\Themes\OnePageCheckout\AbstractThemeConfiguration;
-use Magium\Magento\Themes\OnePageCheckout\ThemeConfiguration as OnePageCheckoutTheme;
 
 class RegisterNewCustomerCheckout extends AbstractCheckout
 {

lib/Magento/Extractors/Admin/Login/Messages.php

Doc Comments +3 added lines

@@ -43,6 +43,9 @@
         return $this->messages;
     }
 
+    /**
+     * @param string $message
+     */
     public function addMessage($message)
     {
         $this->messages[] = $message;

lib/Magento/Extractors/Admin/Xtree/CategoryTreeNode.php

Doc Comments +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
 
     /**
      * @param $nodePath
-     * @return WebDriverElement
+     * @return null|\Facebook\WebDriver\Remote\RemoteWebElement
      */
 
     public function getNode($nodePath)

Spacing +4 added lines, -4 removed lines

@@ -58,8 +58,8 @@ 
         $previousExpandXpath = '';
         $element = null;
         foreach ($parts as $part) {
-            $xpath .= '/' . $this->theme->getXTreeChildXpath($part);
-            if(!$this->webDriver->elementExists($xpath, WebDriver::BY_XPATH)) {
+            $xpath .= '/'.$this->theme->getXTreeChildXpath($part);
+            if (!$this->webDriver->elementExists($xpath, WebDriver::BY_XPATH)) {
                 if ($previousExpandXpath) {
                     $this->testCase->assertElementExists($previousExpandXpath, WebDriver::BY_XPATH);
                     $this->webDriver->byXpath($previousExpandXpath)->click();
@@ -70,9 +70,9 @@ 
             $this->testCase->assertElementExists($xpath, WebDriver::BY_XPATH);
             $element = $this->webDriver->byXpath($xpath);
             if (!$element->isDisplayed()) {
-                throw new ElementNotVisibleException('Node element is not visible and cannot be made visible: ' . $part);
+                throw new ElementNotVisibleException('Node element is not visible and cannot be made visible: '.$part);
             }
-            $previousExpandXpath = $xpath . $this->theme->getXTreeChildNodeExpandPrefixXpath();
+            $previousExpandXpath = $xpath.$this->theme->getXTreeChildNodeExpandPrefixXpath();
             $xpath .= $this->theme->getXTreeChildNodePrefixXpath();
         }
         $this->node = $element;

lib/Magento/Extractors/Catalog/LayeredNavigation/FilterTypes/SwatchFilter.php

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace Magium\Magento\Extractors\Catalog\LayeredNavigation\FilterTypes;
 
-use Facebook\WebDriver\WebDriverBy;
-use Facebook\WebDriver\WebDriverElement;
 use Magium\Magento\Extractors\Catalog\LayeredNavigation\FilterValue;
 use Magium\Magento\Extractors\Catalog\LayeredNavigation\UnparseableValueException;
 

Spacing +2 added lines, -2 removed lines

@@ -44,8 +44,8 @@
         /* @var $elements \DOMElement[] */
         $returnElements = [];
         foreach ($elements as $element) {
-            $elementDocument  = new \DOMDocument();
-            $html  =$element->C14N();
+            $elementDocument = new \DOMDocument();
+            $html = $element->C14N();
             $elementDocument->loadXML($html);
             $elementXpath = new \DOMXPath($elementDocument);
             $titleElements = $elementXpath->query(sprintf('//*[@%s]', $this->theme->getLayeredNavigationSwatchTitleAttribute()));

Braces +3 added lines, -1 removed lines

@@ -15,7 +15,9 @@
     {
         $xpath = new \DOMXPath($this->document);
         $xpathQuery = $this->theme->getLayeredNavigationSwatchAppliesXpath($this->title);
-        if (!$xpathQuery) return false;
+        if (!$xpathQuery) {
+            return false;
+        }
         $elements = $xpath->query($xpathQuery);
         return $elements->length > 0;
     }

lib/Magento/Extractors/Catalog/LayeredNavigation/LayeredNavigation.php

Doc Comments +3 added lines

@@ -80,6 +80,9 @@
     }
 
 
+    /**
+     * @param string $type
+     */
     public function addFilterType($type)
     {
         $type = $this->filterTypeName($type);

Spacing +7 added lines, -7 removed lines

@@ -55,11 +55,11 @@ 
     {
         $returnType = $type;
         if (strpos($type, '\\') === false) {
-            $returnType = $this->baseNamespace . '\\' . $type;
+            $returnType = $this->baseNamespace.'\\'.$type;
             if (!class_exists($returnType)) {
                 $returnType = $type;
                 if (!class_exists($returnType)) {
-                    throw new InvalidFilterException('Filter type must exist: ' . $returnType);
+                    throw new InvalidFilterException('Filter type must exist: '.$returnType);
                 }
             }
         }
@@ -69,12 +69,12 @@ 
 
     protected function validateFilterType($returnType)
     {
-        if ($returnType == $this->baseNamespace . '\AbstractFilterType') {
+        if ($returnType == $this->baseNamespace.'\AbstractFilterType') {
             return true;
         }
         $reflection = new \ReflectionClass($returnType);
-        if (!$reflection->isSubclassOf($this->baseNamespace . '\AbstractFilterType')) {
-            throw new InvalidFilterException('Filter type must extend AbstractFilterType: ' . $returnType);
+        if (!$reflection->isSubclassOf($this->baseNamespace.'\AbstractFilterType')) {
+            throw new InvalidFilterException('Filter type must extend AbstractFilterType: '.$returnType);
         }
         return true;
     }
@@ -131,7 +131,7 @@ 
             return $this->filterValues[$filterKey];
         }
 
-        throw new MissingFilterException('Could not find the filter: ' . $filter);
+        throw new MissingFilterException('Could not find the filter: '.$filter);
     }
 
     public function extract()
@@ -167,7 +167,7 @@ 
                         break;
                     }
                 } else {
-                    throw new InvalidFilterException('Filter type does not extend AbstractFilterType: ' . $type);
+                    throw new InvalidFilterException('Filter type does not extend AbstractFilterType: '.$type);
                 }
             }
         }