magium / Magium

lib/Assertions/Element/Clickable.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Facebook\WebDriver\WebDriverBy;
 use Magium\AbstractTestCase;
-use Magium\InvalidTestTypeException;
 use Magium\WebDriver\ExpectedCondition;
 
 class Clickable extends AbstractSelectorAssertion

lib/Assertions/Element/NotClickable.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Facebook\WebDriver\WebDriverBy;
 use Magium\AbstractTestCase;
-use Magium\InvalidTestTypeException;
 use Magium\WebDriver\ExpectedCondition;
 
 class NotClickable extends AbstractSelectorAssertion

lib/Util/Log/LoggerPHPUnit5.php

Doc Comments +6 added lines

@@ -45,11 +45,17 @@
         return $this->invokedTest;
     }
 
+    /**
+     * @param string $name
+     */
     public function setTestName($name)
     {
         $this->testName = $name;
     }
 
+    /**
+     * @param string $status
+     */
     public function setTestStatus($status)
     {
         $this->status = $status;

Spacing +4 added lines, -4 removed lines

@@ -68,13 +68,13 @@ 
     public function logAssertionSuccess(AbstractAssertion $assertion, array $extra)
     {
         $extra = array_merge($extra, ['type' => 'assertion', 'result' => self::STATUS_PASSED]);
-        $this->info(get_class($assertion) . ' - passed', $this->createExtra($extra));
+        $this->info(get_class($assertion).' - passed', $this->createExtra($extra));
     }
 
     public function logAssertionFailure(Exception $e, AbstractAssertion $assertion, array $extra)
     {
         $extra = array_merge($extra, ['type' => 'assertion', 'result' => self::STATUS_FAILED, 'stack_trace' => $e->getTrace()]);
-        $this->err(get_class($assertion) . ' - ' . $e->getMessage(), $this->createExtra($extra));
+        $this->err(get_class($assertion).' - '.$e->getMessage(), $this->createExtra($extra));
     }
 
     public function createExtra($includeArray = [])
@@ -136,9 +136,9 @@ 
     {
         if ($test instanceof TestCase) {
             if (!$this->testName) {
-                $this->setTestName(get_class($test) . '::' . $test->getName());
+                $this->setTestName(get_class($test).'::'.$test->getName());
             }
-            $this->invokedTest = get_class($test) . '::' . $test->getName();
+            $this->invokedTest = get_class($test).'::'.$test->getName();
             $this->setTestStatus(self::STATUS_PASSED);
         }
 

lib/WebDriver/WebDriver.php

Doc Comments +7 added lines

@@ -59,6 +59,10 @@ 
     }
 
 
+    /**
+     * @param string $by
+     * @param string $selector
+     */
     public function logFind($by, $selector)
     {
         if ($this->logger instanceof \Magium\Util\Log\LoggerInterface) {
@@ -135,6 +139,9 @@ 
         return $element;
     }
 
+    /**
+     * @param string $selector
+     */
     public function elementExists($selector, $by = 'byId')
     {
         try {

lib/AbstractTestCase.php

Spacing +7 added lines, -7 removed lines

@@ -211,7 +211,7 @@ 
         }
     }
 
-    public static function resolveClass( $class, $prefix = null)
+    public static function resolveClass($class, $prefix = null)
     {
         $origClass = $class;
         if ($prefix !== null) {
@@ -225,7 +225,7 @@ 
         }
 
         foreach (self::$baseNamespaces as $namespace) {
-            $fqClass = $namespace . '\\' . $class;
+            $fqClass = $namespace.'\\'.$class;
             try {
                 if (class_exists($fqClass)) {
                     return $fqClass;
@@ -517,7 +517,7 @@ 
             $element = $this->byXpath(sprintf('//%s[contains(., "%s")]', $node, addslashes($text)));
             self::assertWebDriverElement($element);
         } catch (\Exception $e) {
-            $this->fail('The body did not contain the text: ' . $text);
+            $this->fail('The body did not contain the text: '.$text);
         }
     }
 
@@ -528,7 +528,7 @@ 
             // If the element is not found then an exception will be thrown
             self::assertWebDriverElement($element);
         } catch (\Exception $e) {
-            $this->fail('The body did not contain the text: ' . $text);
+            $this->fail('The body did not contain the text: '.$text);
         }
     }
 
@@ -536,7 +536,7 @@ 
     {
         try {
             $this->webdriver->byXpath(sprintf('//body[contains(., "%s")]', $text));
-            $this->fail('The page contains the words: ' . $text);
+            $this->fail('The page contains the words: '.$text);
         } catch (NoSuchElementException $e) {
             // Exception thrown is a success
             self::assertInstanceOf(NoSuchElementException::class, $e);
@@ -577,7 +577,7 @@ 
     {
 
         if ($parentElementSelector !== null) {
-            $xpathTemplate = $parentElementSelector . $xpathTemplate;
+            $xpathTemplate = $parentElementSelector.$xpathTemplate;
         }
         if ($specificNodeType !== null) {
             return $this->byXpath(sprintf($xpathTemplate, $specificNodeType, $this->getTranslator()->translatePlaceholders($text)));
@@ -590,7 +590,7 @@ 
             }
         }
         // This is here for consistency with the other by* methods
-        WebDriverException::throwException(7, 'Could not find element with text: ' . $this->getTranslator()->translatePlaceholders($text), []);
+        WebDriverException::throwException(7, 'Could not find element with text: '.$this->getTranslator()->translatePlaceholders($text), []);
     }
 
     /**

lib/Util/Phpunit5/MasterListener.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
         $this->result = null;
     }
 
-    public function addListener( $listener)
+    public function addListener($listener)
     {
         // This pretty piece of code is to maintain compatibility between PHPUnit 5 and 6.
         if ($listener instanceof \PHPUnit_Framework_TestListener) {

lib/Util/Log/Logger.php

Spacing +4 added lines, -4 removed lines

@@ -73,13 +73,13 @@ 
     public function logAssertionSuccess(AbstractAssertion $assertion, array $extra)
     {
         $extra = array_merge($extra, ['type' => 'assertion', 'result' => self::STATUS_PASSED]);
-        $this->info(get_class($assertion) . ' - passed', $this->createExtra($extra));
+        $this->info(get_class($assertion).' - passed', $this->createExtra($extra));
     }
 
     public function logAssertionFailure(Exception $e, AbstractAssertion $assertion, array $extra)
     {
         $extra = array_merge($extra, ['type' => 'assertion', 'result' => self::STATUS_FAILED, 'stack_trace' => $e->getTrace()]);
-        $this->err(get_class($assertion) . ' - ' . $e->getMessage(), $this->createExtra($extra));
+        $this->err(get_class($assertion).' - '.$e->getMessage(), $this->createExtra($extra));
     }
 
     public function createExtra($includeArray = [])
@@ -146,9 +146,9 @@ 
     {
         if ($test instanceof TestCase) {
             if (!$this->testName) {
-                $this->setTestName(get_class($test) . '::' . $test->getName());
+                $this->setTestName(get_class($test).'::'.$test->getName());
             }
-            $this->invokedTest = get_class($test) . '::' . $test->getName();
+            $this->invokedTest = get_class($test).'::'.$test->getName();
             $this->setTestStatus(self::STATUS_PASSED);
         }
 

lib/TestCase/Initializer.php

Spacing +3 added lines, -3 removed lines

@@ -149,7 +149,7 @@ 
     protected function getDefaultConfiguration()
     {
         // Choose the correct logger/listener for the version of PHPUnit being used
-        $loggerClass = class_exists('PHPUnit_Framework_TestCase')?LoggerPHPUnit5::class:Logger::class;
+        $loggerClass = class_exists('PHPUnit_Framework_TestCase') ?LoggerPHPUnit5::class : Logger::class;
 
         return [
             'definition' => [
@@ -215,12 +215,12 @@ 
 
         $count = 0;
 
-        $path = realpath(__DIR__ . '/../');
+        $path = realpath(__DIR__.'/../');
 
         while ($count++ < 5) {
             $dir = "{$path}/configuration/";
             if (is_dir($dir)) {
-                foreach (glob($dir . '*.php') as $file) {
+                foreach (glob($dir.'*.php') as $file) {
                     $configArray = array_merge_recursive($configArray, include $file);
                 }
                 break;