Inspection of "Merge branch 'master' of https://github.com/magium..." - magium/Magium - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c25c8e...44516d )

by Kevin

created 2017-11-21 18:08 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -26,12 +26,12 @@
 block discarded – undo
             }
             $count = 0;
             while ($count++ < 10) {
-                $filePath = $dir . '/' . $file;
+                $filePath = $dir.'/'.$file;
                 if (file_exists($filePath)) {
                     $this->config = json_decode(file_get_contents($filePath), true);
                     break;
                 }
-                $dir = realpath($dir . '/..');
+                $dir = realpath($dir.'/..');
             }
         }
 

Please login to merge, or discard this patch.

lib/Util/EmailGenerator/Generator.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -11,6 +11,6 @@
 block discarded – undo
         $encoded = base64_encode($rand);
         $username = preg_replace('/\W/', '', $encoded);
 
-        return $username . '@' . $domain;
+        return $username.'@'.$domain;
     }
 }
\ No newline at end of file

Please login to merge, or discard this patch.

lib/Extractors/Navigation/Menu.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -109,7 +109,7 @@  discard block
 block discarded – undo
         $html = $this->webDriver->byXpath('//body')->getAttribute('innerHTML');
         $doc = new \DOMDocument();
         libxml_use_internal_errors(true);
-        $doc->loadHTML('<html><body>' . $html . '</body></html>');
+        $doc->loadHTML('<html><body>'.$html.'</body></html>');
         $xpath = new \DOMXPath($doc);
 
         $baseMatches = $this->getBaseMatches($xpath, $baseChild);
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
         }
 
         if (!count($finalMatches)) {
-            throw new UnableToExtractMenuXpathException('Could not extract menu Xpaths for the category path: ' . $this->path);
+            throw new UnableToExtractMenuXpathException('Could not extract menu Xpaths for the category path: '.$this->path);
         }
 
         $this->baseXpath = $finalMatches[0]['baseNodePath'];
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
     {
         $baseMatches = [];
         foreach ($this->baseSearchOrder as $base) {
-            $baseQuery = '//' . $base;
+            $baseQuery = '//'.$base;
             $nodeList = $xpath->query($baseQuery);
             foreach ($nodeList as $index => $node) {
                 /* @var $node \DOMElement */
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
                     if ($element->isDisplayed()) {
                         foreach ($this->childSearchOrder as $order) {
                             $childQueryXpath = sprintf($order, $baseChild);
-                            $childQuery = $path . '/descendant::' . $childQueryXpath;
+                            $childQuery = $path.'/descendant::'.$childQueryXpath;
                             $childNodeList = $xpath->query($childQuery);
                             if ($childNodeList instanceof \DOMNodeList) {
                                 foreach ($childNodeList as $node) {

Please login to merge, or discard this patch.

lib/Navigators/LinkSequence.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -52,7 +52,7 @@  discard block
 block discarded – undo
             $xpath = sprintf('//a[concat(" ",normalize-space(.)," ") = " %s "]|//*[concat(" ",normalize-space(.)," ") = " %s "]/ancestor::a', $part, $part);
             $elements = $this->webDriver->findElements(WebDriverBy::xpath($xpath));
             $action = false;
-            $this->testCase->assertNotCount(0, $elements, 'Did not find 1 or more elements with the Xpath: ' . $xpath);
+            $this->testCase->assertNotCount(0, $elements, 'Did not find 1 or more elements with the Xpath: '.$xpath);
             foreach ($elements as $element) {
                 // Sometimes responsive templates have multiple nav menus.  So we iterate over the results to find a visible element.
                 if (!$element->isDisplayed()) {
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
                 $action = true;
                 break; // If either of these options work we don't need to iterate over the remain elements
             }
-            $this->testCase->assertTrue($action, 'No action was taken.  Elements not visible?  Xpath: ' . $xpath);
+            $this->testCase->assertTrue($action, 'No action was taken.  Elements not visible?  Xpath: '.$xpath);
         }
 
         // We will have already clicked it previously

Please login to merge, or discard this patch.

lib/Assertions/Browser/AssetIsCached.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -28,12 +28,12 @@
 block discarded – undo
 
         foreach ($assets as $asset) {
             if (strpos($asset['name'], $this->url) !== false) {
-                $this->testCase->assertEquals(0, $asset['duration'], 'Asset was not cached: ' . $asset['name']);
+                $this->testCase->assertEquals(0, $asset['duration'], 'Asset was not cached: '.$asset['name']);
                 $foundAsset = true;
             }
         }
 
-        $this->testCase->assertTrue($foundAsset, 'Unable to find asset: ' . $this->url);
+        $this->testCase->assertTrue($foundAsset, 'Unable to find asset: '.$this->url);
     }
 
 }
\ No newline at end of file

Please login to merge, or discard this patch.

lib/Assertions/Browser/LogEmpty.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -13,7 +13,7 @@
 block discarded – undo
     {
         $log = $this->webDriver->manage()->getLog('browser');
         foreach ($log as $l) {
-            $this->logger->err('Message found: ' . serialize($l));
+            $this->logger->err('Message found: '.serialize($l));
         }
         $this->testCase->assertCount(0, $log);
     }

Please login to merge, or discard this patch.

lib/Actions/SetFormValue.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@  discard block
 block discarded – undo
 
     public function setById($id, $value)
     {
-        $this->set('id:' . $id, $value);
+        $this->set('id:'.$id, $value);
     }
 
     public function set($name, $value)
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
         } else {
             $element = $this->webDriver->byXpath(sprintf('//label[.="%s"]', $name));
             if (!$element->getAttribute('for')) {
-                throw new NotFoundException('Unable to find the "for" attribute for a label with the text: ' . $name);
+                throw new NotFoundException('Unable to find the "for" attribute for a label with the text: '.$name);
             }
             $formElement = $this->webDriver->byId($element->getAttribute('for'));
         }

Please login to merge, or discard this patch.

lib/Util/Configuration/StandardConfigurationProvider.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -31,10 +31,10 @@
 block discarded – undo
 
     public function configureDi(Di $di)
     {
-        $di->instanceManager()->addSharedInstance($this->configurationReader,               get_class($this->configurationReader));
-        $di->instanceManager()->addSharedInstance($this->classConfigurationReader,          get_class($this->classConfigurationReader));
-        $di->instanceManager()->addSharedInstance($this->environmentConfigurationReader,    get_class($this->environmentConfigurationReader));
-        $di->instanceManager()->addSharedInstance($this,                                    get_class($this));
+        $di->instanceManager()->addSharedInstance($this->configurationReader, get_class($this->configurationReader));
+        $di->instanceManager()->addSharedInstance($this->classConfigurationReader, get_class($this->classConfigurationReader));
+        $di->instanceManager()->addSharedInstance($this->environmentConfigurationReader, get_class($this->environmentConfigurationReader));
+        $di->instanceManager()->addSharedInstance($this, get_class($this));
     }
 
     public function configureObject(ConfigurableObjectInterface $obj)

Please login to merge, or discard this patch.

lib/Util/Configuration/EnvironmentConfigurationReader.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -12,7 +12,7 @@
 block discarded – undo
 
         foreach ($classes as $class) {
 
-            $variablePrefix = 'MAGIUM_' . str_replace('\\', '_', strtoupper($class)) . '_';
+            $variablePrefix = 'MAGIUM_'.str_replace('\\', '_', strtoupper($class)).'_';
 
             // Fixes https://github.com/magium/Magium/issues/114
             $props = array_merge($_SERVER, $_ENV);

Please login to merge, or discard this patch.

		@@ -109,7 +109,7 @@ discard block
		block discarded – undo
109	109	$html = $this->webDriver->byXpath('//body')->getAttribute('innerHTML');
110	110	$doc = new \DOMDocument();
111	111	libxml_use_internal_errors(true);
112		- $doc->loadHTML('<html><body>' . $html . '</body></html>');
	112	+ $doc->loadHTML('<html><body>'.$html.'</body></html>');
113	113	$xpath = new \DOMXPath($doc);
114	114
115	115	$baseMatches = $this->getBaseMatches($xpath, $baseChild);
		@@ -121,7 +121,7 @@ discard block
		block discarded – undo
121	121	}
122	122
123	123	if (!count($finalMatches)) {
124		- throw new UnableToExtractMenuXpathException('Could not extract menu Xpaths for the category path: ' . $this->path);
	124	+ throw new UnableToExtractMenuXpathException('Could not extract menu Xpaths for the category path: '.$this->path);
125	125	}
126	126
127	127	$this->baseXpath = $finalMatches[0]['baseNodePath'];
		@@ -179,7 +179,7 @@ discard block
		block discarded – undo
179	179	{
180	180	$baseMatches = [];
181	181	foreach ($this->baseSearchOrder as $base) {
182		- $baseQuery = '//' . $base;
	182	+ $baseQuery = '//'.$base;
183	183	$nodeList = $xpath->query($baseQuery);
184	184	foreach ($nodeList as $index => $node) {
185	185	/* @var $node \DOMElement */
		@@ -190,7 +190,7 @@ discard block
		block discarded – undo
190	190	if ($element->isDisplayed()) {
191	191	foreach ($this->childSearchOrder as $order) {
192	192	$childQueryXpath = sprintf($order, $baseChild);
193		- $childQuery = $path . '/descendant::' . $childQueryXpath;
	193	+ $childQuery = $path.'/descendant::'.$childQueryXpath;
194	194	$childNodeList = $xpath->query($childQuery);
195	195	if ($childNodeList instanceof \DOMNodeList) {
196	196	foreach ($childNodeList as $node) {

		@@ -52,7 +52,7 @@ discard block
		block discarded – undo
52	52	$xpath = sprintf('//a[concat(" ",normalize-space(.)," ") = " %s "]\|//*[concat(" ",normalize-space(.)," ") = " %s "]/ancestor::a', $part, $part);
53	53	$elements = $this->webDriver->findElements(WebDriverBy::xpath($xpath));
54	54	$action = false;
55		- $this->testCase->assertNotCount(0, $elements, 'Did not find 1 or more elements with the Xpath: ' . $xpath);
	55	+ $this->testCase->assertNotCount(0, $elements, 'Did not find 1 or more elements with the Xpath: '.$xpath);
56	56	foreach ($elements as $element) {
57	57	// Sometimes responsive templates have multiple nav menus. So we iterate over the results to find a visible element.
58	58	if (!$element->isDisplayed()) {
		@@ -66,7 +66,7 @@ discard block
		block discarded – undo
66	66	$action = true;
67	67	break; // If either of these options work we don't need to iterate over the remain elements
68	68	}
69		- $this->testCase->assertTrue($action, 'No action was taken. Elements not visible? Xpath: ' . $xpath);
	69	+ $this->testCase->assertTrue($action, 'No action was taken. Elements not visible? Xpath: '.$xpath);
70	70	}
71	71
72	72	// We will have already clicked it previously

		@@ -28,12 +28,12 @@
		block discarded – undo
28	28
29	29	foreach ($assets as $asset) {
30	30	if (strpos($asset['name'], $this->url) !== false) {
31		- $this->testCase->assertEquals(0, $asset['duration'], 'Asset was not cached: ' . $asset['name']);
	31	+ $this->testCase->assertEquals(0, $asset['duration'], 'Asset was not cached: '.$asset['name']);
32	32	$foundAsset = true;
33	33	}
34	34	}
35	35
36		- $this->testCase->assertTrue($foundAsset, 'Unable to find asset: ' . $this->url);
	36	+ $this->testCase->assertTrue($foundAsset, 'Unable to find asset: '.$this->url);
37	37	}
38	38
39	39	}
40	40	\ No newline at end of file

		@@ -31,10 +31,10 @@
		block discarded – undo
31	31
32	32	public function configureDi(Di $di)
33	33	{
34		- $di->instanceManager()->addSharedInstance($this->configurationReader, get_class($this->configurationReader));
35		- $di->instanceManager()->addSharedInstance($this->classConfigurationReader, get_class($this->classConfigurationReader));
36		- $di->instanceManager()->addSharedInstance($this->environmentConfigurationReader, get_class($this->environmentConfigurationReader));
37		- $di->instanceManager()->addSharedInstance($this, get_class($this));
	34	+ $di->instanceManager()->addSharedInstance($this->configurationReader, get_class($this->configurationReader));
	35	+ $di->instanceManager()->addSharedInstance($this->classConfigurationReader, get_class($this->classConfigurationReader));
	36	+ $di->instanceManager()->addSharedInstance($this->environmentConfigurationReader, get_class($this->environmentConfigurationReader));
	37	+ $di->instanceManager()->addSharedInstance($this, get_class($this));
38	38	}
39	39
40	40	public function configureObject(ConfigurableObjectInterface $obj)

		@@ -26,12 +26,12 @@
		block discarded – undo
26	26	}
27	27	$count = 0;
28	28	while ($count++ < 10) {
29		- $filePath = $dir . '/' . $file;
	29	+ $filePath = $dir.'/'.$file;
30	30	if (file_exists($filePath)) {
31	31	$this->config = json_decode(file_get_contents($filePath), true);
32	32	break;
33	33	}
34		- $dir = realpath($dir . '/..');
	34	+ $dir = realpath($dir.'/..');
35	35	}
36	36	}
37	37

		@@ -11,6 +11,6 @@
		block discarded – undo
11	11	$encoded = base64_encode($rand);
12	12	$username = preg_replace('/\W/', '', $encoded);
13	13
14		- return $username . '@' . $domain;
	14	+ return $username.'@'.$domain;
15	15	}
16	16	}
17	17	\ No newline at end of file

		@@ -13,7 +13,7 @@
		block discarded – undo
13	13	{
14	14	$log = $this->webDriver->manage()->getLog('browser');
15	15	foreach ($log as $l) {
16		- $this->logger->err('Message found: ' . serialize($l));
	16	+ $this->logger->err('Message found: '.serialize($l));
17	17	}
18	18	$this->testCase->assertCount(0, $log);
19	19	}

		@@ -29,7 +29,7 @@ discard block
		block discarded – undo
29	29
30	30	public function setById($id, $value)
31	31	{
32		- $this->set('id:' . $id, $value);
	32	+ $this->set('id:'.$id, $value);
33	33	}
34	34
35	35	public function set($name, $value)
		@@ -41,7 +41,7 @@ discard block
		block discarded – undo
41	41	} else {
42	42	$element = $this->webDriver->byXpath(sprintf('//label[.="%s"]', $name));
43	43	if (!$element->getAttribute('for')) {
44		- throw new NotFoundException('Unable to find the "for" attribute for a label with the text: ' . $name);
	44	+ throw new NotFoundException('Unable to find the "for" attribute for a label with the text: '.$name);
45	45	}
46	46	$formElement = $this->webDriver->byId($element->getAttribute('for'));
47	47	}

		@@ -12,7 +12,7 @@
		block discarded – undo
12	12
13	13	foreach ($classes as $class) {
14	14
15		- $variablePrefix = 'MAGIUM_' . str_replace('\\', '_', strtoupper($class)) . '_';
	15	+ $variablePrefix = 'MAGIUM_'.str_replace('\\', '_', strtoupper($class)).'_';
16	16
17	17	// Fixes https://github.com/magium/Magium/issues/114
18	18	$props = array_merge($_SERVER, $_ENV);

magium / Magium

Push — master ( c25c8e...44516d )

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch