SeoableTrait::seoData() - Code Metrics - Inspection of "Merge branch 'develop'" - mad-web/laravel-seoable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8f5f7c...7faed5 )

by Basenko

created 2017-08-17 16:26 UTC

SeoableTrait::seoData() A

↳ Parent: SeoableTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
c	0
b	0
f	0
rs	9.4285
cc	2
eloc	8
nc	2
nop	0

<?php

namespace MadWeb\Seoable\Traits;

use MadWeb\Seoable\Protocols\Meta;

/**
 * This trait is for usage in models.
 */
trait SeoableTrait
{
    /**
     * Has one polymorphic relation to seo storage table.
     *
     * @return \Illuminate\Database\Eloquent\Relations\HasOne
     */
    public function seoData()
    {
        $class_name = get_class($this);

        $SeoDataQuery = $this->hasOne(config('seoable.model'), 'seoable_id')->where('seoable_type', $class_name);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        if (! $SeoDataQuery->exists()) {
            $SeoData = $SeoDataQuery->make(['meta' => [], 'open_graph' => [], 'twitter' => []]);
            $SeoData->seoable_type = $class_name;
            $SeoData->save();
        }

        return $SeoDataQuery;
    }

    /**
     * Get seo data from the table.
     *
     * @return mixed
     */
    public function getSeoData()
    {
        return $this->seoData->getSeoData();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    protected function seo()
    {
        return new Meta($this);
    }
}


1			<?php
2
3			namespace MadWeb\Seoable\Traits;
4
5			use MadWeb\Seoable\Protocols\Meta;
6
7			/**
8			* This trait is for usage in models.
9			*/
10			trait SeoableTrait
11			{
12			/**
13			* Has one polymorphic relation to seo storage table.
14			*
15			* @return \Illuminate\Database\Eloquent\Relations\HasOne
16			*/
17			public function seoData()
18			{
19			$class_name = get_class($this);
20
21			$SeoDataQuery = $this->hasOne(config('seoable.model'), 'seoable_id')->where('seoable_type', $class_name);
			0 ignored issues – show Bug introduced 2017-08-17 14:20 UTC by Report Bug Copy Issue Report It seems like `hasOne()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22
23			if (! $SeoDataQuery->exists()) {
24			$SeoData = $SeoDataQuery->make(['meta' => [], 'open_graph' => [], 'twitter' => []]);
25			$SeoData->seoable_type = $class_name;
26			$SeoData->save();
27			}
28
29			return $SeoDataQuery;
30			}
31
32			/**
33			* Get seo data from the table.
34			*
35			* @return mixed
36			*/
37			public function getSeoData()
38			{
39			return $this->seoData->getSeoData();
			0 ignored issues – show Bug introduced 2017-08-17 14:20 UTC by Report Bug Copy Issue Report The property `seoData` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
40			}
41
42			protected function seo()
43			{
44			return new Meta($this);
45			}
46			}
47

mad-web / laravel-seoable

Push — master ( 8f5f7c...7faed5 )

SeoableTrait::seoData() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like