MadWeb\Seoable\Traits\SeoableTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	seoData()	0	14	2
A	getSeoData()	0	4	1
A	seo()	0	4	1

<?php

namespace MadWeb\Seoable\Traits;

use MadWeb\Seoable\Protocols\Meta;

/**
 * This trait is for usage in models.
 */
trait SeoableTrait
{
    /**
     * Has one polymorphic relation to seo storage table.
     *
     * @return \Illuminate\Database\Eloquent\Relations\HasOne
     */
    public function seoData()
    {
        $class_name = get_class($this);

        $SeoDataQuery = $this->hasOne(config('seoable.model'), 'seoable_id')->where('seoable_type', $class_name);

It seems like hasOne() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (! $SeoDataQuery->exists()) {
            $SeoData = $SeoDataQuery->make(['meta' => [], 'open_graph' => [], 'twitter' => []]);
            $SeoData->seoable_type = $class_name;
            $SeoData->save();
        }

        return $SeoDataQuery;
    }

    /**
     * Get seo data from the table.
     *
     * @return mixed
     */
    public function getSeoData()
    {
        return $this->seoData->getSeoData();

The property seoData does not exist. Did you maybe forget to declare it?

    }

    protected function seo()
    {
        return new Meta($this);
    }
}