Completed
Push — master ( a94534...362609 )
by Maciej
13s
created
src/Collection/RuleCollection.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
 	 * @access protected
144 144
 	 *
145 145
 	 * @param string $rule
146
-	 * @return bool
146
+	 * @return integer
147 147
 	 */
148 148
 	protected function string_has_params( $rule ) {
149 149
 		return strpos( $rule, ':' );
Please login to merge, or discard this patch.
Spacing   +41 added lines, -41 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 namespace WFV\Collection;
3
-defined( 'ABSPATH' ) || die();
3
+defined('ABSPATH') || die();
4 4
 
5 5
 use WFV\Abstraction\Collectable;
6 6
 
@@ -18,8 +18,8 @@  discard block
 block discarded – undo
18 18
 	 *
19 19
 	 * @param array $rules
20 20
 	 */
21
-	public function __construct( array $rules ) {
22
-		$this->data = $this->parse_rules( $rules );
21
+	public function __construct(array $rules) {
22
+		$this->data = $this->parse_rules($rules);
23 23
 	}
24 24
 
25 25
 
@@ -32,8 +32,8 @@  discard block
 block discarded – undo
32 32
 	 * @param bool (optional) $flat
33 33
 	 * @return array
34 34
 	 */
35
-	public function get_array( $flat = false ) {
36
-		return ( $flat ) ? $this->remove_params() : $this->data;
35
+	public function get_array($flat = false) {
36
+		return ($flat) ? $this->remove_params() : $this->data;
37 37
 	}
38 38
 
39 39
 	/**
@@ -45,9 +45,9 @@  discard block
 block discarded – undo
45 45
 	 * @param int $index
46 46
 	 * @return array|bool
47 47
 	 */
48
-	public function get_params( $field, $index ) {
49
-		return ( $this-> has_params( $field, $index ) )
50
-			? $this->data[ $field ][ $index ]['params']
48
+	public function get_params($field, $index) {
49
+		return ($this-> has_params($field, $index))
50
+			? $this->data[$field][$index]['params']
51 51
 			: false;
52 52
 	}
53 53
 
@@ -59,8 +59,8 @@  discard block
 block discarded – undo
59 59
 	 * @param string $field
60 60
 	 * @return bool
61 61
 	 */
62
-	public function is_optional( $field ) {
63
-		return in_array('optional', $this->data[ $field ] );
62
+	public function is_optional($field) {
63
+		return in_array('optional', $this->data[$field]);
64 64
 	}
65 65
 
66 66
 	/**
@@ -71,8 +71,8 @@  discard block
 block discarded – undo
71 71
 	 * @return array
72 72
 	 */
73 73
 	public function unique() {
74
-		$flat = $this->flatten( $this->remove_params() );
75
-		return array_values( array_unique( $flat ) );
74
+		$flat = $this->flatten($this->remove_params());
75
+		return array_values(array_unique($flat));
76 76
 	}
77 77
 
78 78
 	/**
@@ -84,8 +84,8 @@  discard block
 block discarded – undo
84 84
 	 * @param string $rule
85 85
 	 * @return string
86 86
 	 */
87
-	protected function extract_name( $rule ) {
88
-		return strstr( $rule, ':', true );
87
+	protected function extract_name($rule) {
88
+		return strstr($rule, ':', true);
89 89
 	}
90 90
 
91 91
 	/**
@@ -97,8 +97,8 @@  discard block
 block discarded – undo
97 97
 	 * @param string $rule
98 98
 	 * @return string
99 99
 	 */
100
-	protected function extract_params( $rule ) {
101
-		return ltrim( strstr($rule, ':'), ':');
100
+	protected function extract_params($rule) {
101
+		return ltrim(strstr($rule, ':'), ':');
102 102
 	}
103 103
 
104 104
 	/**
@@ -110,11 +110,11 @@  discard block
 block discarded – undo
110 110
 	 * @param array $array
111 111
 	 * @return array
112 112
 	 */
113
-	protected function flatten( array $array ) {
113
+	protected function flatten(array $array) {
114 114
 		$flat = array();
115
-		foreach( $array as $rule ) {
116
-			if( is_array( $rule ) ){
117
-				$flat = array_merge( $flat, $this->flatten( $rule ) );
115
+		foreach ($array as $rule) {
116
+			if (is_array($rule)) {
117
+				$flat = array_merge($flat, $this->flatten($rule));
118 118
 			} else {
119 119
 				$flat[] = $rule;
120 120
 			}
@@ -132,8 +132,8 @@  discard block
 block discarded – undo
132 132
 	 * @param int $index
133 133
 	 * @return bool
134 134
 	 */
135
-	protected function has_params( $field, $index ) {
136
-		return is_array( $this->data[ $field ][ $index ] );
135
+	protected function has_params($field, $index) {
136
+		return is_array($this->data[$field][$index]);
137 137
 	}
138 138
 
139 139
 	/**
@@ -145,8 +145,8 @@  discard block
 block discarded – undo
145 145
 	 * @param string $rule
146 146
 	 * @return bool
147 147
 	 */
148
-	protected function string_has_params( $rule ) {
149
-		return strpos( $rule, ':' );
148
+	protected function string_has_params($rule) {
149
+		return strpos($rule, ':');
150 150
 	}
151 151
 
152 152
 	/**
@@ -159,20 +159,20 @@  discard block
 block discarded – undo
159 159
 	 * @param array $rules
160 160
 	 * @return array
161 161
 	 */
162
-	protected function parse_rules( array $rules ) {
162
+	protected function parse_rules(array $rules) {
163 163
 		// WIP - works, but confusing - simplify or breakdown into small methods
164 164
 		$parsed = array();
165
-		$this->split_rules( $rules );
166
-		foreach( $rules as $field => $ruleset ) {
167
-			$parsed[ $field ] = array_map( function( $rule ) {
168
-				if ( $this->string_has_params( $rule ) ) {
165
+		$this->split_rules($rules);
166
+		foreach ($rules as $field => $ruleset) {
167
+			$parsed[$field] = array_map(function($rule) {
168
+				if ($this->string_has_params($rule)) {
169 169
 					return array(
170
-						'rule' => $this->extract_name( $rule ),
171
-						'params' => explode( ',', $this->extract_params( $rule ) )
170
+						'rule' => $this->extract_name($rule),
171
+						'params' => explode(',', $this->extract_params($rule))
172 172
 					);
173 173
 				}
174 174
 				return $rule;
175
-			}, $ruleset );
175
+			}, $ruleset);
176 176
 		}
177 177
 		return $parsed;
178 178
 	}
@@ -187,14 +187,14 @@  discard block
 block discarded – undo
187 187
 	 * @return array
188 188
 	 */
189 189
 	protected function remove_params() {
190
-		return array_map( function( $item ) {
191
-			foreach( $item as $rule ) {
192
-				if( $rule !== 'optional' ) {
193
-					$rules[] = ( is_string( $rule ) ) ? $rule : $rule['rule'];
190
+		return array_map(function($item) {
191
+			foreach ($item as $rule) {
192
+				if ($rule !== 'optional') {
193
+					$rules[] = (is_string($rule)) ? $rule : $rule['rule'];
194 194
 				}
195 195
 			}
196 196
 			return $rules;
197
-		}, $this->data );
197
+		}, $this->data);
198 198
 	}
199 199
 
200 200
 	/**
@@ -205,10 +205,10 @@  discard block
 block discarded – undo
205 205
 	 *
206 206
 	 * @param array $rules
207 207
 	 */
208
-	protected function split_rules( array &$rules ) {
208
+	protected function split_rules(array &$rules) {
209 209
 		// perhaps the $rules array structure should be validated here?...
210
-		$rules = array_map( function( $item ) {
211
-			return explode( '|', $item );
212
-		}, $rules );
210
+		$rules = array_map(function($item) {
211
+			return explode('|', $item);
212
+		}, $rules);
213 213
 	}
214 214
 }
Please login to merge, or discard this patch.
src/FormComposite.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use WFV\Abstraction\Composable;
6 6
 use WFV\Artisan\FormArtisan;
7
-use WFV\Contract\ValidateInterface;
8 7
 use WFV\Factory\ValidatorFactory;
9 8
 
10 9
 /**
Please login to merge, or discard this patch.
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 namespace WFV;
3
-defined( 'ABSPATH' ) || die();
3
+defined('ABSPATH') || die();
4 4
 
5 5
 use WFV\Abstraction\Composable;
6 6
 use WFV\Artisan\FormArtisan;
@@ -31,9 +31,9 @@  discard block
 block discarded – undo
31 31
 	 * @param ArtisanInterface $builder
32 32
 	 * @param string $action
33 33
 	 */
34
-	public function __construct( FormArtisan $builder, $action ) {
34
+	public function __construct(FormArtisan $builder, $action) {
35 35
 		$this->alias = $action;
36
-		$this->install( $builder->collection );
36
+		$this->install($builder->collection);
37 37
 		$this->validator = $builder->validator;
38 38
 	}
39 39
 
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
46 46
 	 * @param string $value Value to compare against.
47 47
 	 * @return string|null
48 48
 	 */
49
-	public function checked_if( $field = null, $value = null ) {
50
-		return $this->string_or_null( 'checked', $field, $value );
49
+	public function checked_if($field = null, $value = null) {
50
+		return $this->string_or_null('checked', $field, $value);
51 51
 	}
52 52
 
53 53
 	/**
@@ -61,8 +61,8 @@  discard block
 block discarded – undo
61 61
 	 * @param callable (optional) $callback
62 62
 	 * @return string
63 63
 	 */
64
-	public function display( $field = null, callable $callback = null ) {
65
-		echo $input = $this->utilize('input')->escape( $field );
64
+	public function display($field = null, callable $callback = null) {
65
+		echo $input = $this->utilize('input')->escape($field);
66 66
 		return $input;
67 67
 	}
68 68
 
@@ -100,10 +100,10 @@  discard block
 block discarded – undo
100 100
 	 */
101 101
 	public function is_valid() {
102 102
 		$is_valid = $this->validator->is_valid();
103
-		if( false === $is_valid ) {
104
-			$this->utilize('errors')->set_errors( $this->validator->errors() );
103
+		if (false === $is_valid) {
104
+			$this->utilize('errors')->set_errors($this->validator->errors());
105 105
 		}
106
-		$this->trigger_post_validate_action( $is_valid );
106
+		$this->trigger_post_validate_action($is_valid);
107 107
 		return $is_valid;
108 108
 	}
109 109
 
@@ -138,8 +138,8 @@  discard block
 block discarded – undo
138 138
 	 * @param string $value Value to compare against.
139 139
 	 * @return string|null
140 140
 	 */
141
-	public function selected_if( $field = null, $value = null ) {
142
-		return $this->string_or_null( 'selected', $field, $value );
141
+	public function selected_if($field = null, $value = null) {
142
+		return $this->string_or_null('selected', $field, $value);
143 143
 	}
144 144
 
145 145
 	/**
@@ -151,9 +151,9 @@  discard block
 block discarded – undo
151 151
 	 */
152 152
 	public function token_fields() {
153 153
 		// TODO - Move markup into something - perhaps a renderable interface?
154
-		$token_name = $this->alias . '_token';
155
-		echo $nonce_field = wp_nonce_field( $this->alias, $token_name, false, false );
156
-		echo $action_field = '<input type="hidden" name="action" value="'. $this->alias .'">';
154
+		$token_name = $this->alias.'_token';
155
+		echo $nonce_field = wp_nonce_field($this->alias, $token_name, false, false);
156
+		echo $action_field = '<input type="hidden" name="action" value="'.$this->alias.'">';
157 157
 	}
158 158
 
159 159
 	/**
@@ -164,15 +164,15 @@  discard block
 block discarded – undo
164 164
 	 * @param ValidatorFactory $factory
165 165
 	 * @return self
166 166
 	 */
167
-	public function validate( ValidatorFactory $factory ) {
167
+	public function validate(ValidatorFactory $factory) {
168 168
 		$rule_collection = $this->utilize('rules');
169
-		$rules = $rule_collection->get_array( true );
170
-		foreach( $rules as $field => $ruleset ) {
171
-			$input = $this->field_value( $field );
172
-			$optional = $rule_collection->is_optional( $field );
173
-			foreach( $ruleset as $index => $rule ) {
174
-				$params = $rule_collection->get_params( $field, $index );
175
-				$this->validator->validate( $factory->get( $rule ), $field, $input, $optional, $params );
169
+		$rules = $rule_collection->get_array(true);
170
+		foreach ($rules as $field => $ruleset) {
171
+			$input = $this->field_value($field);
172
+			$optional = $rule_collection->is_optional($field);
173
+			foreach ($ruleset as $index => $rule) {
174
+				$params = $rule_collection->get_params($field, $index);
175
+				$this->validator->validate($factory->get($rule), $field, $input, $optional, $params);
176 176
 			}
177 177
 		}
178 178
 		return $this;
@@ -187,11 +187,11 @@  discard block
 block discarded – undo
187 187
 	 *
188 188
 	 * @param string $field
189 189
 	 */
190
-	protected function field_value( $field ) {
190
+	protected function field_value($field) {
191 191
 		$input = $this->utilize('input');
192
-		if( $input->has( $field ) ) {
193
-			$input = $input->get_array( false );
194
-			return $input[ $field ];
192
+		if ($input->has($field)) {
193
+			$input = $input->get_array(false);
194
+			return $input[$field];
195 195
 		}
196 196
 		return null;
197 197
 	}
@@ -207,8 +207,8 @@  discard block
 block discarded – undo
207 207
 	 * @param string (optional) $value
208 208
 	 * @return string|null
209 209
 	 */
210
-	protected function string_or_null( $response, $field = null, $value = null ) {
211
-		return ( $this->input( $field )->contains( $field, $value ) ) ? $response : null;
210
+	protected function string_or_null($response, $field = null, $value = null) {
211
+		return ($this->input($field)->contains($field, $value)) ? $response : null;
212 212
 	}
213 213
 
214 214
 	/**
@@ -219,8 +219,8 @@  discard block
 block discarded – undo
219 219
 	 *
220 220
 	 * @param bool $is_valid
221 221
 	 */
222
-	protected function trigger_post_validate_action( $is_valid = false ) {
223
-		$action = ( true === $is_valid ) ? $this->alias : $this->alias .'_fail';
224
-		do_action( $action, $this );
222
+	protected function trigger_post_validate_action($is_valid = false) {
223
+		$action = (true === $is_valid) ? $this->alias : $this->alias.'_fail';
224
+		do_action($action, $this);
225 225
 	}
226 226
 }
Please login to merge, or discard this patch.
src/Validator.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 namespace WFV;
3
-defined( 'ABSPATH' ) || die();
3
+defined('ABSPATH') || die();
4 4
 
5 5
 use WFV\Contract\ValidateInterface;
6 6
 
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 	 * @return bool
41 41
 	 */
42 42
 	public function is_valid() {
43
-		return empty( $this->errors );
43
+		return empty($this->errors);
44 44
 	}
45 45
 
46 46
 	/**
@@ -54,11 +54,11 @@  discard block
 block discarded – undo
54 54
 	 * @param bool $optional
55 55
 	 * @param array (optional) $params
56 56
 	 */
57
-	public function validate( ValidateInterface $rule, $field, $value, $optional, $params = false ) {
58
-		$params[] = ( $params ) ? $field : false;
59
-		$valid = $rule->validate( $value, $optional, $params );
60
-		if( !$valid ){
61
-			$this->add_error( $field, $rule->template() );
57
+	public function validate(ValidateInterface $rule, $field, $value, $optional, $params = false) {
58
+		$params[] = ($params) ? $field : false;
59
+		$valid = $rule->validate($value, $optional, $params);
60
+		if (!$valid) {
61
+			$this->add_error($field, $rule->template());
62 62
 		}
63 63
 	}
64 64
 
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 	 * @param string $field
72 72
 	 * @param array $template
73 73
 	 */
74
-	protected function add_error( $field, array $template ) {
75
-		$this->errors[ $field ][ $template['name'] ] = $template['message'];
74
+	protected function add_error($field, array $template) {
75
+		$this->errors[$field][$template['name']] = $template['message'];
76 76
 	}
77 77
 }
Please login to merge, or discard this patch.
src/Contract/ValidateInterface.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 namespace WFV\Contract;
3
-defined( 'ABSPATH' ) || die();
3
+defined('ABSPATH') || die();
4 4
 
5 5
 
6 6
 /**
@@ -14,5 +14,5 @@  discard block
 block discarded – undo
14 14
 	/**
15 15
 	 * @return bool
16 16
 	 */
17
-	public function validate( $input = null, $optional = false );
17
+	public function validate($input = null, $optional = false);
18 18
 }
Please login to merge, or discard this patch.
src/Validators/Email.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 namespace WFV\Validators;
3
-defined( 'ABSPATH' ) || die();
3
+defined('ABSPATH') || die();
4 4
 
5 5
 use WFV\Validators\AbstractValidator;
6 6
 
@@ -34,10 +34,10 @@  discard block
 block discarded – undo
34 34
 	 * @param bool (optional) $optional
35 35
 	 * @return bool
36 36
 	 */
37
-	public function validate( $input = null, $optional = false ) {
37
+	public function validate($input = null, $optional = false) {
38 38
 		$v = $this->validator->create();
39
-		return ( $optional )
40
-			? $v->optional( $v->create()->email() )->validate( $input )
41
-			: $v->email()->validate( $input );
39
+		return ($optional)
40
+			? $v->optional($v->create()->email())->validate($input)
41
+			: $v->email()->validate($input);
42 42
 	}
43 43
 }
Please login to merge, or discard this patch.
src/Validators/Integer.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 namespace WFV\Validators;
3
-defined( 'ABSPATH' ) || die();
3
+defined('ABSPATH') || die();
4 4
 
5 5
 use WFV\Validators\AbstractValidator;
6 6
 
@@ -32,10 +32,10 @@  discard block
 block discarded – undo
32 32
 	 * @param bool (optional) $optional
33 33
 	 * @return bool
34 34
 	 */
35
-	public function validate( $input = null, $optional = false ) {
35
+	public function validate($input = null, $optional = false) {
36 36
 		$v = $this->validator->create();
37
-		return ( $optional )
38
-			? $v->optional( $v->create()->intVal() )->validate( $input )
39
-			: $v->intVal()->validate( $input );
37
+		return ($optional)
38
+			? $v->optional($v->create()->intVal())->validate($input)
39
+			: $v->intVal()->validate($input);
40 40
 	}
41 41
 }
Please login to merge, or discard this patch.
src/Validators/RequiredIf.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 namespace WFV\Validators;
3
-defined( 'ABSPATH' ) || die();
3
+defined('ABSPATH') || die();
4 4
 
5 5
 use WFV\Validators\AbstractValidator;
6 6
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	 * @param bool (optional) $optional
34 34
 	 * @return bool
35 35
 	 */
36
-	public function validate( $input = null, $optional = false ){
36
+	public function validate($input = null, $optional = false) {
37 37
 		$args = func_get_args();
38 38
 		$params = $args[2];
39 39
 		$other_field = $params[0];
@@ -43,9 +43,9 @@  discard block
 block discarded – undo
43 43
 		$v = $this->validator->create();
44 44
 
45 45
 		return $v->when(
46
-			$v->create()->key( $other_field, $v->create()->equals( $other_value ) ),
47
-			$v->create()->key( $field, $v->create()->notEmpty() ),
48
-			$v->create()->key( $field, $v->create()->alwaysValid() )
49
-		)->validate( $_POST );
46
+			$v->create()->key($other_field, $v->create()->equals($other_value)),
47
+			$v->create()->key($field, $v->create()->notEmpty()),
48
+			$v->create()->key($field, $v->create()->alwaysValid())
49
+		)->validate($_POST);
50 50
 	}
51 51
 }
Please login to merge, or discard this patch.
src/Validators/Digit.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 namespace WFV\Validators;
3
-defined( 'ABSPATH' ) || die();
3
+defined('ABSPATH') || die();
4 4
 
5 5
 use WFV\Validators\AbstractValidator;
6 6
 
@@ -32,10 +32,10 @@  discard block
 block discarded – undo
32 32
 	 * @param bool (optional) $optional
33 33
 	 * @return bool
34 34
 	 */
35
-	public function validate( $input = null, $optional = false ) {
35
+	public function validate($input = null, $optional = false) {
36 36
 		$v = $this->validator->create();
37
-		return ( $optional )
38
-			? $v->optional( $v->create()->digit()->length(1,1) )->validate( $input )
39
-			: $v->digit()->length(1,1)->validate( $input );
37
+		return ($optional)
38
+			? $v->optional($v->create()->digit()->length(1, 1))->validate($input)
39
+			: $v->digit()->length(1, 1)->validate($input);
40 40
 	}
41 41
 }
Please login to merge, or discard this patch.
src/Validators/AlphaDash.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 namespace WFV\Validators;
3
-defined( 'ABSPATH' ) || die();
3
+defined('ABSPATH') || die();
4 4
 
5 5
 use WFV\Validators\AbstractValidator;
6 6
 
@@ -32,10 +32,10 @@  discard block
 block discarded – undo
32 32
 	 * @param bool (optional) $optional
33 33
 	 * @return bool
34 34
 	 */
35
-	public function validate( $input = null, $optional = false ) {
35
+	public function validate($input = null, $optional = false) {
36 36
 		$v = $this->validator->create();
37
-		return ( $optional )
38
-			? $v->optional( $v->create()->alpha('-_') )->validate( $input )
39
-			: $v->alpha('-_')->validate( $input );
37
+		return ($optional)
38
+			? $v->optional($v->create()->alpha('-_'))->validate($input)
39
+			: $v->alpha('-_')->validate($input);
40 40
 	}
41 41
 }
Please login to merge, or discard this patch.