luyadev / luya

core/console/commands/BaseCrudController.php

Spacing +7 added lines, -7 removed lines

@@ -74,10 +74,10 @@ 
         }
         $rules = [];
         foreach ($types as $type => $columns) {
-            $rules[] = "[['" . implode("', '", $columns) . "'], '$type']";
+            $rules[] = "[['".implode("', '", $columns)."'], '$type']";
         }
         foreach ($lengths as $length => $columns) {
-            $rules[] = "[['" . implode("', '", $columns) . "'], 'string', 'max' => $length]";
+            $rules[] = "[['".implode("', '", $columns)."'], 'string', 'max' => $length]";
         }
         $db = $this->getDbConnection();
         // Unique indexes rules
@@ -88,12 +88,12 @@ 
                 if (!$this->isColumnAutoIncremental($table, $uniqueColumns)) {
                     $attributesCount = count($uniqueColumns);
                     if ($attributesCount === 1) {
-                        $rules[] = "[['" . $uniqueColumns[0] . "'], 'unique']";
+                        $rules[] = "[['".$uniqueColumns[0]."'], 'unique']";
                     } elseif ($attributesCount > 1) {
                         $labels = array_intersect_key($this->generateLabels($table), array_flip($uniqueColumns));
                         $lastLabel = array_pop($labels);
                         $columnsList = implode("', '", $uniqueColumns);
-                        $rules[] = "[['$columnsList'], 'unique', 'targetAttribute' => ['$columnsList'], 'message' => 'The combination of " . implode(', ', $labels) . " and $lastLabel has already been taken.']";
+                        $rules[] = "[['$columnsList'], 'unique', 'targetAttribute' => ['$columnsList'], 'message' => 'The combination of ".implode(', ', $labels)." and $lastLabel has already been taken.']";
                     }
                 }
             }
@@ -136,7 +136,7 @@ 
         $fullTableName = $tableName;
         if (($pos = strrpos($tableName, '.')) !== false) {
             if (($useSchemaName === null && $this->useSchemaName) || $useSchemaName) {
-                $schemaName = substr($tableName, 0, $pos) . '_';
+                $schemaName = substr($tableName, 0, $pos).'_';
             }
             $tableName = substr($tableName, $pos + 1);
         }
@@ -149,7 +149,7 @@ 
             if (($pos = strrpos($pattern, '.')) !== false) {
                 $pattern = substr($pattern, $pos + 1);
             }
-            $patterns[] = '/^' . str_replace('*', '(\w+)', $pattern) . '$/';
+            $patterns[] = '/^'.str_replace('*', '(\w+)', $pattern).'$/';
         }
         $className = $tableName;
         foreach ($patterns as $pattern) {
@@ -193,7 +193,7 @@ 
             } else {
                 $label = Inflector::camel2words($column->name);
                 if (!empty($label) && substr_compare($label, ' id', -3, 3, true) === 0) {
-                    $label = substr($label, 0, -3) . ' ID';
+                    $label = substr($label, 0, -3).' ID';
                 }
                 $labels[$column->name] = $label;
             }

core/base/BaseBootstrap.php

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
             // see if the module has a registerComponents method
             foreach ($module->registerComponents() as $componentId => $definition) {
                 if (!$app->has($componentId)) {
-                    Yii::trace('Register component ' . $componentId, __METHOD__);
+                    Yii::trace('Register component '.$componentId, __METHOD__);
                     $app->set($componentId, $definition);
                 }
             }

core/console/commands/ModuleController.php

Doc Comments +1 added lines

@@ -17,6 +17,7 @@
     /**
      * Humanize the class name
      *
+     * @param string $name
      * @return string The humanized name.
      */
     public function humanizeName($name)

Spacing +14 added lines, -14 removed lines

@@ -106,23 +106,23 @@ 
             }
         }
         
-        $appModulesFolder = Yii::$app->basePath . DIRECTORY_SEPARATOR . 'modules';
-        $moduleFolder = $appModulesFolder . DIRECTORY_SEPARATOR . $moduleName;
+        $appModulesFolder = Yii::$app->basePath.DIRECTORY_SEPARATOR.'modules';
+        $moduleFolder = $appModulesFolder.DIRECTORY_SEPARATOR.$moduleName;
         
         if (file_exists($moduleFolder)) {
-            return $this->outputError("The folder " . $moduleFolder . " exists already.");
+            return $this->outputError("The folder ".$moduleFolder." exists already.");
         }
         
         $folders = [
             'basePath' => $moduleFolder,
-            'adminPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'admin',
-            'adminAwsPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'admin' . DIRECTORY_SEPARATOR . 'aws',
-            'adminMigrationPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'admin' . DIRECTORY_SEPARATOR . 'migrations',
-            'frontendPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'frontend',
-            'frontendBlocksPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'frontend' . DIRECTORY_SEPARATOR . 'blocks',
-            'frontendControllersPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'frontend' . DIRECTORY_SEPARATOR . 'controllers',
-            'frontendViewsPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'frontend' . DIRECTORY_SEPARATOR . 'views',
-            'modelsPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'models',
+            'adminPath' => $moduleFolder.DIRECTORY_SEPARATOR.'admin',
+            'adminAwsPath' => $moduleFolder.DIRECTORY_SEPARATOR.'admin'.DIRECTORY_SEPARATOR.'aws',
+            'adminMigrationPath' => $moduleFolder.DIRECTORY_SEPARATOR.'admin'.DIRECTORY_SEPARATOR.'migrations',
+            'frontendPath' => $moduleFolder.DIRECTORY_SEPARATOR.'frontend',
+            'frontendBlocksPath' => $moduleFolder.DIRECTORY_SEPARATOR.'frontend'.DIRECTORY_SEPARATOR.'blocks',
+            'frontendControllersPath' => $moduleFolder.DIRECTORY_SEPARATOR.'frontend'.DIRECTORY_SEPARATOR.'controllers',
+            'frontendViewsPath' => $moduleFolder.DIRECTORY_SEPARATOR.'frontend'.DIRECTORY_SEPARATOR.'views',
+            'modelsPath' => $moduleFolder.DIRECTORY_SEPARATOR.'models',
         ];
 
         $ns = 'app\\modules\\'.$moduleName;
@@ -132,9 +132,9 @@ 
         }
         
         $contents = [
-            $moduleFolder. DIRECTORY_SEPARATOR . 'README.md' => $this->renderReadme($folders, $moduleName, $ns),
-            $moduleFolder. DIRECTORY_SEPARATOR . 'admin/Module.php' => $this->renderAdmin($folders, $moduleName, $ns),
-            $moduleFolder. DIRECTORY_SEPARATOR . 'frontend/Module.php' => $this->renderFrontend($folders, $moduleName, $ns),
+            $moduleFolder.DIRECTORY_SEPARATOR.'README.md' => $this->renderReadme($folders, $moduleName, $ns),
+            $moduleFolder.DIRECTORY_SEPARATOR.'admin/Module.php' => $this->renderAdmin($folders, $moduleName, $ns),
+            $moduleFolder.DIRECTORY_SEPARATOR.'frontend/Module.php' => $this->renderFrontend($folders, $moduleName, $ns),
         ];
         
         foreach ($contents as $fileName => $content) {

core/web/UrlManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -187,7 +187,7 @@
      * Remove the base url from a route
      *
      * @param string $route The route where the baseUrl should be removed from.
-     * @return mixed
+     * @return string
      */
     public function removeBaseUrl($route)
     {

Spacing +3 added lines, -3 removed lines

@@ -94,7 +94,7 @@ 
         $length = strlen($composition);
         $route = $parsedRequest[0];
         
-        if (substr($route, 0, $length+1) == $composition.'/') {
+        if (substr($route, 0, $length + 1) == $composition.'/') {
             $parsedRequest[0] = substr($parsedRequest[0], $length);
         }
         
@@ -302,10 +302,10 @@ 
         $params = (array) $params;
         $url = $this->internalCreateUrl($params);
         if (strpos($url, '://') === false) {
-            $url = $this->getHostInfo() . $url;
+            $url = $this->getHostInfo().$url;
         }
         if (is_string($scheme) && ($pos = strpos($url, '://')) !== false) {
-            $url = $scheme . substr($url, $pos);
+            $url = $scheme.substr($url, $pos);
         }
         return $url;
     }

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace luya\web;
 
 use Yii;
-
 use yii\web\BadRequestHttpException;
 use yii\web\NotFoundHttpException;
 

core/base/Widget.php

Spacing +1 added lines, -1 removed lines

@@ -39,6 +39,6 @@
         // get reflection
         $class = new ReflectionClass($this);
         // get path with alias
-        return '@app/views/widgets/' . Inflector::camel2id($class->getShortName());
+        return '@app/views/widgets/'.Inflector::camel2id($class->getShortName());
     }
 }

core/TagParser.php

Spacing +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
     {
         if (!is_object($this->tags[$tag])) {
             $this->tags[$tag] = Yii::createObject($this->tags[$tag]);
-            Yii::trace('tag parser object generated for:'. $tag, __CLASS__);
+            Yii::trace('tag parser object generated for:'.$tag, __CLASS__);
         }
     }
     

Doc Comments +1 added lines

@@ -116,6 +116,7 @@
     
     /**
      * Internal method to add a tag into the tags array.
+     * @param string $identifier
      */
     private function addTag($identifier, $tagObjectConfig)
     {

core/console/commands/HealthController.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
         
         @chdir(Yii::getAlias('@app'));
 
-        $this->output('The directory the health commands is applying to: ' . Yii::getAlias('@app'));
+        $this->output('The directory the health commands is applying to: '.Yii::getAlias('@app'));
         
         foreach ($this->folders as $folder => $writable) {
             $mode = ($writable) ? 0777 : 0775;

Doc Comments +2 added lines, -2 removed lines

@@ -35,7 +35,7 @@ 
     /**
      * Create all required directories an check whether they are writeable or not.
      *
-     * @return string The action output.
+     * @return integer The action output.
      */
     public function actionIndex()
     {
@@ -86,7 +86,7 @@ 
     /**
      * Test Mail-Component (Use --verbose=1 to enable smtp debug output)
      *
-     * @return boolean Whether successfull or not.
+     * @return integer|null Whether successfull or not.
      * @throws \Exception On smtp failure
      */
     public function actionMailer()

core/tag/tags/TelTag.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
      */
     public function parse($value, $sub)
     {
-        return Html::a(empty($sub) ? $value : $sub, 'tel:' . $this->ensureNumber($value));
+        return Html::a(empty($sub) ? $value : $sub, 'tel:'.$this->ensureNumber($value));
     }
         
     private function ensureNumber($number)

core/Yii.php

Spacing +1 added lines, -1 removed lines

@@ -18,5 +18,5 @@
 }
 
 spl_autoload_register(['Yii', 'autoload'], true, true);
-Yii::$classMap = require(LUYA_YII_VENDOR . '/classes.php');
+Yii::$classMap = require(LUYA_YII_VENDOR.'/classes.php');
 Yii::$container = new yii\di\Container();