Luolongfei\App\Exceptions\LlfException::__construct()

Complexity

Conditions	5
Paths	4

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function __construct($code, $additional = null, \Exception $previous = null)
    {
        $message = lang('exception_msg.' . $code) ?: '';

        if ($additional !== null) {
            if (is_array($additional)) {
                array_unshift($additional, $message);
                $message = call_user_func_array('sprintf', $additional);
            } else if (is_string($additional)) {
                $message = sprintf($message, $additional);

It seems like $message can also be of type array; however, parameter $format of sprintf() does only seem to accept string, maybe add an additional type check?

            }
        }

        parent::__construct($message . "(Error code: {$code})", $code, $previous);

Are you sure $message of type array|mixed|string can be used in concatenation?

    }
}