Luolongfei\App\Exceptions\LlfException

Complexity

Total Complexity

5

Size/Duplication

Total Lines	16
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	14	5

<?php
/**
 * 业务逻辑异常时抛出
 *
 * @author mybsdc <mybsdc@gmail.com>
 * @date 2018/8/10
 * @time 14:48
 */

namespace Luolongfei\App\Exceptions;

class LlfException extends \Exception
{
    public function __construct($code, $additional = null, \Exception $previous = null)
    {
        $message = lang('exception_msg.' . $code) ?: '';

        if ($additional !== null) {
            if (is_array($additional)) {
                array_unshift($additional, $message);
                $message = call_user_func_array('sprintf', $additional);
            } else if (is_string($additional)) {
                $message = sprintf($message, $additional);

It seems like $message can also be of type array; however, parameter $format of sprintf() does only seem to accept string, maybe add an additional type check?

            }
        }

        parent::__construct($message . "(Error code: {$code})", $code, $previous);

Are you sure $message of type array|mixed|string can be used in concatenation?

    }
}