FileValidator::validate() - Code Metrics - Inspection of "CamelCase namespaces + bug fixes" - lugnsk/micro - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 579af5...b29473 )

by Oleg

created 2016-02-08 20:56 UTC

FileValidator::validate() C

↳ Parent: FileValidator

Complexity

Conditions	12
Paths	8

Size

Total Lines	34
Code Lines	19

Duplication

Lines	17
Ratio	50 %

Metric	Value
dl	17
loc	34
rs	5.1612
cc	12
eloc	19
nc	8
nop	1

How to fix Complexity

<?php /** MicroFileValidator */

namespace Micro\Validator;

use Micro\Form\IFormModel;

/**
 * EmailValidator class file.
 *
 * @author Oleg Lunegov <[email protected]>
 * @link https://github.com/lugnsk/micro
 * @copyright Copyright &copy; 2013 Oleg Lunegov
 * @license /LICENSE
 * @package Micro
 * @subpackage Validator
 * @version 1.0
 * @since 1.0
 */
class FileValidator extends BaseValidator
{
    /**
     * @inheritdoc
     */
    public function validate(IFormModel $model)
    {
        foreach ($this->elements AS $element) {
            if (!$model->checkAttributeExists($element)) {
                $files = $this->container->request->getFiles();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                if (!empty($this->params['maxFiles']) && (count($files->files) > $this->params['maxFiles'])) {
                    $this->errors[] = 'Too many files in parameter ' . $element;

                    return false;
                }
                foreach ($files->files AS $fContext) {
                    if (!empty($this->params['types']) && (strpos($this->params['types'],

                                $fContext['type']) === false)
                    ) {
                        $this->errors[] = 'File ' . $fContext['name'] . ' not allowed type';

                        return false;
                    }
                    if (!empty($this->params['minSize']) && ($fContext['size'] < $this->params['minSize'])) {

                        $this->errors[] = 'File ' . $fContext['name'] . ' too small size';

                        return false;
                    }
                    if (!empty($this->params['maxSize']) && ($fContext['type'] > $this->params['maxSize'])) {

                        $this->errors[] = 'File ' . $fContext['name'] . ' too many size';

                        return false;
                    }
                }
            }
        }

        return true;
    }

    /**
     * @inheritdoc
     */
    public function client(IFormModel $model)
    {
        return '';
    }
}


Push — master ( 579af5...b29473 )

FileValidator::validate() C

Complexity

Size

Duplication

How to fix Complexity

Long Method

Available Fixes

1		<?php /** MicroFileValidator */
2
3		namespace Micro\Validator;
4
5		use Micro\Form\IFormModel;
6
7		/**
8		* EmailValidator class file.
9		*
10		* @author Oleg Lunegov <[email protected]>
11		* @link https://github.com/lugnsk/micro
12		* @copyright Copyright © 2013 Oleg Lunegov
13		* @license /LICENSE
14		* @package Micro
15		* @subpackage Validator
16		* @version 1.0
17		* @since 1.0
18		*/
19		class FileValidator extends BaseValidator
20		{
21		/**
22		* @inheritdoc
23		*/
24		public function validate(IFormModel $model)
25		{
26		foreach ($this->elements AS $element) {
27		if (!$model->checkAttributeExists($element)) {
28		$files = $this->container->request->getFiles();
		0 ignored issues – show Bug introduced 2016-02-08 21:03 UTC by Report Bug Copy Issue Report Accessing `request` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
29		if (!empty($this->params['maxFiles']) && (count($files->files) > $this->params['maxFiles'])) {
30		$this->errors[] = 'Too many files in parameter ' . $element;
31
32		return false;
33		}
34		foreach ($files->files AS $fContext) {
35	View Code Duplication	if (!empty($this->params['types']) && (strpos($this->params['types'],
		0 ignored issues – show Duplication introduced 2015-11-21 13:17 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		$fContext['type']) === false)
37		) {
38		$this->errors[] = 'File ' . $fContext['name'] . ' not allowed type';
39
40		return false;
41		}
42	View Code Duplication	if (!empty($this->params['minSize']) && ($fContext['size'] < $this->params['minSize'])) {
		0 ignored issues – show Duplication introduced 2015-11-21 13:17 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		$this->errors[] = 'File ' . $fContext['name'] . ' too small size';
44
45		return false;
46		}
47	View Code Duplication	if (!empty($this->params['maxSize']) && ($fContext['type'] > $this->params['maxSize'])) {
		0 ignored issues – show Duplication introduced 2015-11-21 13:17 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
48		$this->errors[] = 'File ' . $fContext['name'] . ' too many size';
49
50		return false;
51		}
52		}
53		}
54		}
55
56		return true;
57		}
58
59		/**
60		* @inheritdoc
61		*/
62		public function client(IFormModel $model)
63		{
64		return '';
65		}
66		}
67

lugnsk / micro

Push — master ( 579af5...b29473 )

FileValidator::validate() C

Complexity

Size

Duplication

How to fix Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like