Micro\Validator\FileValidator

Complexity

Total Complexity

13

Size/Duplication

Total Lines	48
Duplicated Lines	35.42 %

Coupling/Cohesion

Components	1
Dependencies	2

2 Methods

Rating	Name	Duplication	Size	Complexity
C	validate()	17	34	12
A	client()	0	4	1

<?php /** MicroFileValidator */

namespace Micro\Validator;

use Micro\Form\IFormModel;

/**
 * EmailValidator class file.
 *
 * @author Oleg Lunegov <testuser@mail.linpax.org>
 * @link https://github.com/lugnsk/micro
 * @copyright Copyright &copy; 2013 Oleg Lunegov
 * @license /LICENSE
 * @package Micro
 * @subpackage Validator
 * @version 1.0
 * @since 1.0
 */
class FileValidator extends BaseValidator
{
    /**
     * @inheritdoc
     */
    public function validate(IFormModel $model)
    {
        foreach ($this->elements AS $element) {
            if (!$model->checkAttributeExists($element)) {
                $files = $this->container->request->getFiles();

Accessing request on the interface Micro\Base\IContainer suggest that you code against a concrete implementation. How about adding an instanceof check?

                if (!empty($this->params['maxFiles']) && (count($files->files) > $this->params['maxFiles'])) {
                    $this->errors[] = 'Too many files in parameter ' . $element;

                    return false;
                }
                foreach ($files->files AS $fContext) {
                    if (!empty($this->params['types']) && (strpos($this->params['types'],

This code seems to be duplicated across your project.

                                $fContext['type']) === false)
                    ) {
                        $this->errors[] = 'File ' . $fContext['name'] . ' not allowed type';

                        return false;
                    }
                    if (!empty($this->params['minSize']) && ($fContext['size'] < $this->params['minSize'])) {

This code seems to be duplicated across your project.

                        $this->errors[] = 'File ' . $fContext['name'] . ' too small size';

                        return false;
                    }
                    if (!empty($this->params['maxSize']) && ($fContext['type'] > $this->params['maxSize'])) {

This code seems to be duplicated across your project.

                        $this->errors[] = 'File ' . $fContext['name'] . ' too many size';

                        return false;
                    }
                }
            }
        }

        return true;
    }

    /**
     * @inheritdoc
     */
    public function client(IFormModel $model)
    {
        return '';
    }
}