Completed
Push — master ( 97844e...03cde8 )
by Paul
03:58 queued 14s
created
src/Response/SIP2Response.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -25,11 +25,11 @@  discard block
 block discarded – undo
25 25
     const AG_PRINT_LINE = 'AG';
26 26
     const AH_DUE_DATE = 'AH';
27 27
     const AJ_TITLE_IDENTIFIER = 'AJ';
28
-    const AM_LIBRARY_NAME='AM';
29
-    const AN_TERMINAL_LOCATION='AN';
28
+    const AM_LIBRARY_NAME = 'AM';
29
+    const AN_TERMINAL_LOCATION = 'AN';
30 30
     const AO_INSTITUTION_ID = 'AO';
31 31
     const AP_CURRENT_LOCATION = 'AP';
32
-    const AQ_PERMANENT_LOCATION='AQ';
32
+    const AQ_PERMANENT_LOCATION = 'AQ';
33 33
     const AS_HOLD_ITEMS = 'AS';
34 34
     const AT_OVERDUE_ITEMS = 'AT';
35 35
     const AU_CHARGED_ITEMS = 'AU';
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
     const BF_HOME_PHONE_NUMBER = 'BF';
41 41
     const BG_OWNER = 'BG';
42 42
     const BH_CURRENCY_TYPE = 'BH';
43
-    const BK_TRANSACTION_ID= 'BK';
43
+    const BK_TRANSACTION_ID = 'BK';
44 44
     const BL_VALID_PATRON = 'BL';
45 45
     const BM_RENEWED_ITEMS = 'BM';
46 46
     const BN_UNRENEWED_ITEMS = 'BN';
@@ -50,18 +50,18 @@  discard block
 block discarded – undo
50 50
     const BU_RECALL_ITEMS = 'BU';
51 51
     const BV_FEE_AMOUNT = 'BV';
52 52
     const BW_EXPIRATION_DATE = 'BW';
53
-    const BX_SUPPORTED_MESSAGES='BX';
53
+    const BX_SUPPORTED_MESSAGES = 'BX';
54 54
     const BZ_HOLD_ITEMS_LIMIT = 'BZ';
55 55
     const CA_OVERDUE_ITEMS_LIMIT = 'CA';
56 56
     const CB_CHARGED_ITEMS_LIMIT = 'CB';
57 57
     const CC_FEE_LIMIT = 'CC';
58 58
     const CD_UNAVAILABLE_HOLD_ITEMS = 'CD';
59 59
     const CF_HOLD_QUEUE_LENGTH = 'CF';
60
-    const CH_ITEM_PROPERTIES= 'CH';
60
+    const CH_ITEM_PROPERTIES = 'CH';
61 61
     const CI_SECURITY_INHIBIT = 'CI';
62 62
     const CJ_RECALL_DATE = 'CJ';
63
-    const CK_MEDIA_TYPE= 'CK';
64
-    const CL_SORT_BIN='CL';
63
+    const CK_MEDIA_TYPE = 'CK';
64
+    const CL_SORT_BIN = 'CL';
65 65
     const CM_HOLD_PICKUP_DATE = 'CM';
66 66
     const CQ_VALID_PATRON_PASSWORD = 'CQ';
67 67
 
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
     public static function parse($raw): SIP2Response
139 139
     {
140 140
         if (empty($raw) || !self::checkCRC($raw)) {
141
-            throw new LogicException("Empty string or bad CRC not expected here");//@codeCoverageIgnore
141
+            throw new LogicException("Empty string or bad CRC not expected here"); //@codeCoverageIgnore
142 142
         }
143 143
 
144 144
         $type = substr($raw, 0, 2);
@@ -154,8 +154,8 @@  discard block
 block discarded – undo
154 154
     public static function checkCRC($raw)
155 155
     {
156 156
         if (preg_match('/^(.*AZ)(.{4})$/', trim($raw), $match)) {
157
-            $plaintext=$match[1];
158
-            $checksum=$match[2];
157
+            $plaintext = $match[1];
158
+            $checksum = $match[2];
159 159
             return self::crc($plaintext) == $checksum;
160 160
         }
161 161
 
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
 
185 185
             //we ignore anything with no value
186 186
             $clean = trim($value, "\x00..\x1F");
187
-            if ($clean==='') {
187
+            if ($clean === '') {
188 188
                 continue;
189 189
             }
190 190
 
@@ -195,11 +195,11 @@  discard block
 block discarded – undo
195 195
                 //we tolerate unexpected values and treat them as array types
196 196
                 //named after the code if we don't have a definition for it
197 197
                 if (!isset(self::$mapCodeToVarDef[$field])) {
198
-                    self::$mapCodeToVarDef[$field]=[
198
+                    self::$mapCodeToVarDef[$field] = [
199 199
                         'name' => $field,
200 200
                         'type' => 'array'
201 201
                     ];
202
-                    $name=$field;
202
+                    $name = $field;
203 203
                 } else {
204 204
                     $name = self::$mapCodeToVarDef[$field]['name'];
205 205
                 }
Please login to merge, or discard this patch.