GetTerminals::init() - Code Metrics - Inspection of "Added GetTerminals method together with tests" - loevgaard/altapay-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f222c1...bc6c1b )

by Joachim

created 2017-06-30 11:53 UTC

GetTerminals::init() B

↳ Parent: GetTerminals

Complexity

Conditions	5
Paths	3

Size

Total Lines	13
Code Lines	8

Duplication

Lines	7
Ratio	53.85 %

Importance

Changes

Metric	Value
dl	7
loc	13
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	8
nc	3
nop	0

<?php
namespace Loevgaard\AltaPay\Response;

use Loevgaard\AltaPay\Response\GetTerminals\Terminal;

class GetTerminals extends Response
{
    /**
     * @var string
     */
    protected $result;

    /**
     * @var Terminal[]
     */
    protected $terminals;

    protected function init()
    {
        $this->terminals = [];
        $this->result = (string)$this->xmlDoc->Body->Result;

        if (isset($this->xmlDoc->Body->Terminals) &&

            isset($this->xmlDoc->Body->Terminals->Terminal) &&
            !empty($this->xmlDoc->Body->Terminals->Terminal)) {
            foreach ($this->xmlDoc->Body->Terminals->Terminal as $terminalXml) {
                $this->terminals[] = new Terminal($this->getResponse(), $terminalXml);
            }
        }
    }

    /**
     * @return string
     */
    public function getResult() : string
    {
        return $this->result;
    }

    /**
     * @return Terminal[]
     */
    public function getTerminals() : array

    {
        return $this->terminals;
    }
}


1		<?php
2		namespace Loevgaard\AltaPay\Response;
3
4		use Loevgaard\AltaPay\Response\GetTerminals\Terminal;
5
6		class GetTerminals extends Response
7		{
8		/**
9		* @var string
10		*/
11		protected $result;
12
13		/**
14		* @var Terminal[]
15		*/
16		protected $terminals;
17
18		protected function init()
19		{
20		$this->terminals = [];
21		$this->result = (string)$this->xmlDoc->Body->Result;
22
23	View Code Duplication	if (isset($this->xmlDoc->Body->Terminals) &&
		0 ignored issues – show Duplication introduced 2017-06-30 12:06 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
24		isset($this->xmlDoc->Body->Terminals->Terminal) &&
25		!empty($this->xmlDoc->Body->Terminals->Terminal)) {
26		foreach ($this->xmlDoc->Body->Terminals->Terminal as $terminalXml) {
27		$this->terminals[] = new Terminal($this->getResponse(), $terminalXml);
28		}
29		}
30		}
31
32		/**
33		* @return string
34		*/
35		public function getResult() : string
36		{
37		return $this->result;
38		}
39
40		/**
41		* @return Terminal[]
42		*/
43		public function getTerminals() : array
		0 ignored issues – show Coding Style Best Practice introduced 2017-06-30 12:06 UTC by Report Bug Copy Issue Report Please use `__construct()` instead of a PHP4-style constructor that is named after the class. Loading history...
44		{
45		return $this->terminals;
46		}
47		}
48

loevgaard / altapay-php-sdk

Push — master ( f222c1...bc6c1b )

GetTerminals::init() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like