Loevgaard\AltaPay\Response\GetTerminals

Complexity

Total Complexity

7

Size/Duplication

Total Lines	42
Duplicated Lines	16.67 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	init()	7	13	5
A	getResult()	0	4	1
A	getTerminals()	0	4	1

<?php
namespace Loevgaard\AltaPay\Response;

use Loevgaard\AltaPay\Response\GetTerminals\Terminal;

class GetTerminals extends Response
{
    /**
     * @var string
     */
    protected $result;

    /**
     * @var Terminal[]
     */
    protected $terminals;

    protected function init()
    {
        $this->terminals = [];
        $this->result = (string)$this->xmlDoc->Body->Result;

        if (isset($this->xmlDoc->Body->Terminals) &&

This code seems to be duplicated across your project.

            isset($this->xmlDoc->Body->Terminals->Terminal) &&
            !empty($this->xmlDoc->Body->Terminals->Terminal)) {
            foreach ($this->xmlDoc->Body->Terminals->Terminal as $terminalXml) {
                $this->terminals[] = new Terminal($this->getResponse(), $terminalXml);
            }
        }
    }

    /**
     * @return string
     */
    public function getResult() : string
    {
        return $this->result;
    }

    /**
     * @return Terminal[]
     */
    public function getTerminals() : array

Please use __construct() instead of a PHP4-style constructor that is named after the class.

    {
        return $this->terminals;
    }
}