and let?s assume the following content of Bar.php:
// Bar.phpnamespaceOtherDir;useSomeDir\Foo;// This now conflicts the class OtherDir\Foo
If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the
same runtime, you will see a PHP error such as the following:
PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php
However, as OtherDir/Foo.php does not necessarily have to be loaded and the
error is only triggered if it is loaded before OtherDir/Bar.php, this problem
might go unnoticed for a while. In order to prevent this error from surfacing,
you must import the namespace with a different alias:
// Bar.phpnamespaceOtherDir;useSomeDir\FooasSomeDirFoo;// There is no conflict anymore.
The expression return $this->products could return the type Loevgaard\SyliusBrandPlu...odel\ProductInterface[] which is incompatible with the type-hinted return Doctrine\Common\Collections\Collection. Consider adding an additional type-check to rule them out.
Loading history...
38
}
39
40
/**
41
* {@inheritdoc}
42
*/
43
public function hasProduct(BrandAwareInterface $product): bool
44
{
45
return $this->products->contains($product);
46
}
47
48
/**
49
* {@inheritdoc}
50
*/
51
public function addProduct(BrandAwareInterface $product): void
Accessing products on the interface Loevgaard\SyliusBrandPlu...\ProductsAwareInterface suggest that you code against a concrete implementation. How about adding an instanceof check?
Loading history...
57
}
58
}
59
60
/**
61
* {@inheritdoc}
62
*/
63
public function removeProduct(BrandAwareInterface $product): void
loevgaard /
SyliusBrandPlugin
Loading history...
Let?s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let?s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: