Loevgaard\SyliusBrandPlugin\Entity\ProductsAwareTrait

Complexity

Total Complexity

8

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	initializeProductsCollection()	0	3	1
A	addProduct()	0	6	2
A	removeProduct()	0	5	2
A	hasProduct()	0	3	1
A	hasProducts()	0	3	1
A	getProducts()	0	3	1

<?php

declare(strict_types=1);

namespace Loevgaard\SyliusBrandPlugin\Entity;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Sylius\Component\Core\Model\ProductInterface;

This use statement conflicts with another class in this namespace, Loevgaard\SyliusBrandPlugin\Entity\ProductInterface. Consider defining an alias.

trait ProductsAwareTrait
{
    /** @var Collection|BrandAwareInterface[]|ProductInterface[] */
    protected $products;

    /**
     * {@inheritdoc}
     */
    public function initializeProductsCollection(): void
    {
        $this->products = new ArrayCollection();
    }

    /**
     * {@inheritdoc}
     */
    public function hasProducts(): bool
    {
        return $this->products->count() > 0;
    }

    /**
     * {@inheritdoc}
     */
    public function getProducts(): Collection
    {
        return $this->products;

The expression return $this->products could return the type Loevgaard\SyliusBrandPlugin\Entity\BrandAwareInterface[]|Sylius\Component\Core\Model\ProductInterface[] which is incompatible with the type-hinted return Doctrine\Common\Collections\Collection. Consider adding an additional type-check to rule them out.

    }

    /**
     * {@inheritdoc}
     */
    public function hasProduct(BrandAwareInterface $product): bool
    {
        return $this->products->contains($product);
    }

    /**
     * {@inheritdoc}
     */
    public function addProduct(BrandAwareInterface $product): void
    {
        if (false === $this->hasProduct($product)) {
            /** @var ProductsAwareInterface $this */
            $product->setBrand($this);
            $this->products->add($product);

Accessing products on the interface Loevgaard\SyliusBrandPlugin\Entity\ProductsAwareInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        }
    }

    /**
     * {@inheritdoc}
     */
    public function removeProduct(BrandAwareInterface $product): void
    {
        if (true === $this->hasProduct($product)) {
            $product->setBrand(null);
            $this->products->removeElement($product);
        }
    }
}