locomotivemtl / charcoal-property

src/Charcoal/Property/DateTimeProperty.php

Spacing +2 added lines, -2 removed lines

@@ -161,8 +161,8 @@
     private function dateTimeVal($val)
     {
         if ($val === null ||
-            (is_string($val) && ! strlen(trim($val))) ||
-            (is_array($val) && ! count(array_filter($val, 'strlen')))
+            (is_string($val) && !strlen(trim($val))) ||
+            (is_array($val) && !count(array_filter($val, 'strlen')))
         ) {
             return null;
         }

Doc Comments +2 added lines, -2 removed lines

@@ -270,7 +270,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function validationMethods()
     {
@@ -365,7 +365,7 @@ 
     }
 
     /**
-     * @param  integer|string $timestamp Timestamp.
+     * @param  integer $timestamp Timestamp.
      * @return boolean
      */
     private function isValidTimeStamp($timestamp)

src/Charcoal/Property/AbstractProperty.php

Unused Use Statements -2 removed lines

@@ -3,7 +3,6 @@ 
 namespace Charcoal\Property;
 
 use PDO;
-use Exception;
 use LogicException;
 use RuntimeException;
 use InvalidArgumentException;
@@ -11,7 +10,6 @@ 
 // From PSR-3
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerAwareTrait;
-use Psr\Log\NullLogger;
 
 // From Pimple
 use Pimple\Container;

Doc Comments +1 added lines, -1 removed lines

@@ -741,7 +741,7 @@
     /**
      * Legacy support of active() instead of getActive().
      *
-     * @return string
+     * @return boolean
      */
     public function active()
     {

Spacing +3 added lines, -3 removed lines

@@ -351,13 +351,13 @@ 
                 return $val;
             }
 
-            $val = array_map([ $this, 'parseOne' ], $val);
+            $val = array_map([$this, 'parseOne'], $val);
         } else {
             if ($this['l10n']) {
                 $val = $this->parseValAsL10n($val);
 
                 if ($val) {
-                    $val->sanitize([ $this, 'parseOne' ]);
+                    $val->sanitize([$this, 'parseOne']);
                 }
             } else {
                 $val = $this->parseOne($val);
@@ -478,7 +478,7 @@ 
     public function getLabel()
     {
         if ($this->label === null) {
-            return ucwords(str_replace([ '.', '_' ], ' ', $this->ident()));
+            return ucwords(str_replace(['.', '_'], ' ', $this->ident()));
         }
 
         return $this->label;

src/Charcoal/Property/ModelStructureProperty.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Charcoal\Property;
 
-use PDO;
 use ArrayAccess;
 use RuntimeException;
 use InvalidArgumentException;

Spacing +1 added lines, -1 removed lines

@@ -570,7 +570,7 @@
                 $objs = (array)$this->structureVal($val);
                 $val  = [];
                 if (!empty($objs)) {
-                    $val  = [];
+                    $val = [];
                     foreach ($objs as $obj) {
                         $obj->saveProperties();
                         $val[] = $obj->data();

src/Charcoal/Property/StructureProperty.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use PDO;
 use InvalidArgumentException;
-use UnexpectedValueException;
 
 // From 'charcoal-translator'
 use Charcoal\Translator\Translation;

src/Charcoal/Property/PropertyField.php

Doc Comments +1 added lines, -1 removed lines

@@ -277,7 +277,7 @@
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function defaultVal()
     {

src/Charcoal/Property/ObjectProperty.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Traversable;
 use RuntimeException;
 use InvalidArgumentException;
-
 use PDO;
 
 // From PSR-6

src/Charcoal/Property/DescribablePropertyTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
      *
      * @param  array $propertyIdents Optional. List of property identifiers
      *     for retrieving a subset of property objects.
-     * @return PropertyInterface[]|\Generator
+     * @return \Generator
      */
     public function properties(array $propertyIdents = null)
     {

src/Charcoal/Property/EmailProperty.php

Doc Comments +1 added lines, -1 removed lines

@@ -271,7 +271,7 @@
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function validationMethods()
     {

src/Charcoal/Property/FileProperty.php

Doc Comments +4 added lines, -4 removed lines

@@ -216,7 +216,7 @@ 
     /**
      * Set the MIME type.
      *
-     * @param  mixed $type The file MIME type.
+     * @param  string|false $type The file MIME type.
      * @throws InvalidArgumentException If the MIME type argument is not a string.
      * @return FileProperty Chainable
      */
@@ -362,7 +362,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function validationMethods()
     {
@@ -888,7 +888,7 @@ 
     /**
      * Generate a unique filename.
      *
-     * @param  string|array $filename The filename to alter.
+     * @param  string $filename The filename to alter.
      * @throws InvalidArgumentException If the given filename is invalid.
      * @return string
      */
@@ -1164,7 +1164,7 @@ 
      *
      * @param  array    $uploadedFiles  The non-normalized tree of uploaded file data.
      * @param  callable $filterCallback If specified, the callback function to used to filter files.
-     * @param  mixed    $searchKey      If specified, then only top-level keys containing these values are returned.
+     * @param  string    $searchKey      If specified, then only top-level keys containing these values are returned.
      * @return array A tree of normalized $_FILE entries.
      */
     public static function parseUploadedFiles(array $uploadedFiles, callable $filterCallback = null, $searchKey = null)

Indentation +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
         UPLOAD_ERR_OK         => 'There is no error, the file uploaded with success',
         UPLOAD_ERR_INI_SIZE   => 'The uploaded file exceeds the upload_max_filesize directive in php.ini',
         UPLOAD_ERR_FORM_SIZE  => 'The uploaded file exceeds the MAX_FILE_SIZE directive'.
-                                 'that was specified in the HTML form',
+                                    'that was specified in the HTML form',
         UPLOAD_ERR_PARTIAL    => 'The uploaded file was only partially uploaded',
         UPLOAD_ERR_NO_FILE    => 'No file was uploaded',
         UPLOAD_ERR_NO_TMP_DIR => 'Missing a temporary folder',

Spacing +7 added lines, -7 removed lines

@@ -549,7 +549,7 @@ 
     {
         // Bag value if singular
         if (!is_array($values) || isset($values['id'])) {
-            $values = [ $values ];
+            $values = [$values];
         }
 
         $parsed = [];
@@ -577,7 +577,7 @@ 
     {
         // Bag value if singular
         if (isset($files['error'])) {
-            $files = [ $files ];
+            $files = [$files];
         }
 
         $parsed = [];
@@ -606,7 +606,7 @@ 
 
         if ($this['multiple']) {
             if (!is_array($values)) {
-                $values = empty($values) && !is_numeric($values) ? [] : [ $values ];
+                $values = empty($values) && !is_numeric($values) ? [] : [$values];
             }
         } else {
             if (is_array($values)) {
@@ -680,7 +680,7 @@ 
             return null;
         }
 
-        $basePath  = $this->basePath();
+        $basePath = $this->basePath();
         $targetPath = str_replace($basePath, '', $targetPath);
 
         return $targetPath;
@@ -773,7 +773,7 @@ 
             // @todo: Feedback
             $this->logger->debug(
                 'Path does not exist. Attempting to create path '.$uploadPath.'.',
-                [ get_called_class().'::'.__FUNCTION__ ]
+                [get_called_class().'::'.__FUNCTION__]
             );
             mkdir($uploadPath, 0777, true);
         }
@@ -847,7 +847,7 @@ 
     public function sanitizeFilename($filename)
     {
         // Remove blacklisted caharacters
-        $blacklist = [ '/', '\\', '\0', '*', ':', '?', '"', '<', '>', '|', '#', '&', '!', '`', ' ' ];
+        $blacklist = ['/', '\\', '\0', '*', ':', '?', '"', '<', '>', '|', '#', '&', '!', '`', ' '];
         $filename = str_replace($blacklist, '_', $filename);
 
         // Avoid hidden file
@@ -1181,7 +1181,7 @@ 
     {
         $propIdent = $this->ident();
 
-        $filterErrNoFile = function (array $file) {
+        $filterErrNoFile = function(array $file) {
             return $file['error'] !== UPLOAD_ERR_NO_FILE;
         };
         $uploadedFiles = static::parseUploadedFiles($_FILES, $filterErrNoFile, $propIdent);