locomotivemtl / charcoal-property

src/Charcoal/Property/DateTimeProperty.php

Spacing +2 added lines, -2 removed lines

@@ -161,8 +161,8 @@
     private function dateTimeVal($val)
     {
         if ($val === null ||
-            (is_string($val) && ! strlen(trim($val))) ||
-            (is_array($val) && ! count(array_filter($val, 'strlen')))
+            (is_string($val) && !strlen(trim($val))) ||
+            (is_array($val) && !count(array_filter($val, 'strlen')))
         ) {
             return null;
         }

Doc Comments +2 added lines, -2 removed lines

@@ -270,7 +270,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function validationMethods()
     {
@@ -365,7 +365,7 @@ 
     }
 
     /**
-     * @param  integer|string $timestamp Timestamp.
+     * @param  integer $timestamp Timestamp.
      * @return boolean
      */
     private function isValidTimeStamp($timestamp)

src/Charcoal/Property/AbstractProperty.php

Unused Use Statements -2 removed lines

@@ -3,7 +3,6 @@ 
 namespace Charcoal\Property;
 
 use PDO;
-use Exception;
 use LogicException;
 use RuntimeException;
 use InvalidArgumentException;
@@ -11,7 +10,6 @@ 
 // From PSR-3
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerAwareTrait;
-use Psr\Log\NullLogger;
 
 // From Pimple
 use Pimple\Container;

Doc Comments +1 added lines, -1 removed lines

@@ -741,7 +741,7 @@
     /**
      * Legacy support of active() instead of getActive().
      *
-     * @return string
+     * @return boolean
      */
     public function active()
     {

Spacing +3 added lines, -3 removed lines

@@ -351,13 +351,13 @@ 
                 return $val;
             }
 
-            $val = array_map([ $this, 'parseOne' ], $val);
+            $val = array_map([$this, 'parseOne'], $val);
         } else {
             if ($this['l10n']) {
                 $val = $this->parseValAsL10n($val);
 
                 if ($val) {
-                    $val->sanitize([ $this, 'parseOne' ]);
+                    $val->sanitize([$this, 'parseOne']);
                 }
             } else {
                 $val = $this->parseOne($val);
@@ -478,7 +478,7 @@ 
     public function getLabel()
     {
         if ($this->label === null) {
-            return ucwords(str_replace([ '.', '_' ], ' ', $this->ident()));
+            return ucwords(str_replace(['.', '_'], ' ', $this->ident()));
         }
 
         return $this->label;

src/Charcoal/Property/ModelStructureProperty.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Charcoal\Property;
 
-use PDO;
 use ArrayAccess;
 use RuntimeException;
 use InvalidArgumentException;

Spacing +1 added lines, -1 removed lines

@@ -570,7 +570,7 @@
                 $objs = (array)$this->structureVal($val);
                 $val  = [];
                 if (!empty($objs)) {
-                    $val  = [];
+                    $val = [];
                     foreach ($objs as $obj) {
                         $obj->saveProperties();
                         $val[] = $obj->data();

src/Charcoal/Property/StructureProperty.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use PDO;
 use InvalidArgumentException;
-use UnexpectedValueException;
 
 // From 'charcoal-translator'
 use Charcoal\Translator\Translation;

src/Charcoal/Property/PropertyField.php

Doc Comments +1 added lines, -1 removed lines

@@ -277,7 +277,7 @@
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function defaultVal()
     {

src/Charcoal/Property/ObjectProperty.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Traversable;
 use RuntimeException;
 use InvalidArgumentException;
-
 use PDO;
 
 // From PSR-6

src/Charcoal/Property/DescribablePropertyTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
      *
      * @param  array $propertyIdents Optional. List of property identifiers
      *     for retrieving a subset of property objects.
-     * @return PropertyInterface[]|\Generator
+     * @return \Generator
      */
     public function properties(array $propertyIdents = null)
     {

src/Charcoal/Property/EmailProperty.php

Doc Comments +1 added lines, -1 removed lines

@@ -271,7 +271,7 @@
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function validationMethods()
     {

src/Charcoal/Property/ImageProperty.php

Doc Comments +3 added lines, -3 removed lines

@@ -159,7 +159,7 @@ 
      *
      * @param  string|boolean $event A specific event to check or a global flag to set.
      * @throws OutOfBoundsException If the effects event does not exist.
-     * @return mixed Returns TRUE or FALSE if the property applies effects for the given event.
+     * @return boolean Returns TRUE or FALSE if the property applies effects for the given event.
      */
     public function canApplyEffects($event)
     {
@@ -179,7 +179,7 @@ 
     /**
      * Retrieve the supported events where effects can be applied.
      *
-     * @return array
+     * @return string[]
      */
     public function acceptedEffectsEvents()
     {
@@ -465,7 +465,7 @@ 
      * @param  array               $effects The effects to apply on the target.
      * @param  ImageInterface|null $image   Optional. The image for processing.
      * @throws InvalidArgumentException If the $value is not a string.
-     * @return mixed Returns the processed target or NULL.
+     * @return null|string Returns the processed target or NULL.
      */
     private function processEffectsOne($value, array $effects = null, ImageInterface $image = null)
     {

Spacing +1 added lines, -1 removed lines

@@ -418,7 +418,7 @@
                 'reset'   => false,
                 'copy'    => null,
             ];
-            $fxGroup   = $blueprint;
+            $fxGroup = $blueprint;
             foreach ($effects as $effect) {
                 if (isset($effect['type']) && $effect['type'] === 'condition') {
                     $grouped[] = array_merge(