Test Setup Failed
Push — master ( d9b8f8...8f3561 )
by Chauncey
02:00
created
src/Charcoal/Model/ModelValidator.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 
21 21
         $ret = true;
22 22
         foreach ($props as $ident => $p) {
23
-            if (!$p ||  !$p->active()) {
23
+            if (!$p || !$p->active()) {
24 24
                 continue;
25 25
             }
26 26
             $valid = $p->validate();
Please login to merge, or discard this patch.
src/Charcoal/Model/AbstractModel.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@
 block discarded – undo
92 92
 
93 93
         // Optional StorableInterface dependencies
94 94
         if (isset($data['source'])) {
95
-             $this->setSource($data['source']);
95
+                $this->setSource($data['source']);
96 96
         }
97 97
         if (isset($data['source_factory'])) {
98 98
             $this->setSourceFactory($data['source_factory']);
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -308,7 +308,7 @@
 block discarded – undo
308 308
     public function propertyValue($propertyIdent)
309 309
     {
310 310
         $getter = $this->camelize($propertyIdent);
311
-        $method = [ $this, $getter ];
311
+        $method = [$this, $getter];
312 312
 
313 313
         if (is_callable($method)) {
314 314
             return call_user_func($method);
Please login to merge, or discard this patch.
src/Charcoal/Model/Service/MetadataLoader.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -383,7 +383,7 @@  discard block
 block discarded – undo
383 383
         $classname = $this->identToClassname($ident);
384 384
 
385 385
         if (!class_exists($classname) && !interface_exists($classname)) {
386
-            return [ $ident ];
386
+            return [$ident];
387 387
         }
388 388
 
389 389
         $classes   = array_values(class_parents($classname));
@@ -510,7 +510,7 @@  discard block
 block discarded – undo
510 510
      */
511 511
     private function filenameFromIdent($ident)
512 512
     {
513
-        $filename  = str_replace([ '\\' ], '.', $ident);
513
+        $filename  = str_replace(['\\'], '.', $ident);
514 514
         $filename .= '.json';
515 515
 
516 516
         return $filename;
Please login to merge, or discard this patch.
src/Charcoal/Model/ServiceProvider/ModelServiceProvider.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -67,10 +67,10 @@  discard block
 block discarded – undo
67 67
          * @param Container $container A Pimple DI container instance.
68 68
          * @return ModelFactory
69 69
          */
70
-        $container['model/factory'] = function (Container $container) {
70
+        $container['model/factory'] = function(Container $container) {
71 71
             return new Factory([
72 72
                 'base_class' => ModelInterface::class,
73
-                'arguments'  => [ $container['model/dependencies'] ]
73
+                'arguments'  => [$container['model/dependencies']]
74 74
             ]);
75 75
         };
76 76
 
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
          * @param Container $container A Pimple DI container instance.
79 79
          * @return ModelBuilder
80 80
          */
81
-        $container['model/builder'] = function (Container $container) {
81
+        $container['model/builder'] = function(Container $container) {
82 82
             return new ModelBuilder([
83 83
                 'factory'           => $container['model/factory'],
84 84
                 'metadata_loader'   => $container['metadata/loader'],
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
          * @param Container $container A Pimple DI container instance.
91 91
          * @return ModelLoaderBuilder
92 92
          */
93
-        $container['model/loader/builder'] = function (Container $container) {
93
+        $container['model/loader/builder'] = function(Container $container) {
94 94
             return new ModelLoaderBuilder([
95 95
                 'factory' => $container['model/factory'],
96 96
                 'cache'     => $container['cache']
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
          * @param Container $container A Pimple DI container instance.
112 112
          * @return ArrayAccess|\Traversable
113 113
          */
114
-        $container['model/collection'] = $container->factory(function (Container $container) {
114
+        $container['model/collection'] = $container->factory(function(Container $container) {
115 115
             return new $container['model/collection/class'];
116 116
         });
117 117
 
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
          * @param Container $container A Pimple DI container instance.
120 120
          * @return CollectionLoader
121 121
          */
122
-        $container['model/collection/loader'] = $container->factory(function (Container $container) {
122
+        $container['model/collection/loader'] = $container->factory(function(Container $container) {
123 123
             $factory = $container['model/collection/loader/factory'];
124 124
             return $factory->create($factory->defaultClass());
125 125
         });
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
          * @param Container $container A Pimple DI container instance.
129 129
          * @return FactoryInterface
130 130
          */
131
-        $container['model/collection/loader/factory'] = function (Container $container) {
131
+        $container['model/collection/loader/factory'] = function(Container $container) {
132 132
             return new Factory([
133 133
                 'default_class' => CollectionLoader::class,
134 134
                 'arguments'     => [[
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
              * @param Container $container A Pimple DI container instance.
153 153
              * @return array The model dependencies array.
154 154
              */
155
-            $container['model/dependencies'] = function (Container $container) {
155
+            $container['model/dependencies'] = function(Container $container) {
156 156
                 return [
157 157
                     'container'        => $container,
158 158
                     'logger'           => $container['logger'],
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
              * @param Container $container A Pimple DI container instance.
171 171
              * @return \Charcoal\Factory\FactoryInterface
172 172
              */
173
-            $container['property/factory'] = function (Container $container) {
173
+            $container['property/factory'] = function(Container $container) {
174 174
                 return new Factory([
175 175
                     'base_class'       => PropertyInterface::class,
176 176
                     'default_class'    => GenericProperty::class,
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
              * @param Container $container A Pimple DI container instance.
194 194
              * @return MetadataLoader
195 195
              */
196
-            $container['metadata/loader'] = function (Container $container) {
196
+            $container['metadata/loader'] = function(Container $container) {
197 197
                 return new MetadataLoader([
198 198
                     'logger'    => $container['logger'],
199 199
                     'cache'     => $container['cache'],
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
              * @param Container $container A Pimple DI container instance.
209 209
              * @return \Charcoal\Factory\FactoryInterface
210 210
              */
211
-            $container['source/factory'] = function (Container $container) {
211
+            $container['source/factory'] = function(Container $container) {
212 212
                 return new Factory([
213 213
                     'map' => [
214 214
                         'database' => DatabaseSource::class
Please login to merge, or discard this patch.
src/Charcoal/Source/ExpressionFieldTrait.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@
 block discarded – undo
175 175
             if ($property instanceof StorablePropertyInterface) {
176 176
                 return $property->fieldNames();
177 177
             } else {
178
-                return [ $property ];
178
+                return [$property];
179 179
             }
180 180
         }
181 181
 
Please login to merge, or discard this patch.
src/Charcoal/Source/AbstractExpression.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -258,7 +258,7 @@
 block discarded – undo
258 258
      */
259 259
     public function jsonSerialize()
260 260
     {
261
-        return array_udiff_assoc($this->data(), $this->defaultData(), [ $this, 'diffValues' ]);
261
+        return array_udiff_assoc($this->data(), $this->defaultData(), [$this, 'diffValues']);
262 262
     }
263 263
 
264 264
     /**
Please login to merge, or discard this patch.
src/Charcoal/Source/Order.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -179,7 +179,7 @@
 block discarded – undo
179 179
             ));
180 180
         }
181 181
 
182
-        if (in_array($mode, [ self::MODE_ASC, self::MODE_DESC ])) {
182
+        if (in_array($mode, [self::MODE_ASC, self::MODE_DESC])) {
183 183
             $this->setDirection($mode);
184 184
         }
185 185
 
Please login to merge, or discard this patch.
src/Charcoal/Loader/CollectionLoader.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
     {
142 142
         foreach ($data as $key => $val) {
143 143
             $setter = $this->setter($key);
144
-            if (is_callable([ $this, $setter ])) {
144
+            if (is_callable([$this, $setter])) {
145 145
                 $this->{$setter}($val);
146 146
             } else {
147 147
                 $this->{$key} = $val;
@@ -664,7 +664,7 @@  discard block
 block discarded – undo
664 664
      */
665 665
     protected function processCollection($results, callable $before = null, callable $after = null)
666 666
     {
667
-        $collection   = $this->createCollection();
667
+        $collection = $this->createCollection();
668 668
         foreach ($results as $objData) {
669 669
             $obj = $this->processModel($objData, $before, $after);
670 670
 
@@ -695,13 +695,13 @@  discard block
 block discarded – undo
695 695
         $obj = $this->factory()->create($objType);
696 696
 
697 697
         if ($before !== null) {
698
-            call_user_func_array($before, [ &$obj ]);
698
+            call_user_func_array($before, [&$obj]);
699 699
         }
700 700
 
701 701
         $obj->setFlatData($objData);
702 702
 
703 703
         if ($after !== null) {
704
-            call_user_func_array($after, [ &$obj ]);
704
+            call_user_func_array($after, [&$obj]);
705 705
         }
706 706
 
707 707
         return $obj;
Please login to merge, or discard this patch.
src/Charcoal/Source/FilterCollectionTrait.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
     protected function processFilter($filter)
89 89
     {
90 90
         if (!is_string($filter) && is_callable($filter)) {
91
-            $expr   = $this->createFilter();
91
+            $expr = $this->createFilter();
92 92
             /**
93 93
              * @param  FilterInterface           $expr The new filter expression object.
94 94
              * @param  FilterCollectionInterface $this The context of the collection.
Please login to merge, or discard this patch.