locomotivemtl / charcoal-attachment

src/Charcoal/Admin/Widget/AttachmentWidget.php

Doc Comments +1 added lines, -1 removed lines

@@ -215,7 +215,7 @@
     /**
      * Determine the number of attachments.
      *
-     * @return boolean
+     * @return integer
      */
     public function hasAttachments()
     {

Unused Use Statements -3 removed lines

@@ -2,7 +2,6 @@ 
 
 namespace Charcoal\Admin\Widget;
 
-use ArrayIterator;
 use RuntimeException;
 use InvalidArgumentException;
 
@@ -10,7 +9,6 @@ 
 use Pimple\Container;
 
 // From Mustache
-use Mustache_LambdaHelper as LambdaHelper;
 
 // From 'charcoal-config'
 use Charcoal\Config\ConfigurableInterface;
@@ -19,7 +17,6 @@ 
 use Charcoal\Factory\FactoryInterface;
 
 // From 'charcoal-core'
-use Charcoal\Loader\CollectionLoader;
 use Charcoal\Model\ModelInterface;
 
 // From 'charcoal-translator'

Spacing +3 added lines, -3 removed lines

@@ -210,7 +210,7 @@ 
         ]);
 
         foreach ($attachments as $attachment) {
-            $this->setDynamicTemplate('widget_template', (string)$attachment->rawPreview());
+            $this->setDynamicTemplate('widget_template', (string) $attachment->rawPreview());
 
             if (isset($attachableObjects[$attachment->objType()])) {
                 $attachment->attachmentType = $attachableObjects[$attachment->objType()];
@@ -474,7 +474,7 @@ 
             );
         }
 
-        $num = (int)$num;
+        $num = (int) $num;
 
         if ($num < 0) {
             throw new InvalidArgumentException(
@@ -502,7 +502,7 @@ 
             );
         }
 
-        $page = (int)$page;
+        $page = (int) $page;
 
         if ($page < 0) {
             throw new InvalidArgumentException(

src/Charcoal/Attachment/Object/File.php

Doc Comments +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
     /**
      * Alias of {@see Attachment::file()}.
      *
-     * @return string|null
+     * @return \Psr\Http\Message\UriInterface|null
      */
     public function src()
     {

src/Charcoal/Attachment/Object/Image.php

Doc Comments +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
     /**
      * Alias of {@see Attachment::thumbnail()} and {@see Attachment::file()}.
      *
-     * @return string|null
+     * @return \Psr\Http\Message\UriInterface|null
      */
     public function src()
     {

src/Charcoal/Attachment/Object/Join.php

Doc Comments +1 added lines, -1 removed lines

@@ -471,7 +471,7 @@
     /**
      * Retrieve the relationship's group ID.
      *
-     * @return mixed
+     * @return string
      */
     public function group()
     {

Spacing +1 added lines, -1 removed lines

@@ -402,7 +402,7 @@
             );
         }
 
-        $this->position = (int)$position;
+        $this->position = (int) $position;
 
         return $this;
     }

src/Charcoal/Attachment/Traits/AttachmentAwareTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -293,7 +293,7 @@
      * Set the attachment widget.
      *
      * @param  AttachmentWidget $widget The widget displaying attachments.
-     * @return string
+     * @return AttachmentAwareTrait
      */
     protected function setAttachmentWidget(AttachmentWidget $widget)
     {

Unused Use Statements -2 removed lines

@@ -13,8 +13,6 @@
 // From 'charcoal-attachment'
 use Charcoal\Attachment\Interfaces\AttachableInterface;
 use Charcoal\Attachment\Interfaces\AttachmentAwareInterface;
-use Charcoal\Attachment\Interfaces\AttachmentContainerInterface;
-
 use Charcoal\Attachment\Object\Join;
 use Charcoal\Attachment\Object\Attachment;
 

Spacing +7 added lines, -7 removed lines

@@ -80,7 +80,7 @@ 
                 $this->logger->warning(
                     'AttachmentAwareTrait::attachments() parameters are deprecated. '.
                     'An array of parameters should be used.',
-                    [ 'package' => 'locomotivemtl/charcoal-attachment' ]
+                    ['package' => 'locomotivemtl/charcoal-attachment']
                 );
             }
             $options = [
@@ -186,7 +186,7 @@ 
         $loader->setDynamicTypeField('type');
 
         if ($widget instanceof AttachmentWidget) {
-            $callable = function (&$att) use ($widget, $before) {
+            $callable = function(&$att) use ($widget, $before) {
                 if ($this instanceof AttachableInterface) {
                     $att->setContainerObj($this);
                 }
@@ -224,11 +224,11 @@ 
                 // }
 
                 if ($before !== null) {
-                    call_user_func_array($before, [ &$att ]);
+                    call_user_func_array($before, [&$att]);
                 }
             };
         } else {
-            $callable = function (&$att) use ($before) {
+            $callable = function(&$att) use ($before) {
                 if ($this instanceof AttachableInterface) {
                     $att->setContainerObj($this);
                 }
@@ -242,7 +242,7 @@ 
                 }
 
                 if ($before !== null) {
-                    call_user_func_array($before, [ &$att ]);
+                    call_user_func_array($before, [&$att]);
                 }
             };
         }
@@ -316,7 +316,7 @@ 
         $this->logger->warning(
             'AttachmentAwareTrait::removeJoins() is deprecated. '.
             'Use AttachmentAwareTrait::removeAttachmentJoins() instead.',
-            [ 'package' => 'locomotivemtl/charcoal-attachment' ]
+            ['package' => 'locomotivemtl/charcoal-attachment']
         );
 
         return $this->removeAttachmentJoins();
@@ -444,7 +444,7 @@ 
         $defaults = $this->getDefaultAttachmentOptions();
 
         $options = array_intersect_key($options, $defaults);
-        $options = array_filter($options, [ $this, 'filterAttachmentOption' ], ARRAY_FILTER_USE_BOTH);
+        $options = array_filter($options, [$this, 'filterAttachmentOption'], ARRAY_FILTER_USE_BOTH);
         $options = array_replace($defaults, $options);
 
         return $options;

src/Charcoal/Attachment/Traits/AttachmentRelationTrait.php

Spacing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
         $pivot = $this->modelFactory()->create(Join::class);
 
         if (is_string($data) && strpos($data, '_') > 1) {
-            $data = array_combine([ 'obj_type', 'obj_id' ], explode('_', $data, 1));
+            $data = array_combine(['obj_type', 'obj_id'], explode('_', $data, 1));
         }
 
         if (is_scalar($data)) {

src/Charcoal/Attachment/Script/CleanupScript.php

Spacing +6 added lines, -6 removed lines

@@ -256,7 +256,7 @@ 
                     ]);
                     $rows = $source->dbQuery(
                         strtr($sql, $binds),
-                        [ 'objType' => $row['object_type'] ]
+                        ['objType' => $row['object_type']]
                     );
 
                     /** @todo Show found rows, confirm deletion of dead relationships */
@@ -276,7 +276,7 @@ 
                     $sql  = 'SELECT p.* FROM `%pivotTable` AS p WHERE p.`%sourceType` = :objType;';
                     $rows = $source->dbQuery(
                         strtr($sql, $defaultBinds),
-                        [ 'objType' => $model ]
+                        ['objType' => $model]
                     );
 
                     /** @todo Explain missing model, confirm deletion of dead relationships */
@@ -394,7 +394,7 @@ 
                 ];
 
                 if ($ask && $verb) {
-                    $dead = array_merge([ 'Deleted' => null, 'Failed' => null ], $dead);
+                    $dead = array_merge(['Deleted' => null, 'Failed' => null], $dead);
                 }
             }
 
@@ -617,7 +617,7 @@ 
         $cli = $this->climate();
 
         if (is_string($this->action)) {
-            $opts = [ 'y', 'n', 'r', 'q', '?' ];
+            $opts = ['y', 'n', 'r', 'q', '?'];
             $help = [
                 '[y]es    — delete the attachment',
                 '[n]o     — don’t delete the attachment',
@@ -625,7 +625,7 @@ 
                 '[q]uit   — exit immediately (does not undo previous actions)',
             ];
         } else {
-            $opts = [ 'y', 'a', 'n', 's', 'q', '?' ];
+            $opts = ['y', 'a', 'n', 's', 'q', '?'];
             $help = [
                 '[y]es  — delete this attachment',
                 '[a]ll  — delete all attachments',
@@ -686,7 +686,7 @@ 
     {
         $cli = $this->climate();
 
-        $opts = [ 'y', 'n', 'v', '?' ];
+        $opts = ['y', 'n', 'v', '?'];
         $help = [
             '[y]es  — continue to deletion phase',
             '[n]o   — cancel deletion phase',

src/Charcoal/Admin/Action/JoinAction.php

Spacing +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
 
         $count = count($attachments);
         $i = 0;
-        for (; $i<$count; $i++) {
+        for (; $i < $count; $i++) {
             $attachmentId = $attachments[$i]['attachment_id'];
             $position = $attachments[$i]['position'];
 

src/Charcoal/Attachment/Object/Gallery.php

Spacing +1 added lines, -1 removed lines

@@ -50,6 +50,6 @@
      */
     public function columnWidth()
     {
-        return (string)ceil(12/$this->numColumns);
+        return (string) ceil(12 / $this->numColumns);
     }
 }