Image::renderImagesHelper() - Code Metrics - lochmueller/ink - Measure and Improve Code Quality continuously with Scrutinizer

Image::renderImagesHelper() D
last analyzed 2016-06-15 20:40 UTC

↳ Parent: Image

Complexity

Conditions	14
Paths	126

Size

Total Lines	44
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	44
rs	4.7877
cc	14
eloc	29
nc	126
nop	3

How to fix Complexity

<?php
/**
 * Rendering image elements
 *
 * @author Tim Lochmüller
 */

namespace FRUIT\Ink\Rendering;

use TYPO3\CMS\Core\Resource\File;
use TYPO3\CMS\Core\Resource\FileRepository;
use TYPO3\CMS\Extbase\Object\ObjectManager;

/**
 * Rendering image elements
 */
class Image extends AbstractRendering
{

    /**
     * Render the given element
     *
     * @return array
     */
    public function renderInternal()
    {
        $objectManager = new ObjectManager();
        /** @var FileRepository $fileRepository */
        $fileRepository = $objectManager->get('TYPO3\\CMS\\Core\\Resource\\FileRepository');
        $files = $fileRepository->findByRelation('tt_content', 'image', $this->contentObject->data['uid']);

        $images_arr = array();
        foreach ($files as $file) {
            /** @var $file File */
            $images_arr[] = $this->getLink($file->getPublicUrl());

        }

        $lines[] = $this->renderImagesHelper($images_arr, !$this->contentObject->data['image_zoom'] ? $this->contentObject->data['image_link'] : '', $this->contentObject->data['imagecaption']);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        return $lines;

    }

    /**
     * Render block of images - which means creating lines with links to the images.
     *
     * @param     array $images_arr : the image array
     * @param    string $links      : Link value from the "image_link" field in tt_content records
     * @param    string $caption    : Caption text
     *
     * @return    string        Content
     * @see getImages()
     */
    public function renderImagesHelper($images_arr, $links, $caption)
    {
        $linksArr = explode(',', $links);
        $lines = array();
        $imageExists = false;

        foreach ($images_arr as $k => $file) {
            if (strlen(trim($file)) > 0) {
                $lines[] = $file;
                if ($links && count($linksArr) > 1) {
                    if (isset($linksArr[$k])) {
                        $ll = $linksArr[$k];
                    } else {
                        $ll = $linksArr[0];
                    }

                    $theLink = $this->getLink($ll);
                    if ($theLink) {
                        $lines[] = $this->configuration['images.']['linkPrefix'] . $theLink;
                    }
                }
                $imageExists = true;
            }
        }
        if ($this->configuration['images.']['header'] && $imageExists) {
            array_unshift($lines, $this->configuration['images.']['header']);
        }
        if ($links && count($linksArr) == 1) {
            $theLink = $this->getLink($links);
            if ($theLink) {
                $lines[] = $this->configuration['images.']['linkPrefix'] . $theLink;
            }
        }
        if ($caption) {
            $lines[] = '';
            $cHeader = trim($this->configuration['images.']['captionHeader']);
            if ($cHeader) {
                $lines[] = $cHeader;
            }
            $lines[] = $this->breakContent($caption);
        }

        return chr(10) . implode(chr(10), $lines);
    }
}


1			<?php
2			/**
3			* Rendering image elements
4			*
5			* @author Tim Lochmüller
6			*/
7
8			namespace FRUIT\Ink\Rendering;
9
10			use TYPO3\CMS\Core\Resource\File;
11			use TYPO3\CMS\Core\Resource\FileRepository;
12			use TYPO3\CMS\Extbase\Object\ObjectManager;
13
14			/**
15			* Rendering image elements
16			*/
17			class Image extends AbstractRendering
18			{
19
20			/**
21			* Render the given element
22			*
23			* @return array
24			*/
25			public function renderInternal()
26			{
27			$objectManager = new ObjectManager();
28			/** @var FileRepository $fileRepository */
29			$fileRepository = $objectManager->get('TYPO3\\CMS\\Core\\Resource\\FileRepository');
30			$files = $fileRepository->findByRelation('tt_content', 'image', $this->contentObject->data['uid']);
31
32			$images_arr = array();
33			foreach ($files as $file) {
34			/** @var $file File */
35			$images_arr[] = $this->getLink($file->getPublicUrl());
			0 ignored issues – show Security Bug introduced 2016-06-15 18:30 UTC by Report Bug Copy Issue Report It seems like `$file->getPublicUrl()` targeting `TYPO3\CMS\Core\Resource\File::getPublicUrl()` can also be of type `false`; however, `FRUIT\Ink\Rendering\AbstractRendering::getLink()` does only seem to accept `string`, did you maybe forget to handle an error condition? Loading history...
36			}
37
38			$lines[] = $this->renderImagesHelper($images_arr, !$this->contentObject->data['image_zoom'] ? $this->contentObject->data['image_link'] : '', $this->contentObject->data['imagecaption']);
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-06-15 17:29 UTC by Report Bug Copy Issue Report `$lines` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$lines = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
39
40			return $lines;
41
42			}
43
44			/**
45			* Render block of images - which means creating lines with links to the images.
46			*
47			* @param array $images_arr : the image array
48			* @param string $links : Link value from the "image_link" field in tt_content records
49			* @param string $caption : Caption text
50			*
51			* @return string Content
52			* @see getImages()
53			*/
54			public function renderImagesHelper($images_arr, $links, $caption)
55			{
56			$linksArr = explode(',', $links);
57			$lines = array();
58			$imageExists = false;
59
60			foreach ($images_arr as $k => $file) {
61			if (strlen(trim($file)) > 0) {
62			$lines[] = $file;
63			if ($links && count($linksArr) > 1) {
64			if (isset($linksArr[$k])) {
65			$ll = $linksArr[$k];
66			} else {
67			$ll = $linksArr[0];
68			}
69
70			$theLink = $this->getLink($ll);
71			if ($theLink) {
72			$lines[] = $this->configuration['images.']['linkPrefix'] . $theLink;
73			}
74			}
75			$imageExists = true;
76			}
77			}
78			if ($this->configuration['images.']['header'] && $imageExists) {
79			array_unshift($lines, $this->configuration['images.']['header']);
80			}
81			if ($links && count($linksArr) == 1) {
82			$theLink = $this->getLink($links);
83			if ($theLink) {
84			$lines[] = $this->configuration['images.']['linkPrefix'] . $theLink;
85			}
86			}
87			if ($caption) {
88			$lines[] = '';
89			$cHeader = trim($this->configuration['images.']['captionHeader']);
90			if ($cHeader) {
91			$lines[] = $cHeader;
92			}
93			$lines[] = $this->breakContent($caption);
94			}
95
96			return chr(10) . implode(chr(10), $lines);
97			}
98			}
99

lochmueller / ink

Image::renderImagesHelper() D last analyzed 2016-06-15 20:40 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

Image::renderImagesHelper() D
last analyzed 2016-06-15 20:40 UTC