FRUIT\Ink\Rendering\Image

Complexity

Total Complexity

17

Size/Duplication

Total Lines	82
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	3
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	renderInternal()	0	18	3
D	renderImagesHelper()	0	44	14

<?php
/**
 * Rendering image elements
 *
 * @author Tim Lochmüller
 */

namespace FRUIT\Ink\Rendering;

use TYPO3\CMS\Core\Resource\File;
use TYPO3\CMS\Core\Resource\FileRepository;
use TYPO3\CMS\Extbase\Object\ObjectManager;

/**
 * Rendering image elements
 */
class Image extends AbstractRendering
{

    /**
     * Render the given element
     *
     * @return array
     */
    public function renderInternal()
    {
        $objectManager = new ObjectManager();
        /** @var FileRepository $fileRepository */
        $fileRepository = $objectManager->get('TYPO3\\CMS\\Core\\Resource\\FileRepository');
        $files = $fileRepository->findByRelation('tt_content', 'image', $this->contentObject->data['uid']);

        $images_arr = array();
        foreach ($files as $file) {
            /** @var $file File */
            $images_arr[] = $this->getLink($file->getPublicUrl());

It seems like $file->getPublicUrl() targeting TYPO3\CMS\Core\Resource\File::getPublicUrl() can also be of type false; however, FRUIT\Ink\Rendering\AbstractRendering::getLink() does only seem to accept string, did you maybe forget to handle an error condition?

        }

        $lines[] = $this->renderImagesHelper($images_arr, !$this->contentObject->data['image_zoom'] ? $this->contentObject->data['image_link'] : '', $this->contentObject->data['imagecaption']);

$lines was never initialized. Although not strictly required by PHP, it is generally a good practice to add $lines = array(); before regardless.

        return $lines;

    }

    /**
     * Render block of images - which means creating lines with links to the images.
     *
     * @param     array $images_arr : the image array
     * @param    string $links      : Link value from the "image_link" field in tt_content records
     * @param    string $caption    : Caption text
     *
     * @return    string        Content
     * @see getImages()
     */
    public function renderImagesHelper($images_arr, $links, $caption)
    {
        $linksArr = explode(',', $links);
        $lines = array();
        $imageExists = false;

        foreach ($images_arr as $k => $file) {
            if (strlen(trim($file)) > 0) {
                $lines[] = $file;
                if ($links && count($linksArr) > 1) {
                    if (isset($linksArr[$k])) {
                        $ll = $linksArr[$k];
                    } else {
                        $ll = $linksArr[0];
                    }

                    $theLink = $this->getLink($ll);
                    if ($theLink) {
                        $lines[] = $this->configuration['images.']['linkPrefix'] . $theLink;
                    }
                }
                $imageExists = true;
            }
        }
        if ($this->configuration['images.']['header'] && $imageExists) {
            array_unshift($lines, $this->configuration['images.']['header']);
        }
        if ($links && count($linksArr) == 1) {
            $theLink = $this->getLink($links);
            if ($theLink) {
                $lines[] = $this->configuration['images.']['linkPrefix'] . $theLink;
            }
        }
        if ($caption) {
            $lines[] = '';
            $cHeader = trim($this->configuration['images.']['captionHeader']);
            if ($cHeader) {
                $lines[] = $cHeader;
            }
            $lines[] = $this->breakContent($caption);
        }

        return chr(10) . implode(chr(10), $lines);
    }
}