ABlocksByDayControl::setBlockModel() - Code Metrics - Inspection of "Merge pull request #135 from literat/devel" - literat/srazvs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fea2cb...118c60 )

by Litera

created 2017-12-13 16:12 UTC

ABlocksByDayControl::setBlockModel() A

↳ Parent: ABlocksByDayControl

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php

namespace App\Components;

use App\Models\BlockModel;

abstract class ABlocksByDayControl extends BaseControl implements IBlocksByDayControl
{

	const TEMPLATE_NAME = '';

	/**
	 * @var ProgramsControl
	 */
	private $programsControl;

	/**
	 * @var BlockModel
	 */
	private $blockModel;

	/**
	 * @param  string $day
	 * @return void
	 */
	public function render($day)
	{
		$this->getBlockModel()->setMeetingId($this->getMeetingId());
		$blocks = $this->getBlockModel()->findByDay($day);

		$template = $this->getTemplate();
		$template->setFile($this->buildTemplatePath());
		$template->blocks = $blocks;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->render();
	}

	/**
	 * @return ProgramsControl
	 */
	protected function createComponentPrograms()
	{
		return $this->programsControl;
	}

	/**
	 * @param  IProgramsControl $control
	 * @return $this
	 */
	protected function setProgramsControl(IProgramsControl $control): IBlocksByDayControl
	{
		$this->programsControl = $control;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}

		return $this;
	}

	/**
	 * @return BlockModel
	 */
	protected function getBlockModel(): BlockModel
	{
		return  $this->blockModel;
	}

	/**
	 * @param  BlockModel $model
	 * @return $this
	 */
	protected function setBlockModel(BlockModel $model): IBlocksByDayControl
	{
		$this->blockModel = $model;

		return $this;
	}

}


1			<?php
2
3			namespace App\Components;
4
5			use App\Models\BlockModel;
6
7			abstract class ABlocksByDayControl extends BaseControl implements IBlocksByDayControl
8			{
9
10			const TEMPLATE_NAME = '';
11
12			/**
13			* @var ProgramsControl
14			*/
15			private $programsControl;
16
17			/**
18			* @var BlockModel
19			*/
20			private $blockModel;
21
22			/**
23			* @param string $day
24			* @return void
25			*/
26			public function render($day)
27			{
28			$this->getBlockModel()->setMeetingId($this->getMeetingId());
29			$blocks = $this->getBlockModel()->findByDay($day);
30
31			$template = $this->getTemplate();
32			$template->setFile($this->buildTemplatePath());
33			$template->blocks = $blocks;
			0 ignored issues – show Bug introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Accessing `blocks` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
34			$template->render();
35			}
36
37			/**
38			* @return ProgramsControl
39			*/
40			protected function createComponentPrograms()
41			{
42			return $this->programsControl;
43			}
44
45			/**
46			* @param IProgramsControl $control
47			* @return $this
48			*/
49			protected function setProgramsControl(IProgramsControl $control): IBlocksByDayControl
50			{
51			$this->programsControl = $control;
			0 ignored issues – show Documentation Bug introduced 2017-11-12 21:38 UTC by Report Bug Copy Issue Report `$control` is of type `object<App\Components\IProgramsControl>`, but the property `$programsControl` was declared to be of type `object<App\Components\ProgramsControl>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
52
53			return $this;
54			}
55
56			/**
57			* @return BlockModel
58			*/
59			protected function getBlockModel(): BlockModel
60			{
61			return $this->blockModel;
62			}
63
64			/**
65			* @param BlockModel $model
66			* @return $this
67			*/
68			protected function setBlockModel(BlockModel $model): IBlocksByDayControl
69			{
70			$this->blockModel = $model;
71
72			return $this;
73			}
74
75			}
76

literat / srazvs

Push — master ( fea2cb...118c60 )

ABlocksByDayControl::setBlockModel() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like