App\Components\ABlocksByDayControl

Complexity

Total Complexity

5

Size/Duplication

Total Lines	69
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	render()	0	10	1
A	createComponentPrograms()	0	4	1
A	setProgramsControl()	0	6	1
A	getBlockModel()	0	4	1
A	setBlockModel()	0	6	1

<?php

namespace App\Components;

use App\Models\BlockModel;

abstract class ABlocksByDayControl extends BaseControl implements IBlocksByDayControl
{

	const TEMPLATE_NAME = '';

	/**
	 * @var ProgramsControl
	 */
	private $programsControl;

	/**
	 * @var BlockModel
	 */
	private $blockModel;

	/**
	 * @param  string $day
	 * @return void
	 */
	public function render($day)
	{
		$this->getBlockModel()->setMeetingId($this->getMeetingId());
		$blocks = $this->getBlockModel()->findByDay($day);

		$template = $this->getTemplate();
		$template->setFile($this->buildTemplatePath());
		$template->blocks = $blocks;

Accessing blocks on the interface Nette\Application\UI\ITemplate suggest that you code against a concrete implementation. How about adding an instanceof check?

		$template->render();
	}

	/**
	 * @return ProgramsControl
	 */
	protected function createComponentPrograms()
	{
		return $this->programsControl;
	}

	/**
	 * @param  IProgramsControl $control
	 * @return $this
	 */
	protected function setProgramsControl(IProgramsControl $control): IBlocksByDayControl
	{
		$this->programsControl = $control;

$control is of type object<App\Components\IProgramsControl>, but the property $programsControl was declared to be of type object<App\Components\ProgramsControl>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

		return $this;
	}

	/**
	 * @return BlockModel
	 */
	protected function getBlockModel(): BlockModel
	{
		return  $this->blockModel;
	}

	/**
	 * @param  BlockModel $model
	 * @return $this
	 */
	protected function setBlockModel(BlockModel $model): IBlocksByDayControl
	{
		$this->blockModel = $model;

		return $this;
	}

}