View GitHub Repository writing-on-github

Schedule Inspection
Subscribe
Passed
Push — master ( 41d0ad...ef8508 )
by litefeel
03:50
created
Status
Category
Toggle Patches
lib/request.php 2 patches
Indentation   +144 added lines, -144 removed lines patch added patch discarded remove patch 
@@ -9,148 +9,148 @@
 
 block discarded – undo
9 9 
  */
10 10 
 class Writing_On_GitHub_Request {
11 11
12 
-    /**
13 
-     * Application container.
14 
-     *
15 
-     * @var Writing_On_GitHub
16 
-     */
17 
-    protected $app;
18 
-
19 
-    /**
20 
-     * Raw request data.
21 
-     *
22 
-     * @var string
23 
-     */
24 
-    protected $raw_data;
25 
-
26 
-    /**
27 
-     * Headers
28 
-     * @var array
29 
-     */
30 
-    protected $headers;
31 
-
32 
-    /**
33 
-     * Writing_On_GitHub_Request constructor.
34 
-     *
35 
-     * @param Writing_On_GitHub $app Application container.
36 
-     */
37 
-    public function __construct( Writing_On_GitHub $app ) {
38 
-        $this->app = $app;
39 
-    }
40 
-
41 
-    /**
42 
-     * Validates the header's secret.
43 
-     *
44 
-     * @return true|WP_Error
45 
-     */
46 
-    public function is_secret_valid() {
47 
-        $headers = $this->headers();
48 
-
49 
-        $this->raw_data = $this->read_raw_data();
50 
-
51 
-        // Validate request secret.
52 
-        $hash = hash_hmac( 'sha1', $this->raw_data, $this->secret() );
53 
-        if ( 'sha1=' . $hash !== $headers['X-Hub-Signature'] ) {
54 
-            return false;
55 
-        }
56 
-
57 
-        //      [X-Hub-Signature] => sha1=3cf3da70de401f7dfff053392f60cc534efed3b4
58 
-        //     [Content-Type] => application/json
59 
-        //     [X-Github-Delivery] => b2102500-0acf-11e7-8acb-fd86a3497c2f
60 
-        //     [X-Github-Event] => ping
61 
-
62 
-        return true;
63 
-    }
64 
-
65 
-    /**
66 
-     * Validates the ping event.
67 
-     * @return boolean
68 
-     */
69 
-    public function is_ping() {
70 
-        return 'ping' == $this->webhook_event();
71 
-    }
72 
-
73 
-    /**
74 
-     * Validates the push event.
75 
-     * @return boolean
76 
-     */
77 
-    public function is_push() {
78 
-        return 'push' == $this->webhook_event();
79 
-    }
80 
-
81 
-    /**
82 
-     * Return X-Github-Event in headers.
83 
-     * @return string
84 
-     */
85 
-    public function webhook_event() {
86 
-        $headers = $this->headers();
87 
-        return $headers['X-Github-Event'];
88 
-    }
89 
-
90 
-    /**
91 
-     * Returns a payload object for the given request.
92 
-     *
93 
-     * @return Writing_On_GitHub_Payload
94 
-     */
95 
-    public function payload() {
96 
-        return new Writing_On_GitHub_Payload( $this->app, $this->raw_data );
97 
-    }
98 
-
99 
-    /**
100 
-     * Cross-server header support.
101 
-     *
102 
-     * Returns an array of the request's headers.
103 
-     *
104 
-     * @return array
105 
-     */
106 
-    protected function headers() {
107 
-        if ( ! empty( $this->headers ) ) {
108 
-            return $this->headers;
109 
-        }
110 
-
111 
-        $this->headers = array();
112 
-        if ( function_exists( 'getallheaders' ) ) {
113 
-            $headers = getallheaders();
114 
-            // github webhook
115 
-            // content-type: application/json
116 
-            // Expect:
117 
-            // User-Agent: GitHub-Hookshot/7a71d82
118 
-            // X-GitHub-Delivery: a331b200-2537-11e8-9d7e-ce0853020b44
119 
-            // X-GitHub-Event: push
120 
-            // X-Hub-Signature: sha1=98185ffa2c4684c9a1324c57086709acca9dddc7
121 
-            foreach ( $headers as $name => $value ) {
122 
-                $this->headers[ str_replace( ' ', '-', ucwords( strtolower( str_replace( '-', ' ', $name ) ) ) ) ] = $value;
123 
-            }
124 
-        } else {
125 
-            /**
126 
-             * Nginx and pre 5.4 workaround.
127 
-             * @see http://www.php.net/manual/en/function.getallheaders.php
128 
-             */
129 
-            foreach ( $_SERVER as $name => $value ) {
130 
-                if ( 'HTTP_' === substr( $name, 0, 5 ) ) {
131 
-                    $this->headers[ str_replace( ' ', '-', ucwords( strtolower( str_replace( '_', ' ', substr( $name, 5 ) ) ) ) ) ] = $value;
132 
-                }
133 
-            }
134 
-        }
135 
-
136 
-        return $this->headers;
137 
-    }
138 
-
139 
-    /**
140 
-     * Reads the raw data from STDIN.
141 
-     *
142 
-     * @return string
143 
-     */
144 
-    protected function read_raw_data() {
145 
-        return file_get_contents( 'php://input' );
146 
-    }
147 
-
148 
-    /**
149 
-     * Returns the Webhook secret
150 
-     *
151 
-     * @return string
152 
-     */
153 
-    protected function secret() {
154 
-        return get_option( 'wogh_secret' );
155 
-    }
12 
+	/**
13 
+	 * Application container.
14 
+	 *
15 
+	 * @var Writing_On_GitHub
16 
+	 */
17 
+	protected $app;
18 
+
19 
+	/**
20 
+	 * Raw request data.
21 
+	 *
22 
+	 * @var string
23 
+	 */
24 
+	protected $raw_data;
25 
+
26 
+	/**
27 
+	 * Headers
28 
+	 * @var array
29 
+	 */
30 
+	protected $headers;
31 
+
32 
+	/**
33 
+	 * Writing_On_GitHub_Request constructor.
34 
+	 *
35 
+	 * @param Writing_On_GitHub $app Application container.
36 
+	 */
37 
+	public function __construct( Writing_On_GitHub $app ) {
38 
+		$this->app = $app;
39 
+	}
40 
+
41 
+	/**
42 
+	 * Validates the header's secret.
43 
+	 *
44 
+	 * @return true|WP_Error
45 
+	 */
46 
+	public function is_secret_valid() {
47 
+		$headers = $this->headers();
48 
+
49 
+		$this->raw_data = $this->read_raw_data();
50 
+
51 
+		// Validate request secret.
52 
+		$hash = hash_hmac( 'sha1', $this->raw_data, $this->secret() );
53 
+		if ( 'sha1=' . $hash !== $headers['X-Hub-Signature'] ) {
54 
+			return false;
55 
+		}
56 
+
57 
+		//      [X-Hub-Signature] => sha1=3cf3da70de401f7dfff053392f60cc534efed3b4
58 
+		//     [Content-Type] => application/json
59 
+		//     [X-Github-Delivery] => b2102500-0acf-11e7-8acb-fd86a3497c2f
60 
+		//     [X-Github-Event] => ping
61 
+
62 
+		return true;
63 
+	}
64 
+
65 
+	/**
66 
+	 * Validates the ping event.
67 
+	 * @return boolean
68 
+	 */
69 
+	public function is_ping() {
70 
+		return 'ping' == $this->webhook_event();
71 
+	}
72 
+
73 
+	/**
74 
+	 * Validates the push event.
75 
+	 * @return boolean
76 
+	 */
77 
+	public function is_push() {
78 
+		return 'push' == $this->webhook_event();
79 
+	}
80 
+
81 
+	/**
82 
+	 * Return X-Github-Event in headers.
83 
+	 * @return string
84 
+	 */
85 
+	public function webhook_event() {
86 
+		$headers = $this->headers();
87 
+		return $headers['X-Github-Event'];
88 
+	}
89 
+
90 
+	/**
91 
+	 * Returns a payload object for the given request.
92 
+	 *
93 
+	 * @return Writing_On_GitHub_Payload
94 
+	 */
95 
+	public function payload() {
96 
+		return new Writing_On_GitHub_Payload( $this->app, $this->raw_data );
97 
+	}
98 
+
99 
+	/**
100 
+	 * Cross-server header support.
101 
+	 *
102 
+	 * Returns an array of the request's headers.
103 
+	 *
104 
+	 * @return array
105 
+	 */
106 
+	protected function headers() {
107 
+		if ( ! empty( $this->headers ) ) {
108 
+			return $this->headers;
109 
+		}
110 
+
111 
+		$this->headers = array();
112 
+		if ( function_exists( 'getallheaders' ) ) {
113 
+			$headers = getallheaders();
114 
+			// github webhook
115 
+			// content-type: application/json
116 
+			// Expect:
117 
+			// User-Agent: GitHub-Hookshot/7a71d82
118 
+			// X-GitHub-Delivery: a331b200-2537-11e8-9d7e-ce0853020b44
119 
+			// X-GitHub-Event: push
120 
+			// X-Hub-Signature: sha1=98185ffa2c4684c9a1324c57086709acca9dddc7
121 
+			foreach ( $headers as $name => $value ) {
122 
+				$this->headers[ str_replace( ' ', '-', ucwords( strtolower( str_replace( '-', ' ', $name ) ) ) ) ] = $value;
123 
+			}
124 
+		} else {
125 
+			/**
126 
+			 * Nginx and pre 5.4 workaround.
127 
+			 * @see http://www.php.net/manual/en/function.getallheaders.php
128 
+			 */
129 
+			foreach ( $_SERVER as $name => $value ) {
130 
+				if ( 'HTTP_' === substr( $name, 0, 5 ) ) {
131 
+					$this->headers[ str_replace( ' ', '-', ucwords( strtolower( str_replace( '_', ' ', substr( $name, 5 ) ) ) ) ) ] = $value;
132 
+				}
133 
+			}
134 
+		}
135 
+
136 
+		return $this->headers;
137 
+	}
138 
+
139 
+	/**
140 
+	 * Reads the raw data from STDIN.
141 
+	 *
142 
+	 * @return string
143 
+	 */
144 
+	protected function read_raw_data() {
145 
+		return file_get_contents( 'php://input' );
146 
+	}
147 
+
148 
+	/**
149 
+	 * Returns the Webhook secret
150 
+	 *
151 
+	 * @return string
152 
+	 */
153 
+	protected function secret() {
154 
+		return get_option( 'wogh_secret' );
155 
+	}
156 156 
 }
Please login to merge, or discard this patch.
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch 
@@ -34,7 +34,7 @@  discard block
 
 block discarded – undo
34 34 
      *
35 35 
      * @param Writing_On_GitHub $app Application container.
36 36 
      */
37 
-    public function __construct( Writing_On_GitHub $app ) {
37 
+    public function __construct(Writing_On_GitHub $app) {
38 38 
         $this->app = $app;
39 39 
     }
40 40 
 
@@ -49,8 +49,8 @@  discard block
 
 block discarded – undo
49 49 
         $this->raw_data = $this->read_raw_data();
50 50
51 51 
         // Validate request secret.
52 
-        $hash = hash_hmac( 'sha1', $this->raw_data, $this->secret() );
53 
-        if ( 'sha1=' . $hash !== $headers['X-Hub-Signature'] ) {
52 
+        $hash = hash_hmac('sha1', $this->raw_data, $this->secret());
53 
+        if ('sha1=' . $hash !== $headers['X-Hub-Signature']) {
54 54 
             return false;
55 55 
         }
56 56 
 
@@ -93,7 +93,7 @@  discard block
 
 block discarded – undo
93 93 
      * @return Writing_On_GitHub_Payload
94 94 
      */
95 95 
     public function payload() {
96 
-        return new Writing_On_GitHub_Payload( $this->app, $this->raw_data );
96 
+        return new Writing_On_GitHub_Payload($this->app, $this->raw_data);
97 97 
     }
98 98
99 99 
     /**
 
@@ -104,12 +104,12 @@  discard block
 
 block discarded – undo
104 104 
      * @return array
105 105 
      */
106 106 
     protected function headers() {
107 
-        if ( ! empty( $this->headers ) ) {
107 
+        if ( ! empty($this->headers)) {
108 108 
             return $this->headers;
109 109 
         }
110 110
111 111 
         $this->headers = array();
112 
-        if ( function_exists( 'getallheaders' ) ) {
112 
+        if (function_exists('getallheaders')) {
113 113 
             $headers = getallheaders();
114 114 
             // github webhook
115 115 
             // content-type: application/json
 
@@ -118,17 +118,17 @@  discard block
 
 block discarded – undo
118 118 
             // X-GitHub-Delivery: a331b200-2537-11e8-9d7e-ce0853020b44
119 119 
             // X-GitHub-Event: push
120 120 
             // X-Hub-Signature: sha1=98185ffa2c4684c9a1324c57086709acca9dddc7
121 
-            foreach ( $headers as $name => $value ) {
122 
-                $this->headers[ str_replace( ' ', '-', ucwords( strtolower( str_replace( '-', ' ', $name ) ) ) ) ] = $value;
121 
+            foreach ($headers as $name => $value) {
122 
+                $this->headers[str_replace(' ', '-', ucwords(strtolower(str_replace('-', ' ', $name))))] = $value;
123 123 
             }
124 124 
         } else {
125 125 
             /**
126 126 
              * Nginx and pre 5.4 workaround.
127 127 
              * @see http://www.php.net/manual/en/function.getallheaders.php
128 128 
              */
129 
-            foreach ( $_SERVER as $name => $value ) {
130 
-                if ( 'HTTP_' === substr( $name, 0, 5 ) ) {
131 
-                    $this->headers[ str_replace( ' ', '-', ucwords( strtolower( str_replace( '_', ' ', substr( $name, 5 ) ) ) ) ) ] = $value;
129 
+            foreach ($_SERVER as $name => $value) {
130 
+                if ('HTTP_' === substr($name, 0, 5)) {
131 
+                    $this->headers[str_replace(' ', '-', ucwords(strtolower(str_replace('_', ' ', substr($name, 5)))))] = $value;
132 132 
                 }
133 133 
             }
134 134 
         }
 
@@ -142,7 +142,7 @@  discard block
 
 block discarded – undo
142 142 
      * @return string
143 143 
      */
144 144 
     protected function read_raw_data() {
145 
-        return file_get_contents( 'php://input' );
145 
+        return file_get_contents('php://input');
146 146 
     }
147 147
148 148 
     /**
 
@@ -151,6 +151,6 @@  discard block
 
 block discarded – undo
151 151 
      * @return string
152 152 
      */
153 153 
     protected function secret() {
154 
-        return get_option( 'wogh_secret' );
154 
+        return get_option('wogh_secret');
155 155 
     }
156 156 
 }
Please login to merge, or discard this patch.