View GitHub Repository writing-on-github

Schedule Inspection
Subscribe
Passed
Push — ci ( 8f93fa...dd2e2e )
by litefeel
03:09
created
Status
Category
Toggle Patches
lib/import.php 1 patch
Spacing   +78 added lines, -78 removed lines patch added patch discarded remove patch 
@@ -22,7 +22,7 @@  discard block
 
 block discarded – undo
22 22 
 	 *
23 23 
 	 * @param Writing_On_GitHub $app Application container.
24 24 
 	 */
25 
-	public function __construct( Writing_On_GitHub $app ) {
25 
+	public function __construct(Writing_On_GitHub $app) {
26 26 
 		$this->app = $app;
27 27 
 	}
28 28 
 
@@ -32,21 +32,21 @@  discard block
 
 block discarded – undo
32 32 
      *
33 33 
      * @return string|WP_Error
34 34 
      */
35 
-	public function payload( Writing_On_GitHub_Payload $payload ) {
35 
+	public function payload(Writing_On_GitHub_Payload $payload) {
36 36
37 
-		$result = $this->app->api()->fetch()->compare( $payload->get_before_commit_id() );
37 
+		$result = $this->app->api()->fetch()->compare($payload->get_before_commit_id());
38 38
39 
-		if ( is_wp_error( $result ) ) {
39 
+		if (is_wp_error($result)) {
40 40 
 			return $result;
41 41 
 		}
42 42
43 
-		$result = $this->import_files( $result );
43 
+		$result = $this->import_files($result);
44 44
45 
-		if ( is_wp_error( $result ) ) {
45 
+		if (is_wp_error($result)) {
46 46 
 			return $files;
47 47 
 		}
48 48
49 
-		return __( 'Payload processed', 'writing-on-github' );
49 
+		return __('Payload processed', 'writing-on-github');
50 50 
 	}
51 51
52 52 
 	/**
 
@@ -55,23 +55,23 @@  discard block
 
 block discarded – undo
55 55 
      *
56 56 
 	 * @return string|WP_Error
57 57 
 	 */
58 
-	protected function import_files( $files ) {
58 
+	protected function import_files($files) {
59 59
60 
-		$error 		= false;
60 
+		$error = false;
61 61 
 		$delete_ids = false;
62 62
63 
-		$result = $this->compare( $files, $delete_ids );
63 
+		$result = $this->compare($files, $delete_ids);
64 64
65 
-		if ( is_wp_error( $result ) ) {
65 
+		if (is_wp_error($result)) {
66 66 
 			return $result;
67 67 
 		}
68 68
69 
-		if ( $delete_ids ) {
69 
+		if ($delete_ids) {
70 70 
 			foreach ($delete_ids as $id) {
71 
-				$result = $this->app->database()->delete_post( $id );
72 
-				if ( is_wp_error( $result ) ) {
73 
-					if ( $error ) {
74 
-						$error->add( $result->get_error_code(), $result->get_error_message() );
71 
+				$result = $this->app->database()->delete_post($id);
72 
+				if (is_wp_error($result)) {
73 
+					if ($error) {
74 
+						$error->add($result->get_error_code(), $result->get_error_message());
75 75 
 					} else {
76 76 
 						$error = $result;
77 77 
 					}
 
@@ -90,17 +90,17 @@  discard block
 
 block discarded – undo
90 90 
 	public function master() {
91 91 
 		$result = $this->app->api()->fetch()->tree_recursive();
92 92
93 
-		if ( is_wp_error( $result ) ) {
93 
+		if (is_wp_error($result)) {
94 94 
 			return $result;
95 95 
 		}
96 96
97 
-		$result = $this->import_files( $result );
97 
+		$result = $this->import_files($result);
98 98
99 
-		if ( is_wp_error( $result ) ) {
99 
+		if (is_wp_error($result)) {
100 100 
 			return $result;
101 101 
 		}
102 102
103 
-		return __( 'Payload processed', 'writing-on-github' );
103 
+		return __('Payload processed', 'writing-on-github');
104 104 
 	}
105 105
106 106 
     /**
 
@@ -110,8 +110,8 @@  discard block
 
 block discarded – undo
110 110 
      *
111 111 
      * @return string|WP_Error
112 112 
      */
113 
-	protected function compare( $files, &$delete_ids ) {
114 
-		if ( is_wp_error( $files ) ) {
113 
+	protected function compare($files, &$delete_ids) {
114 
+		if (is_wp_error($files)) {
115 115 
 			return $files;
116 116 
 		}
117 117 
 
@@ -120,62 +120,62 @@  discard block
 
 block discarded – undo
120 120
121 121 
 		$idsmap = array();
122 122
123 
-		foreach ( $files as $file ) {
124 
-			if ( ! $this->importable_file( $file ) ) {
123 
+		foreach ($files as $file) {
124 
+			if ( ! $this->importable_file($file)) {
125 125 
 				continue;
126 126 
 			}
127 127
128 
-			$blob = $this->app->api()->fetch()->blob( $file );
128 
+			$blob = $this->app->api()->fetch()->blob($file);
129 129 
 			// network error ?
130 
-			if ( ! $blob instanceof Writing_On_GitHub_Blob ) {
130 
+			if ( ! $blob instanceof Writing_On_GitHub_Blob) {
131 131 
 				continue;
132 132 
 			}
133 133
134 
-			if ( $this->importable_raw_file( $blob ) ) {
135 
-				$this->import_raw_file( $blob, $file->status == 'removed' );
134 
+			if ($this->importable_raw_file($blob)) {
135 
+				$this->import_raw_file($blob, $file->status == 'removed');
136 136 
 				continue;
137 137 
 			}
138 138
139 
-			if ( ! $this->importable_blob( $blob ) ) {
139 
+			if ( ! $this->importable_blob($blob)) {
140 140 
 				continue;
141 141 
 			}
142 142
143 
-			$post = $this->blob_to_post( $blob );
143 
+			$post = $this->blob_to_post($blob);
144 144
145 
-			if ( $file->status == 'removed' ) {
146 
-				if ( $blob->id() ) {
145 
+			if ($file->status == 'removed') {
146 
+				if ($blob->id()) {
147 147 
 					$idsmap[$blob->id()] = true;
148 148 
 				}
149 
-			} elseif ( $post != false ) {
149 
+			} elseif ($post != false) {
150 150 
 				$posts[] = $post;
151 
-				if ( $post->is_new() ) {
151 
+				if ($post->is_new()) {
152 152 
 					$new[] = $post;
153 153 
 				}
154 154 
 			}
155 155 
 		}
156 156
157 
-		foreach ( $posts as $post ) {
158 
-			if ( $post->id() && isset( $idsmap[ $post->id() ] ) ) {
159 
-				unset( $idsmap[ $post->id() ] );
157 
+		foreach ($posts as $post) {
158 
+			if ($post->id() && isset($idsmap[$post->id()])) {
159 
+				unset($idsmap[$post->id()]);
160 160 
 			}
161 161 
 		}
162 162 
 		$delete_ids = array();
163 
-		foreach ( $idsmap as $id => $value ) {
163 
+		foreach ($idsmap as $id => $value) {
164 164 
 			$delete_ids[] = $id;
165 165 
 		}
166 166
167 167 
 		// $this->app->database()->save_posts( $posts, $commit->author_email() );
168 168
169 
-		$result = $this->app->database()->save_posts( $posts );
169 
+		$result = $this->app->database()->save_posts($posts);
170 170
171 
-		if ( is_wp_error( $result ) ) {
171 
+		if (is_wp_error($result)) {
172 172 
 			return $result;
173 173 
 		}
174 174
175 
-		if ( ! empty( $new ) ) {
176 
-			$result = $this->app->export()->new_posts( $new );
175 
+		if ( ! empty($new)) {
176 
+			$result = $this->app->export()->new_posts($new);
177 177
178 
-			if ( is_wp_error( $result ) ) {
178 
+			if (is_wp_error($result)) {
179 179 
 				return $result;
180 180 
 			}
181 181 
 		}
 
@@ -190,12 +190,12 @@  discard block
 
 block discarded – undo
190 190 
 	 *
191 191 
 	 * @return bool
192 192 
 	 */
193 
-	protected function importable_file( Writing_On_GitHub_File_Info $file ) {
193 
+	protected function importable_file(Writing_On_GitHub_File_Info $file) {
194 194
195 195 
 		// only _pages and _posts
196 
-		if ( strncasecmp($file->path, '_pages/', strlen('_pages/') ) != 0 &&
197 
-			 strncasecmp($file->path, '_posts/', strlen('_posts/') ) != 0 &&
198 
-			 strncasecmp($file->path, 'images/', strlen('images/') ) != 0 ) {
196 
+		if (strncasecmp($file->path, '_pages/', strlen('_pages/')) != 0 &&
197 
+			 strncasecmp($file->path, '_posts/', strlen('_posts/')) != 0 &&
198 
+			 strncasecmp($file->path, 'images/', strlen('images/')) != 0) {
199 199 
 			return false;
200 200 
 		}
201 201 
 
@@ -214,7 +214,7 @@  discard block
 
 block discarded – undo
214 214 
 	 *
215 215 
 	 * @return bool
216 216 
 	 */
217 
-	protected function importable_blob( Writing_On_GitHub_Blob $blob ) {
217 
+	protected function importable_blob(Writing_On_GitHub_Blob $blob) {
218 218 
 		// global $wpdb;
219 219
220 220 
 		// // Skip the repo's readme.
 
@@ -227,20 +227,20 @@  discard block
 
 block discarded – undo
227 227 
 		// 	return false;
228 228 
 		// }
229 229
230 
-		if ( ! $blob->has_frontmatter() ) {
230 
+		if ( ! $blob->has_frontmatter()) {
231 231 
 			return false;
232 232 
 		}
233 233
234 234 
 		return true;
235 235 
 	}
236 236
237 
-	protected function importable_raw_file( Writing_On_GitHub_Blob $blob ) {
238 
-		if ( $blob->has_frontmatter() ) {
237 
+	protected function importable_raw_file(Writing_On_GitHub_Blob $blob) {
238 
+		if ($blob->has_frontmatter()) {
239 239 
 			return false;
240 240 
 		}
241 241
242 242 
 		// only images
243 
-		if ( strncasecmp($blob->path(), 'images/', strlen('images/') ) != 0) {
243 
+		if (strncasecmp($blob->path(), 'images/', strlen('images/')) != 0) {
244 244 
 			return false;
245 245 
 		}
246 246 
 
@@ -252,16 +252,16 @@  discard block
 
 block discarded – undo
252 252 
 	 * @param  Writing_On_GitHub_Blob $blob
253 253 
 	 * @param  bool                   $is_remove
254 254 
 	 */
255 
-	protected function import_raw_file( Writing_On_GitHub_Blob $blob, $is_remove ) {
255 
+	protected function import_raw_file(Writing_On_GitHub_Blob $blob, $is_remove) {
256 256 
 		$arr = wp_upload_dir();
257 257 
 		$path = $arr['basedir'] . '/writing-on-github/' . $blob->path();
258 
-		if ( $is_remove ) {
259 
-			if ( file_exists($path) ) {
258 
+		if ($is_remove) {
259 
+			if (file_exists($path)) {
260 260 
 				unlink($path);
261 261 
 			}
262 262 
 		} else {
263 263 
 			$dirname = dirname($path);
264 
-			if ( ! file_exists($dirname) ) {
264 
+			if ( ! file_exists($dirname)) {
265 265 
 				wp_mkdir_p($dirname);
266 266 
 			}
267 267 
 
@@ -276,57 +276,57 @@  discard block
 
 block discarded – undo
276 276 
 	 *
277 277 
 	 * @return Writing_On_GitHub_Post|false
278 278 
 	 */
279 
-	protected function blob_to_post( Writing_On_GitHub_Blob $blob ) {
280 
-		$args = array( 'post_content' => $blob->content_import() );
279 
+	protected function blob_to_post(Writing_On_GitHub_Blob $blob) {
280 
+		$args = array('post_content' => $blob->content_import());
281 281 
 		$meta = $blob->meta();
282 282
283 283 
 		$id = false;
284 284
285 
-		if ( $meta ) {
286 
-			if ( array_key_exists( 'layout', $meta ) ) {
285 
+		if ($meta) {
286 
+			if (array_key_exists('layout', $meta)) {
287 287 
 				$args['post_type'] = $meta['layout'];
288 
-				unset( $meta['layout'] );
288 
+				unset($meta['layout']);
289 289 
 			}
290 290
291 
-			if ( array_key_exists( 'published', $meta ) ) {
291 
+			if (array_key_exists('published', $meta)) {
292 292 
 				$args['post_status'] = true === $meta['published'] ? 'publish' : 'draft';
293 
-				unset( $meta['published'] );
293 
+				unset($meta['published']);
294 294 
 			}
295 295
296 
-			if ( array_key_exists( 'post_title', $meta ) ) {
296 
+			if (array_key_exists('post_title', $meta)) {
297 297 
 				$args['post_title'] = $meta['post_title'];
298 
-				unset( $meta['post_title'] );
298 
+				unset($meta['post_title']);
299 299 
 			}
300 300
301 
-			if ( array_key_exists( 'post_name', $meta ) ) {
301 
+			if (array_key_exists('post_name', $meta)) {
302 302 
 				$args['post_name'] = $meta['post_name'];
303 
-				unset( $meta['post_name'] );
303 
+				unset($meta['post_name']);
304 304 
 			}
305 305
306 
-			if ( array_key_exists( 'ID', $meta ) ) {
306 
+			if (array_key_exists('ID', $meta)) {
307 307 
 				$id = $args['ID'] = $meta['ID'];
308 308 
 				$blob->set_id($id);
309 
-				unset( $meta['ID'] );
309 
+				unset($meta['ID']);
310 310 
 			}
311 311 
 		}
312 312
313 313 
 		$meta['_wogh_sha'] = $blob->sha();
314 314
315 
-		if ( $id ) {
316 
-			$old_sha = get_post_meta( $id, '_wogh_sha', true );
317 
-			$old_github_path = get_post_meta( $id, '_wogh_github_path', true );
315 
+		if ($id) {
316 
+			$old_sha = get_post_meta($id, '_wogh_sha', true);
317 
+			$old_github_path = get_post_meta($id, '_wogh_github_path', true);
318 318
319 319 
 			// dont save post when has same sha
320 
-			if ( $old_sha  && $old_sha == $meta['_wogh_sha'] &&
321 
-				 $old_github_path && $old_github_path == $blob->path() ) {
320 
+			if ($old_sha && $old_sha == $meta['_wogh_sha'] &&
321 
+				 $old_github_path && $old_github_path == $blob->path()) {
322 322 
 				return false;
323 323 
 			}
324 324 
 		}
325 325
326 
-		$post = new Writing_On_GitHub_Post( $args, $this->app->api() );
327 
-		$post->set_old_github_path( $blob->path() );
328 
-		$post->set_meta( $meta );
329 
-		$blob->set_id( $post->id() );
326 
+		$post = new Writing_On_GitHub_Post($args, $this->app->api());
327 
+		$post->set_old_github_path($blob->path());
328 
+		$post->set_meta($meta);
329 
+		$blob->set_id($post->id());
330 330
331 331 
 		return $post;
332 332 
 	}
Please login to merge, or discard this patch.