Completed
Push — develop ( e8233d...5c8fb2 )
by Neomerx
16:15 queued 11:26
created
src/Contracts/Models/PaginatedDataInterface.php 1 patch
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -1,20 +1,20 @@
 block discarded – undo
1 1
 <?php namespace Limoncello\Flute\Contracts\Models;
2 2
 
3 3
     /**
4
- * Copyright 2015-2017 [email protected]
5
- *
6
- * Licensed under the Apache License, Version 2.0 (the "License");
7
- * you may not use this file except in compliance with the License.
8
- * You may obtain a copy of the License at
9
- *
10
- * http://www.apache.org/licenses/LICENSE-2.0
11
- *
12
- * Unless required by applicable law or agreed to in writing, software
13
- * distributed under the License is distributed on an "AS IS" BASIS,
14
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
- * See the License for the specific language governing permissions and
16
- * limitations under the License.
17
- */
4
+     * Copyright 2015-2017 [email protected]
5
+     *
6
+     * Licensed under the Apache License, Version 2.0 (the "License");
7
+     * you may not use this file except in compliance with the License.
8
+     * You may obtain a copy of the License at
9
+     *
10
+     * http://www.apache.org/licenses/LICENSE-2.0
11
+     *
12
+     * Unless required by applicable law or agreed to in writing, software
13
+     * distributed under the License is distributed on an "AS IS" BASIS,
14
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
+     * See the License for the specific language governing permissions and
16
+     * limitations under the License.
17
+     */
18 18
 
19 19
 /**
20 20
  * @package Limoncello\Flute
Please login to merge, or discard this patch.
src/Contracts/Models/ModelStorageInterface.php 1 patch
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -1,20 +1,20 @@
 block discarded – undo
1 1
 <?php namespace Limoncello\Flute\Contracts\Models;
2 2
 
3 3
     /**
4
- * Copyright 2015-2017 [email protected]
5
- *
6
- * Licensed under the Apache License, Version 2.0 (the "License");
7
- * you may not use this file except in compliance with the License.
8
- * You may obtain a copy of the License at
9
- *
10
- * http://www.apache.org/licenses/LICENSE-2.0
11
- *
12
- * Unless required by applicable law or agreed to in writing, software
13
- * distributed under the License is distributed on an "AS IS" BASIS,
14
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
- * See the License for the specific language governing permissions and
16
- * limitations under the License.
17
- */
4
+     * Copyright 2015-2017 [email protected]
5
+     *
6
+     * Licensed under the Apache License, Version 2.0 (the "License");
7
+     * you may not use this file except in compliance with the License.
8
+     * You may obtain a copy of the License at
9
+     *
10
+     * http://www.apache.org/licenses/LICENSE-2.0
11
+     *
12
+     * Unless required by applicable law or agreed to in writing, software
13
+     * distributed under the License is distributed on an "AS IS" BASIS,
14
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
+     * See the License for the specific language governing permissions and
16
+     * limitations under the License.
17
+     */
18 18
 
19 19
 /**
20 20
  * @package Limoncello\Flute
Please login to merge, or discard this patch.
src/Contracts/Models/TagStorageInterface.php 1 patch
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -1,20 +1,20 @@
 block discarded – undo
1 1
 <?php namespace Limoncello\Flute\Contracts\Models;
2 2
 
3 3
     /**
4
- * Copyright 2015-2017 [email protected]
5
- *
6
- * Licensed under the Apache License, Version 2.0 (the "License");
7
- * you may not use this file except in compliance with the License.
8
- * You may obtain a copy of the License at
9
- *
10
- * http://www.apache.org/licenses/LICENSE-2.0
11
- *
12
- * Unless required by applicable law or agreed to in writing, software
13
- * distributed under the License is distributed on an "AS IS" BASIS,
14
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
- * See the License for the specific language governing permissions and
16
- * limitations under the License.
17
- */
4
+     * Copyright 2015-2017 [email protected]
5
+     *
6
+     * Licensed under the Apache License, Version 2.0 (the "License");
7
+     * you may not use this file except in compliance with the License.
8
+     * You may obtain a copy of the License at
9
+     *
10
+     * http://www.apache.org/licenses/LICENSE-2.0
11
+     *
12
+     * Unless required by applicable law or agreed to in writing, software
13
+     * distributed under the License is distributed on an "AS IS" BASIS,
14
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
+     * See the License for the specific language governing permissions and
16
+     * limitations under the License.
17
+     */
18 18
 
19 19
 /**
20 20
  * @package Limoncello\Flute
Please login to merge, or discard this patch.
src/Http/ThrowableHandlers/FluteThrowableHandler.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
             $details  = null;
100 100
             if ($this->isDebug === true) {
101 101
                 $message = $throwable->getMessage();
102
-                $details = (string)$throwable;
102
+                $details = (string) $throwable;
103 103
             }
104 104
             $errors->add(new Error(null, null, $httpCode, null, $message, $details));
105 105
         }
Please login to merge, or discard this patch.
src/Contracts/Http/Query/ParametersMapperInterface.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -52,17 +52,17 @@
 block discarded – undo
52 52
     public function withIncludes(iterable $includes): self;
53 53
 
54 54
     /**
55
-     * @return iterable
55
+     * @return \Generator
56 56
      */
57 57
     public function getMappedFilters(): iterable;
58 58
 
59 59
     /**
60
-     * @return iterable
60
+     * @return \Generator
61 61
      */
62 62
     public function getMappedSorts(): iterable;
63 63
 
64 64
     /**
65
-     * @return iterable
65
+     * @return \Generator
66 66
      */
67 67
     public function getMappedIncludes(): iterable;
68 68
 
Please login to merge, or discard this patch.
src/Adapters/ModelQueryBuilder.php 2 patches
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
     }
172 172
 
173 173
     /**
174
-     * @param iterable $attributes
174
+     * @param \Generator $attributes
175 175
      *
176 176
      * @return self
177 177
      *
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
     }
194 194
 
195 195
     /**
196
-     * @param iterable $attributes
196
+     * @param \Generator $attributes
197 197
      *
198 198
      * @return self
199 199
      *
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
      * @param string   $modelClass
217 217
      * @param iterable $attributes
218 218
      *
219
-     * @return iterable
219
+     * @return \Generator
220 220
      *
221 221
      * @SuppressWarnings(PHPMD.StaticAccess)
222 222
      *
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
     }
316 316
 
317 317
     /**
318
-     * @param iterable $filters
318
+     * @param \Limoncello\Flute\Api\iterable|null $filters
319 319
      *
320 320
      * @return self
321 321
      *
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
     }
332 332
 
333 333
     /**
334
-     * @param iterable $filters
334
+     * @param \Limoncello\Flute\Api\iterable|null $filters
335 335
      *
336 336
      * @return self
337 337
      *
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
     }
348 348
 
349 349
     /**
350
-     * @param iterable $filters
350
+     * @param \Limoncello\Flute\Api\iterable|null $filters
351 351
      *
352 352
      * @return self
353 353
      *
@@ -391,7 +391,7 @@  discard block
 block discarded – undo
391 391
 
392 392
     /**
393 393
      * @param string        $relationshipName
394
-     * @param iterable      $relationshipFilters
394
+     * @param \Limoncello\Flute\Api\iterable|null      $relationshipFilters
395 395
      * @param iterable|null $relationshipSorts
396 396
      *
397 397
      * @return self
@@ -417,7 +417,7 @@  discard block
 block discarded – undo
417 417
     }
418 418
 
419 419
     /**
420
-     * @param iterable $sortParameters
420
+     * @param \Limoncello\Flute\Api\iterable|null $sortParameters
421 421
      *
422 422
      * @return self
423 423
      */
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -639,7 +639,7 @@  discard block
 block discarded – undo
639 639
         string $targetColumn
640 640
     ): string {
641 641
         $targetAlias   = $this->createAlias($targetTable);
642
-        $joinCondition = $this->buildColumnName($fromAlias, $fromColumn) . '=' .
642
+        $joinCondition = $this->buildColumnName($fromAlias, $fromColumn).'='.
643 643
             $this->buildColumnName($targetAlias, $targetColumn);
644 644
 
645 645
         $this->innerJoin(
@@ -685,7 +685,7 @@  discard block
 block discarded – undo
685 685
      */
686 686
     private function createAlias(string $tableName): string
687 687
     {
688
-        $alias                          = $tableName . (++$this->aliasIdCounter);
688
+        $alias                          = $tableName.(++$this->aliasIdCounter);
689 689
         $this->knownAliases[$tableName] = $alias;
690 690
 
691 691
         return $alias;
@@ -850,7 +850,7 @@  discard block
 block discarded – undo
850 850
         } else {
851 851
             assert(
852 852
                 $value !== null,
853
-                'It seems you are trying to use `null` with =, >, <, or etc operator. ' .
853
+                'It seems you are trying to use `null` with =, >, <, or etc operator. '.
854 854
                 'Use `is null` or `not null` instead.'
855 855
             );
856 856
             assert(is_string($value), "Only strings, booleans and integers are supported.");
Please login to merge, or discard this patch.
src/Api/Crud.php 2 patches
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -756,9 +756,9 @@  discard block
 block discarded – undo
756 756
     }
757 757
 
758 758
     /**
759
-     * @param iterable $paths (string[])
759
+     * @param iterable|null $paths (string[])
760 760
      *
761
-     * @return iterable
761
+     * @return Generator
762 762
      */
763 763
     private static function getPaths(iterable $paths): iterable
764 764
     {
@@ -1399,7 +1399,7 @@  discard block
 block discarded – undo
1399 1399
      * @param string       $modelClass
1400 1400
      * @param string       $keyColumnName
1401 1401
      *
1402
-     * @return iterable
1402
+     * @return Generator
1403 1403
      *
1404 1404
      * @throws DBALException
1405 1405
      *
@@ -1503,7 +1503,7 @@  discard block
 block discarded – undo
1503 1503
      * @param null|string $index
1504 1504
      * @param iterable    $attributes
1505 1505
      *
1506
-     * @return iterable
1506
+     * @return Generator
1507 1507
      */
1508 1508
     protected function filterAttributesOnCreate(?string $index, iterable $attributes): iterable
1509 1509
     {
@@ -1523,7 +1523,7 @@  discard block
 block discarded – undo
1523 1523
     /**
1524 1524
      * @param iterable $attributes
1525 1525
      *
1526
-     * @return iterable
1526
+     * @return Generator
1527 1527
      */
1528 1528
     protected function filterAttributesOnUpdate(iterable $attributes): iterable
1529 1529
     {
@@ -1722,10 +1722,10 @@  discard block
 block discarded – undo
1722 1722
 
1723 1723
     /**
1724 1724
      * @param iterable         $attributes
1725
-     * @param array            $typeNames
1725
+     * @param Type[]            $typeNames
1726 1726
      * @param AbstractPlatform $platform
1727 1727
      *
1728
-     * @return iterable
1728
+     * @return Generator
1729 1729
      *
1730 1730
      * @throws DBALException
1731 1731
      */
Please login to merge, or discard this patch.
Spacing   +19 added lines, -20 removed lines patch added patch discarded remove patch
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
      */
208 208
     public function withIndexesFilter(array $indexes): CrudInterface
209 209
     {
210
-        assert(call_user_func(function () use ($indexes) {
210
+        assert(call_user_func(function() use ($indexes) {
211 211
             $allOk = true;
212 212
 
213 213
             foreach ($indexes as $index) {
@@ -729,7 +729,7 @@  discard block
 block discarded – undo
729 729
             $classAtPath = new ArrayObject();
730 730
             $idsAtPath   = new ArrayObject();
731 731
 
732
-            $registerModelAtRoot = function ($model) use ($modelStorage, $modelsAtPath, $idsAtPath): void {
732
+            $registerModelAtRoot = function($model) use ($modelStorage, $modelsAtPath, $idsAtPath): void {
733 733
                 self::registerModelAtPath(
734 734
                     $model,
735 735
                     static::ROOT_PATH,
@@ -817,7 +817,7 @@  discard block
 block discarded – undo
817 817
                 assert(is_string($pathPiece));
818 818
                 $parent                    = $tmpPath;
819 819
                 $tmpPath                   = empty($tmpPath) === true ?
820
-                    $pathPiece : $tmpPath . static::PATH_SEPARATOR . $pathPiece;
820
+                    $pathPiece : $tmpPath.static::PATH_SEPARATOR.$pathPiece;
821 821
                 $normalizedPaths[$tmpPath] = [$parent, $pathPiece];
822 822
                 $pathsDepths[$parent]      = $parentDepth++;
823 823
             }
@@ -974,7 +974,7 @@  discard block
 block discarded – undo
974 974
     ): ModelQueryBuilder {
975 975
         assert(
976 976
             $this->getModelSchemas()->hasRelationship($this->getModelClass(), $relationshipName),
977
-            "Relationship `$relationshipName` do not exist in model `" . $this->getModelClass() . '`'
977
+            "Relationship `$relationshipName` do not exist in model `".$this->getModelClass().'`'
978 978
         );
979 979
 
980 980
         // as we read data from a relationship our main table and model would be the table/model in the relationship
@@ -993,8 +993,7 @@  discard block
 block discarded – undo
993 993
             $filters = $this->getFilters();
994 994
             $sorts   = $this->getSorts();
995 995
             $this->areFiltersWithAnd() ?
996
-                $builder->addRelationshipFiltersAndSortsWithAnd($reverseRelName, $filters, $sorts) :
997
-                $builder->addRelationshipFiltersAndSortsWithOr($reverseRelName, $filters, $sorts);
996
+                $builder->addRelationshipFiltersAndSortsWithAnd($reverseRelName, $filters, $sorts) : $builder->addRelationshipFiltersAndSortsWithOr($reverseRelName, $filters, $sorts);
998 997
         }
999 998
         // ... and the input filters to actual data we select
1000 999
         if ($relationshipFilters !== null) {
@@ -1022,7 +1021,7 @@  discard block
 block discarded – undo
1022 1021
     ) {
1023 1022
         assert(
1024 1023
             $this->getModelSchemas()->hasRelationship($this->getModelClass(), $name),
1025
-            "Relationship `$name` do not exist in model `" . $this->getModelClass() . '`'
1024
+            "Relationship `$name` do not exist in model `".$this->getModelClass().'`'
1026 1025
         );
1027 1026
 
1028 1027
         // depending on the relationship type we expect the result to be either single resource or a collection
@@ -1049,7 +1048,7 @@  discard block
 block discarded – undo
1049 1048
     ): array {
1050 1049
         assert(
1051 1050
             $this->getModelSchemas()->hasRelationship($this->getModelClass(), $name),
1052
-            "Relationship `$name` do not exist in model `" . $this->getModelClass() . '`'
1051
+            "Relationship `$name` do not exist in model `".$this->getModelClass().'`'
1053 1052
         );
1054 1053
 
1055 1054
         // depending on the relationship type we expect the result to be either single resource or a collection
@@ -1123,7 +1122,7 @@  discard block
 block discarded – undo
1123 1122
 
1124 1123
         $this->clearFetchParameters();
1125 1124
 
1126
-        return (int)$deleted;
1125
+        return (int) $deleted;
1127 1126
     }
1128 1127
 
1129 1128
     /**
@@ -1137,7 +1136,7 @@  discard block
 block discarded – undo
1137 1136
 
1138 1137
         $this->clearFetchParameters();
1139 1138
 
1140
-        return (int)$deleted > 0;
1139
+        return (int) $deleted > 0;
1141 1140
     }
1142 1141
 
1143 1142
     /**
@@ -1158,7 +1157,7 @@  discard block
 block discarded – undo
1158 1157
 
1159 1158
         $this->clearBuilderParameters()->clearFetchParameters();
1160 1159
 
1161
-        $this->inTransaction(function () use ($saveMain, $toMany, &$index) {
1160
+        $this->inTransaction(function() use ($saveMain, $toMany, &$index) {
1162 1161
             $saveMain->execute();
1163 1162
 
1164 1163
             // if no index given will use last insert ID as index
@@ -1174,7 +1173,7 @@  discard block
 block discarded – undo
1174 1173
                         ->prepareCreateInToManyRelationship($relationshipName, $index, $secondaryIdBindName)
1175 1174
                 );
1176 1175
                 foreach ($secondaryIds as $secondaryId) {
1177
-                    $inserted += (int)$saveToMany->setParameter($secondaryIdBindName, $secondaryId)->execute();
1176
+                    $inserted += (int) $saveToMany->setParameter($secondaryIdBindName, $secondaryId)->execute();
1178 1177
                 }
1179 1178
             }
1180 1179
         });
@@ -1203,12 +1202,12 @@  discard block
 block discarded – undo
1203 1202
             ->createBuilder($this->getModelClass())
1204 1203
             ->updateModels($allowedChanges)
1205 1204
             ->addFiltersWithAndToTable($filters);
1206
-        $saveMain       = $this->builderSaveResourceOnUpdate($saveMain);
1205
+        $saveMain = $this->builderSaveResourceOnUpdate($saveMain);
1207 1206
         $saveMain->getSQL(); // prepare
1208 1207
 
1209 1208
         $this->clearBuilderParameters()->clearFetchParameters();
1210 1209
 
1211
-        $this->inTransaction(function () use ($saveMain, $toMany, $index, &$updated) {
1210
+        $this->inTransaction(function() use ($saveMain, $toMany, $index, &$updated) {
1212 1211
             $updated = $saveMain->execute();
1213 1212
 
1214 1213
             foreach ($toMany as $relationshipName => $secondaryIds) {
@@ -1228,12 +1227,12 @@  discard block
 block discarded – undo
1228 1227
                         ->prepareCreateInToManyRelationship($relationshipName, $index, $secondaryIdBindName)
1229 1228
                 );
1230 1229
                 foreach ($secondaryIds as $secondaryId) {
1231
-                    $updated += (int)$saveToMany->setParameter($secondaryIdBindName, $secondaryId)->execute();
1230
+                    $updated += (int) $saveToMany->setParameter($secondaryIdBindName, $secondaryId)->execute();
1232 1231
                 }
1233 1232
             }
1234 1233
         });
1235 1234
 
1236
-        return (int)$updated;
1235
+        return (int) $updated;
1237 1236
     }
1238 1237
 
1239 1238
     /**
@@ -1384,7 +1383,7 @@  discard block
 block discarded – undo
1384 1383
     {
1385 1384
         $countBuilder = $this->createBuilder($this->getModelClass());
1386 1385
         $countBuilder->setParameters($builder->getParameters());
1387
-        $countBuilder->select('COUNT(*)')->from('(' . $builder->getSQL() . ') AS RESULT');
1386
+        $countBuilder->select('COUNT(*)')->from('('.$builder->getSQL().') AS RESULT');
1388 1387
 
1389 1388
         return $countBuilder;
1390 1389
     }
@@ -1595,7 +1594,7 @@  discard block
 block discarded – undo
1595 1594
 
1596 1595
         $pkName = $this->getModelSchemas()->getPrimaryKey($parentClass);
1597 1596
 
1598
-        $registerModelAtPath = function ($model, string $path) use ($deDup, $modelsAtPath, $idsAtPath) {
1597
+        $registerModelAtPath = function($model, string $path) use ($deDup, $modelsAtPath, $idsAtPath) {
1599 1598
             return self::registerModelAtPath(
1600 1599
                 $model,
1601 1600
                 $path,
@@ -1607,7 +1606,7 @@  discard block
 block discarded – undo
1607 1606
         };
1608 1607
 
1609 1608
         foreach ($childRelationships as $name) {
1610
-            $childrenPath = $parentsPath !== static::ROOT_PATH ? $parentsPath . static::PATH_SEPARATOR . $name : $name;
1609
+            $childrenPath = $parentsPath !== static::ROOT_PATH ? $parentsPath.static::PATH_SEPARATOR.$name : $name;
1611 1610
 
1612 1611
             $relationshipType = $this->getModelSchemas()->getRelationshipType($parentClass, $name);
1613 1612
             list ($targetModelClass, $reverseRelName) =
@@ -1657,7 +1656,7 @@  discard block
 block discarded – undo
1657 1656
                             [$pkName => [FilterParameterInterface::OPERATION_EQUALS => [$parent->{$pkName}]]],
1658 1657
                             []
1659 1658
                         );
1660
-                        $children      = $this->fetchPaginatedResourcesWithoutRelationships(
1659
+                        $children = $this->fetchPaginatedResourcesWithoutRelationships(
1661 1660
                             $clonedBuilder,
1662 1661
                             $clonedBuilder->getModelClass()
1663 1662
                         );
Please login to merge, or discard this patch.
src/Http/Query/ParametersMapper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -409,7 +409,7 @@
 block discarded – undo
409 409
      * @param string   $parameterName
410 410
      * @param iterable $value
411 411
      *
412
-     * @return iterable
412
+     * @return Generator
413 413
      *
414 414
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
415 415
      */
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
     public function getMappedIncludes(): iterable
247 247
     {
248 248
         $fromSchema        = $this->getRootSchema();
249
-        $getMappedRelLinks = function (iterable $links) use ($fromSchema) : iterable {
249
+        $getMappedRelLinks = function(iterable $links) use ($fromSchema) : iterable {
250 250
             foreach ($links as $link) {
251 251
                 assert(is_string($link));
252 252
                 $fromSchemaClass = get_class($fromSchema);
@@ -296,14 +296,14 @@  discard block
 block discarded – undo
296 296
         //     ['rel2_name1', ],
297 297
         //     ['rel3_name1', 'rel3_name2', 'rel3_name3', ],
298 298
         // ]
299
-        $includeAsModelNames = function (iterable $relationships): iterable {
299
+        $includeAsModelNames = function(iterable $relationships): iterable {
300 300
             foreach ($relationships as $relationship) {
301 301
                 assert($relationship instanceof RelationshipInterface);
302 302
                 yield $relationship->getNameInModel();
303 303
             }
304 304
         };
305 305
         $mappedIncludes      = $this->getMappedIncludes();
306
-        $getIncludes         = function () use ($mappedIncludes, $includeAsModelNames) : iterable {
306
+        $getIncludes         = function() use ($mappedIncludes, $includeAsModelNames) : iterable {
307 307
             foreach ($mappedIncludes as $relationships) {
308 308
                 yield $includeAsModelNames($relationships);
309 309
             }
Please login to merge, or discard this patch.
src/Contracts/Api/CrudInterface.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
     public function fetchResources(QueryBuilder $builder, string $modelClass): PaginatedDataInterface;
109 109
 
110 110
     /**
111
-     * @param QueryBuilder|null $builder
111
+     * @param QueryBuilder $builder
112 112
      * @param string|null       $modelClass
113 113
      *
114 114
      * @return mixed|null
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
      * @param string       $modelClass
129 129
      * @param string       $columnName
130 130
      *
131
-     * @return iterable
131
+     * @return \Generator
132 132
      */
133 133
     public function fetchColumn(QueryBuilder $builder, string $modelClass, string $columnName): iterable;
134 134
 
@@ -226,9 +226,9 @@  discard block
 block discarded – undo
226 226
     );
227 227
 
228 228
     /**
229
-     * @param int|string $parentId
229
+     * @param string $parentId
230 230
      * @param string     $name
231
-     * @param int|string $childId
231
+     * @param string $childId
232 232
      *
233 233
      * @return bool
234 234
      */
Please login to merge, or discard this patch.