Completed
Push — master ( 1a67d2...dfab50 )
by Neomerx
11:35 queued 22s
created
src/Contracts/Api/CrudInterface.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
     public function fetchResources(QueryBuilder $builder, string $modelClass): PaginatedDataInterface;
109 109
 
110 110
     /**
111
-     * @param QueryBuilder|null $builder
111
+     * @param QueryBuilder $builder
112 112
      * @param string|null       $modelClass
113 113
      *
114 114
      * @return mixed|null
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
      * @param string       $modelClass
129 129
      * @param string       $columnName
130 130
      *
131
-     * @return iterable
131
+     * @return \Generator
132 132
      */
133 133
     public function fetchColumn(QueryBuilder $builder, string $modelClass, string $columnName): iterable;
134 134
 
@@ -226,9 +226,9 @@  discard block
 block discarded – undo
226 226
     );
227 227
 
228 228
     /**
229
-     * @param int|string $parentId
229
+     * @param string $parentId
230 230
      * @param string     $name
231
-     * @param int|string $childId
231
+     * @param string $childId
232 232
      *
233 233
      * @return bool
234 234
      */
Please login to merge, or discard this patch.
src/Contracts/Validation/JsonApiQueryRulesSerializerInterface.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
      *
169 169
      * @param array $ruleIndexes
170 170
      *
171
-     * @return array
171
+     * @return integer[]
172 172
      */
173 173
     public static function readRuleStartIndexes(array $ruleIndexes): array;
174 174
 
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
      *
178 178
      * @param array $ruleIndexes
179 179
      *
180
-     * @return array
180
+     * @return integer[]
181 181
      */
182 182
     public static function readRuleEndIndexes(array $ruleIndexes): array;
183 183
 }
Please login to merge, or discard this patch.
src/Encoder/Encoder.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 
126 126
         parse_str($this->getOriginalUri()->getQuery(), $queryParams);
127 127
 
128
-        return function ($offset) use ($pageSize, $queryParams) {
128
+        return function($offset) use ($pageSize, $queryParams) {
129 129
             $paramsWithPaging = array_merge($queryParams, [
130 130
                 BaseQueryParserInterface::PARAM_PAGE => [
131 131
                     JsonApiQueryValidatingParserInterface::PARAM_PAGING_OFFSET => $offset,
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
                 ],
134 134
             ]);
135 135
             $newUri           = $this->getOriginalUri()->withQuery(http_build_query($paramsWithPaging));
136
-            $fullUrl          = (string)$newUri;
136
+            $fullUrl          = (string) $newUri;
137 137
             $link             = $this->getFactory()->createLink($fullUrl, null, true);
138 138
 
139 139
             return $link;
Please login to merge, or discard this patch.
src/Validation/JsonApi/QueryParser.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
     ) {
156 156
         assert(
157 157
             in_array(JsonApiQueryRulesSerializerInterface::class, class_implements($serializerClass)),
158
-            "`$serializerClass` should implement interface `" . JsonApiQueryRulesSerializerInterface::class . '`.'
158
+            "`$serializerClass` should implement interface `".JsonApiQueryRulesSerializerInterface::class.'`.'
159 159
         );
160 160
 
161 161
         $parameters = [];
@@ -571,7 +571,7 @@  discard block
 block discarded – undo
571 571
     {
572 572
         // no validation rule means we should accept any input value
573 573
         if ($ruleIndexes === null) {
574
-            return is_numeric($value) === true ? (int)$value : 0;
574
+            return is_numeric($value) === true ? (int) $value : 0;
575 575
         }
576 576
 
577 577
         $ruleIndex = $this->serializerClass::readRuleMainIndex($ruleIndexes);
@@ -582,7 +582,7 @@  discard block
 block discarded – undo
582 582
 
583 583
         $validatedValue = $this->readSingleCapturedValue();
584 584
 
585
-        return (int)$validatedValue;
585
+        return (int) $validatedValue;
586 586
     }
587 587
 
588 588
     /**
Please login to merge, or discard this patch.
Doc Comments   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -448,7 +448,7 @@  discard block
 block discarded – undo
448 448
     }
449 449
 
450 450
     /**
451
-     * @return iterable
451
+     * @return Generator
452 452
      *
453 453
      * @SuppressWarnings(PHPMD.ElseExpression)
454 454
      */
@@ -495,7 +495,7 @@  discard block
 block discarded – undo
495 495
     /**
496 496
      * @param iterable $fieldsFromParent
497 497
      *
498
-     * @return iterable
498
+     * @return Generator
499 499
      *
500 500
      * @SuppressWarnings(PHPMD.StaticAccess)
501 501
      * @SuppressWarnings(PHPMD.ElseExpression)
@@ -530,7 +530,7 @@  discard block
 block discarded – undo
530 530
     /**
531 531
      * @param iterable $sortsFromParent
532 532
      *
533
-     * @return iterable
533
+     * @return Generator
534 534
      *
535 535
      * @SuppressWarnings(PHPMD.StaticAccess)
536 536
      * @SuppressWarnings(PHPMD.ElseExpression)
@@ -562,7 +562,7 @@  discard block
 block discarded – undo
562 562
     /**
563 563
      * @param iterable $includesFromParent
564 564
      *
565
-     * @return iterable
565
+     * @return Generator
566 566
      *
567 567
      * @SuppressWarnings(PHPMD.StaticAccess)
568 568
      * @SuppressWarnings(PHPMD.ElseExpression)
@@ -592,7 +592,7 @@  discard block
 block discarded – undo
592 592
     }
593 593
 
594 594
     /**
595
-     * @param iterable $iterable
595
+     * @param Generator $iterable
596 596
      *
597 597
      * @return array
598 598
      */
@@ -755,7 +755,7 @@  discard block
 block discarded – undo
755 755
      * @param int      $ruleIndex
756 756
      * @param iterable $values
757 757
      *
758
-     * @return iterable
758
+     * @return Generator
759 759
      */
760 760
     private function validateValues(int $ruleIndex, iterable $values): iterable
761 761
     {
@@ -770,9 +770,9 @@  discard block
 block discarded – undo
770 770
 
771 771
     /**
772 772
      * @param int      $ruleIndex
773
-     * @param iterable $opsAndArgs
773
+     * @param Generator $opsAndArgs
774 774
      *
775
-     * @return iterable
775
+     * @return Generator
776 776
      */
777 777
     private function validateFilterArguments(int $ruleIndex, iterable $opsAndArgs): iterable
778 778
     {
@@ -936,7 +936,7 @@  discard block
 block discarded – undo
936 936
      * @param string $parameterName
937 937
      * @param array  $value
938 938
      *
939
-     * @return iterable
939
+     * @return Generator
940 940
      *
941 941
      * @SuppressWarnings(PHPMD.ElseExpression)
942 942
      */
Please login to merge, or discard this patch.
src/Schema/Schema.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -212,12 +212,12 @@
 block discarded – undo
212 212
             return [static::DATA => $data->getData()];
213 213
         }
214 214
 
215
-        $buildUrl = function ($offset) use ($data, $uri) {
215
+        $buildUrl = function($offset) use ($data, $uri) {
216 216
             $paramsWithPaging = [
217 217
                 JsonApiQueryValidatingParserInterface::PARAM_PAGING_OFFSET => $offset,
218 218
                 JsonApiQueryValidatingParserInterface::PARAM_PAGING_LIMIT  => $data->getLimit(),
219 219
             ];
220
-            $fullUrl          = $uri . '?' . http_build_query($paramsWithPaging);
220
+            $fullUrl = $uri.'?'.http_build_query($paramsWithPaging);
221 221
 
222 222
             return $fullUrl;
223 223
         };
Please login to merge, or discard this patch.
src/Http/Traits/DefaultControllerMethodsTrait.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -269,7 +269,7 @@
 block discarded – undo
269 269
      * @param FactoryInterface                     $errorFactory
270 270
      * @param FormatterFactoryInterface            $formatterFactory
271 271
      *
272
-     * @return ResponseInterface
272
+     * @return string
273 273
      */
274 274
     protected static function defaultCreate(
275 275
         string $requestBody,
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -792,7 +792,7 @@  discard block
 block discarded – undo
792 792
      */
793 793
     private static function assertClassValueDefined(?string $value): void
794 794
     {
795
-        assert(empty($value) === false, 'Value should be defined in `' . static::class . '`.');
795
+        assert(empty($value) === false, 'Value should be defined in `'.static::class.'`.');
796 796
     }
797 797
 
798 798
     /**
@@ -805,7 +805,7 @@  discard block
 block discarded – undo
805 805
     {
806 806
         assert(
807 807
             array_key_exists($interface, class_implements($class)) === true,
808
-            "Class `$class` should implement `" . $interface . '` interface.'
808
+            "Class `$class` should implement `".$interface.'` interface.'
809 809
         );
810 810
     }
811 811
 }
Please login to merge, or discard this patch.
src/Http/Query/ParametersMapper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
     public function getMappedIncludes(): iterable
247 247
     {
248 248
         $fromSchema        = $this->getRootSchema();
249
-        $getMappedRelLinks = function (iterable $links) use ($fromSchema) : iterable {
249
+        $getMappedRelLinks = function(iterable $links) use ($fromSchema) : iterable {
250 250
             foreach ($links as $link) {
251 251
                 assert(is_string($link));
252 252
                 $fromSchemaClass = get_class($fromSchema);
@@ -296,14 +296,14 @@  discard block
 block discarded – undo
296 296
         //     ['rel2_name1', ],
297 297
         //     ['rel3_name1', 'rel3_name2', 'rel3_name3', ],
298 298
         // ]
299
-        $includeAsModelNames = function (iterable $relationships): iterable {
299
+        $includeAsModelNames = function(iterable $relationships): iterable {
300 300
             foreach ($relationships as $relationship) {
301 301
                 assert($relationship instanceof RelationshipInterface);
302 302
                 yield $relationship->getNameInModel();
303 303
             }
304 304
         };
305 305
         $mappedIncludes      = $this->getMappedIncludes();
306
-        $getIncludes         = function () use ($mappedIncludes, $includeAsModelNames) : iterable {
306
+        $getIncludes         = function() use ($mappedIncludes, $includeAsModelNames) : iterable {
307 307
             foreach ($mappedIncludes as $relationships) {
308 308
                 yield $includeAsModelNames($relationships);
309 309
             }
Please login to merge, or discard this patch.
src/Api/Crud.php 1 patch
Spacing   +18 added lines, -19 removed lines patch added patch discarded remove patch
@@ -689,7 +689,7 @@  discard block
 block discarded – undo
689 689
             $classAtPath = new ArrayObject();
690 690
             $idsAtPath   = new ArrayObject();
691 691
 
692
-            $registerModelAtRoot = function ($model) use ($modelStorage, $modelsAtPath, $idsAtPath): void {
692
+            $registerModelAtRoot = function($model) use ($modelStorage, $modelsAtPath, $idsAtPath): void {
693 693
                 self::registerModelAtPath(
694 694
                     $model,
695 695
                     static::ROOT_PATH,
@@ -777,7 +777,7 @@  discard block
 block discarded – undo
777 777
                 assert(is_string($pathPiece));
778 778
                 $parent                    = $tmpPath;
779 779
                 $tmpPath                   = empty($tmpPath) === true ?
780
-                    $pathPiece : $tmpPath . static::PATH_SEPARATOR . $pathPiece;
780
+                    $pathPiece : $tmpPath.static::PATH_SEPARATOR.$pathPiece;
781 781
                 $normalizedPaths[$tmpPath] = [$parent, $pathPiece];
782 782
                 $pathsDepths[$parent]      = $parentDepth++;
783 783
             }
@@ -934,7 +934,7 @@  discard block
 block discarded – undo
934 934
     ): ModelQueryBuilder {
935 935
         assert(
936 936
             $this->getModelSchemas()->hasRelationship($this->getModelClass(), $relationshipName),
937
-            "Relationship `$relationshipName` do not exist in model `" . $this->getModelClass() . '`'
937
+            "Relationship `$relationshipName` do not exist in model `".$this->getModelClass().'`'
938 938
         );
939 939
 
940 940
         // as we read data from a relationship our main table and model would be the table/model in the relationship
@@ -953,8 +953,7 @@  discard block
 block discarded – undo
953 953
             $filters = $this->getFilters();
954 954
             $sorts   = $this->getSorts();
955 955
             $this->areFiltersWithAnd() ?
956
-                $builder->addRelationshipFiltersAndSortsWithAnd($reverseRelName, $filters, $sorts) :
957
-                $builder->addRelationshipFiltersAndSortsWithOr($reverseRelName, $filters, $sorts);
956
+                $builder->addRelationshipFiltersAndSortsWithAnd($reverseRelName, $filters, $sorts) : $builder->addRelationshipFiltersAndSortsWithOr($reverseRelName, $filters, $sorts);
958 957
         }
959 958
         // ... and the input filters to actual data we select
960 959
         if ($relationshipFilters !== null) {
@@ -982,7 +981,7 @@  discard block
 block discarded – undo
982 981
     ) {
983 982
         assert(
984 983
             $this->getModelSchemas()->hasRelationship($this->getModelClass(), $name),
985
-            "Relationship `$name` do not exist in model `" . $this->getModelClass() . '`'
984
+            "Relationship `$name` do not exist in model `".$this->getModelClass().'`'
986 985
         );
987 986
 
988 987
         // depending on the relationship type we expect the result to be either single resource or a collection
@@ -1009,7 +1008,7 @@  discard block
 block discarded – undo
1009 1008
     ): array {
1010 1009
         assert(
1011 1010
             $this->getModelSchemas()->hasRelationship($this->getModelClass(), $name),
1012
-            "Relationship `$name` do not exist in model `" . $this->getModelClass() . '`'
1011
+            "Relationship `$name` do not exist in model `".$this->getModelClass().'`'
1013 1012
         );
1014 1013
 
1015 1014
         // depending on the relationship type we expect the result to be either single resource or a collection
@@ -1083,7 +1082,7 @@  discard block
 block discarded – undo
1083 1082
 
1084 1083
         $this->clearFetchParameters();
1085 1084
 
1086
-        return (int)$deleted;
1085
+        return (int) $deleted;
1087 1086
     }
1088 1087
 
1089 1088
     /**
@@ -1097,7 +1096,7 @@  discard block
 block discarded – undo
1097 1096
 
1098 1097
         $this->clearFetchParameters();
1099 1098
 
1100
-        return (int)$deleted > 0;
1099
+        return (int) $deleted > 0;
1101 1100
     }
1102 1101
 
1103 1102
     /**
@@ -1118,7 +1117,7 @@  discard block
 block discarded – undo
1118 1117
 
1119 1118
         $this->clearBuilderParameters()->clearFetchParameters();
1120 1119
 
1121
-        $this->inTransaction(function () use ($saveMain, $toMany, &$index) {
1120
+        $this->inTransaction(function() use ($saveMain, $toMany, &$index) {
1122 1121
             $saveMain->execute();
1123 1122
 
1124 1123
             // if no index given will use last insert ID as index
@@ -1134,7 +1133,7 @@  discard block
 block discarded – undo
1134 1133
                         ->prepareCreateInToManyRelationship($relationshipName, $index, $secondaryIdBindName)
1135 1134
                 );
1136 1135
                 foreach ($secondaryIds as $secondaryId) {
1137
-                    $inserted += (int)$saveToMany->setParameter($secondaryIdBindName, $secondaryId)->execute();
1136
+                    $inserted += (int) $saveToMany->setParameter($secondaryIdBindName, $secondaryId)->execute();
1138 1137
                 }
1139 1138
             }
1140 1139
         });
@@ -1163,12 +1162,12 @@  discard block
 block discarded – undo
1163 1162
             ->createBuilder($this->getModelClass())
1164 1163
             ->updateModels($allowedChanges)
1165 1164
             ->addFiltersWithAndToTable($filters);
1166
-        $saveMain       = $this->builderSaveResourceOnUpdate($saveMain);
1165
+        $saveMain = $this->builderSaveResourceOnUpdate($saveMain);
1167 1166
         $saveMain->getSQL(); // prepare
1168 1167
 
1169 1168
         $this->clearBuilderParameters()->clearFetchParameters();
1170 1169
 
1171
-        $this->inTransaction(function () use ($saveMain, $toMany, $index, &$updated) {
1170
+        $this->inTransaction(function() use ($saveMain, $toMany, $index, &$updated) {
1172 1171
             $updated = $saveMain->execute();
1173 1172
 
1174 1173
             foreach ($toMany as $relationshipName => $secondaryIds) {
@@ -1188,12 +1187,12 @@  discard block
 block discarded – undo
1188 1187
                         ->prepareCreateInToManyRelationship($relationshipName, $index, $secondaryIdBindName)
1189 1188
                 );
1190 1189
                 foreach ($secondaryIds as $secondaryId) {
1191
-                    $updated += (int)$saveToMany->setParameter($secondaryIdBindName, $secondaryId)->execute();
1190
+                    $updated += (int) $saveToMany->setParameter($secondaryIdBindName, $secondaryId)->execute();
1192 1191
                 }
1193 1192
             }
1194 1193
         });
1195 1194
 
1196
-        return (int)$updated;
1195
+        return (int) $updated;
1197 1196
     }
1198 1197
 
1199 1198
     /**
@@ -1344,7 +1343,7 @@  discard block
 block discarded – undo
1344 1343
     {
1345 1344
         $countBuilder = $this->createBuilder($this->getModelClass());
1346 1345
         $countBuilder->setParameters($builder->getParameters());
1347
-        $countBuilder->select('COUNT(*)')->from('(' . $builder->getSQL() . ') AS RESULT');
1346
+        $countBuilder->select('COUNT(*)')->from('('.$builder->getSQL().') AS RESULT');
1348 1347
 
1349 1348
         return $countBuilder;
1350 1349
     }
@@ -1555,7 +1554,7 @@  discard block
 block discarded – undo
1555 1554
 
1556 1555
         $pkName = $this->getModelSchemas()->getPrimaryKey($parentClass);
1557 1556
 
1558
-        $registerModelAtPath = function ($model, string $path) use ($deDup, $modelsAtPath, $idsAtPath) {
1557
+        $registerModelAtPath = function($model, string $path) use ($deDup, $modelsAtPath, $idsAtPath) {
1559 1558
             return self::registerModelAtPath(
1560 1559
                 $model,
1561 1560
                 $path,
@@ -1567,7 +1566,7 @@  discard block
 block discarded – undo
1567 1566
         };
1568 1567
 
1569 1568
         foreach ($childRelationships as $name) {
1570
-            $childrenPath = $parentsPath !== static::ROOT_PATH ? $parentsPath . static::PATH_SEPARATOR . $name : $name;
1569
+            $childrenPath = $parentsPath !== static::ROOT_PATH ? $parentsPath.static::PATH_SEPARATOR.$name : $name;
1571 1570
 
1572 1571
             $relationshipType = $this->getModelSchemas()->getRelationshipType($parentClass, $name);
1573 1572
             list ($targetModelClass, $reverseRelName) =
@@ -1617,7 +1616,7 @@  discard block
 block discarded – undo
1617 1616
                             [$pkName => [FilterParameterInterface::OPERATION_EQUALS => [$parent->{$pkName}]]],
1618 1617
                             []
1619 1618
                         );
1620
-                        $children      = $this->fetchPaginatedResourcesWithoutRelationships(
1619
+                        $children = $this->fetchPaginatedResourcesWithoutRelationships(
1621 1620
                             $clonedBuilder,
1622 1621
                             $clonedBuilder->getModelClass()
1623 1622
                         );
Please login to merge, or discard this patch.
src/Package/FluteContainerConfigurator.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -48,18 +48,18 @@  discard block
 block discarded – undo
48 48
 
49 49
         $container[FactoryInterface::class] = $factory;
50 50
 
51
-        $container[JsonSchemasInterface::class] = function (PsrContainerInterface $container) use ($factory) {
51
+        $container[JsonSchemasInterface::class] = function(PsrContainerInterface $container) use ($factory) {
52 52
             $settings     = $container->get(SettingsProviderInterface::class)->get(FluteSettings::class);
53 53
             $modelSchemas = $container->get(ModelSchemaInfoInterface::class);
54 54
 
55 55
             return $factory->createJsonSchemas($settings[FluteSettings::KEY_MODEL_TO_SCHEMA_MAP], $modelSchemas);
56 56
         };
57 57
 
58
-        $container[ParametersMapperInterface::class] = function (PsrContainerInterface $container) {
58
+        $container[ParametersMapperInterface::class] = function(PsrContainerInterface $container) {
59 59
             return new ParametersMapper($container->get(JsonSchemasInterface::class));
60 60
         };
61 61
 
62
-        $container[EncoderInterface::class] = function (PsrContainerInterface $container) use ($factory) {
62
+        $container[EncoderInterface::class] = function(PsrContainerInterface $container) use ($factory) {
63 63
             /** @var JsonSchemasInterface $jsonSchemas */
64 64
             $jsonSchemas = $container->get(JsonSchemasInterface::class);
65 65
             $settings    = $container->get(SettingsProviderInterface::class)->get(FluteSettings::class);
@@ -74,19 +74,19 @@  discard block
 block discarded – undo
74 74
             return $encoder;
75 75
         };
76 76
 
77
-        $container[RelationshipPaginationStrategyInterface::class] = function (PsrContainerInterface $container) {
77
+        $container[RelationshipPaginationStrategyInterface::class] = function(PsrContainerInterface $container) {
78 78
             $settings = $container->get(SettingsProviderInterface::class)->get(FluteSettings::class);
79 79
 
80 80
             return new BasicRelationshipPaginationStrategy($settings[FluteSettings::KEY_DEFAULT_PAGING_SIZE]);
81 81
         };
82 82
 
83
-        $container[JsonApiParserFactoryInterface::class] = function (PsrContainerInterface $container) {
83
+        $container[JsonApiParserFactoryInterface::class] = function(PsrContainerInterface $container) {
84 84
             $factory = new JsonApiParserFactory($container);
85 85
 
86 86
             return $factory;
87 87
         };
88 88
 
89
-        $container[FormValidatorFactoryInterface::class] = function (PsrContainerInterface $container) {
89
+        $container[FormValidatorFactoryInterface::class] = function(PsrContainerInterface $container) {
90 90
             $factory = new FormValidatorFactory($container);
91 91
 
92 92
             return $factory;
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
      */
105 105
     public static function configureExceptionHandler(LimoncelloContainerInterface $container)
106 106
     {
107
-        $container[ThrowableHandlerInterface::class] = function (PsrContainerInterface $container) {
107
+        $container[ThrowableHandlerInterface::class] = function(PsrContainerInterface $container) {
108 108
             /** @var CacheSettingsProviderInterface $provider */
109 109
             $provider      = $container->get(CacheSettingsProviderInterface::class);
110 110
             $appConfig     = $provider->getApplicationConfiguration();
Please login to merge, or discard this patch.