Completed
Pull Request — master (#1332)
by Peter
01:29
created
Imagine/Cache/Resolver/AmazonS3Resolver.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
      *
183 183
      * @param string $path
184 184
      *
185
-     * @return string
185
+     * @return \CFResponse
186 186
      */
187 187
     protected function getObjectUrl($path)
188 188
     {
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
      *
197 197
      * @throws \S3_Exception
198 198
      *
199
-     * @return bool
199
+     * @return boolean|null
200 200
      */
201 201
     protected function objectExists($objectPath)
202 202
     {
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
     }
205 205
 
206 206
     /**
207
-     * @param mixed $message
207
+     * @param string $message
208 208
      * @param array $context
209 209
      */
210 210
     protected function logError($message, array $context = [])
Please login to merge, or discard this patch.
Imagine/Cache/Resolver/WebPathResolver.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -130,6 +130,8 @@
 block discarded – undo
130 130
 
131 131
     /**
132 132
      * {@inheritdoc}
133
+     * @param string $path
134
+     * @param string $filter
133 135
      */
134 136
     protected function getFileUrl($path, $filter)
135 137
     {
Please login to merge, or discard this patch.
Binary/Loader/FileSystemLoader.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -79,6 +79,9 @@
 block discarded – undo
79 79
         return new FileBinary($path, $mimeType, $extension);
80 80
     }
81 81
 
82
+    /**
83
+     * @return string|null
84
+     */
82 85
     private function getExtension(?string $mimeType): ?string
83 86
     {
84 87
         if ($this->extensionGuesser instanceof DeprecatedExtensionGuesserInterface) {
Please login to merge, or discard this patch.
Binary/Loader/FlysystemLoader.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -66,6 +66,11 @@
 block discarded – undo
66 66
         );
67 67
     }
68 68
 
69
+    /**
70
+     * @param string|false $mimeType
71
+     *
72
+     * @return string|null
73
+     */
69 74
     private function getExtension(?string $mimeType): ?string
70 75
     {
71 76
         if ($this->extensionGuesser instanceof DeprecatedExtensionGuesserInterface) {
Please login to merge, or discard this patch.
Imagine/Data/DataManager.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -176,6 +176,11 @@
 block discarded – undo
176 176
         return $defaultImage;
177 177
     }
178 178
 
179
+    /**
180
+     * @param string|null $mimeType
181
+     *
182
+     * @return string|null
183
+     */
179 184
     private function getExtension(?string $mimeType): ?string
180 185
     {
181 186
         if ($this->extensionGuesser instanceof DeprecatedExtensionGuesserInterface) {
Please login to merge, or discard this patch.
DependencyInjection/Compiler/NonFunctionalFilterExceptionPass.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Liip\ImagineBundle\DependencyInjection\Compiler;
4 4
 
5
-use Liip\ImagineBundle\Imagine\Filter\Loader\NonFunctionalPasteFilterLoader;
6
-use Liip\ImagineBundle\Imagine\Filter\Loader\NonFunctionalWatermarkFilterLoader;
7 5
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
8 6
 use Symfony\Component\DependencyInjection\ContainerBuilder;
9 7
 
Please login to merge, or discard this patch.
Component/Console/Style/ImagineStyle.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,6 @@
 block discarded – undo
15 15
 use Symfony\Component\Console\Input\InputInterface;
16 16
 use Symfony\Component\Console\Output\OutputInterface;
17 17
 use Symfony\Component\Console\Style\SymfonyStyle;
18
-use Symfony\Component\Console\Terminal;
19 18
 use ValueError;
20 19
 
21 20
 /**
Please login to merge, or discard this patch.