Completed
Pull Request — 2.x (#1258)
by
unknown
01:50
created
Imagine/Cache/Resolver/WebPathResolver.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -130,6 +130,8 @@
 block discarded – undo
130 130
 
131 131
     /**
132 132
      * {@inheritdoc}
133
+     * @param string $path
134
+     * @param string $filter
133 135
      */
134 136
     protected function getFileUrl($path, $filter)
135 137
     {
Please login to merge, or discard this patch.
Controller/ImagineController.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -135,6 +135,9 @@
 block discarded – undo
135 135
         }, $path, $filter, $hash);
136 136
     }
137 137
 
138
+    /**
139
+     * @param string $hash
140
+     */
138 141
     private function createRedirectResponse(\Closure $url, string $path, string $filter, ?string $hash = null): RedirectResponse
139 142
     {
140 143
         try {
Please login to merge, or discard this patch.
Binary/Loader/FileSystemLoader.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -79,6 +79,9 @@
 block discarded – undo
79 79
         return new FileBinary($path, $mimeType, $extension);
80 80
     }
81 81
 
82
+    /**
83
+     * @return string|null
84
+     */
82 85
     private function getExtension(?string $mimeType): ?string
83 86
     {
84 87
         if ($this->extensionGuesser instanceof DeprecatedExtensionGuesserInterface) {
Please login to merge, or discard this patch.
Binary/Loader/FlysystemLoader.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -66,6 +66,11 @@
 block discarded – undo
66 66
         );
67 67
     }
68 68
 
69
+    /**
70
+     * @param string|false $mimeType
71
+     *
72
+     * @return string|null
73
+     */
69 74
     private function getExtension(?string $mimeType): ?string
70 75
     {
71 76
         if ($this->extensionGuesser instanceof DeprecatedExtensionGuesserInterface) {
Please login to merge, or discard this patch.
Imagine/Data/DataManager.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -176,6 +176,11 @@
 block discarded – undo
176 176
         return $defaultImage;
177 177
     }
178 178
 
179
+    /**
180
+     * @param string|null $mimeType
181
+     *
182
+     * @return string|null
183
+     */
179 184
     private function getExtension(?string $mimeType): ?string
180 185
     {
181 186
         if ($this->extensionGuesser instanceof DeprecatedExtensionGuesserInterface) {
Please login to merge, or discard this patch.
Command/WarmCacheCommand.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
     /**
71 71
      * Returns Logger Closure
72 72
      *
73
-     * @return callable
73
+     * @return \Closure
74 74
      */
75 75
     protected function getLoggerClosure(OutputInterface $output)
76 76
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -2,10 +2,7 @@
 block discarded – undo
2 2
 
3 3
 namespace Liip\ImagineBundle\Command;
4 4
 
5
-use Liip\ImagineBundle\Imagine\Cache\CacheManager;
6 5
 use Liip\ImagineBundle\Imagine\Cache\CacheWarmer;
7
-use Liip\ImagineBundle\Imagine\Data\DataManager;
8
-use Liip\ImagineBundle\Imagine\Filter\FilterManager;
9 6
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
10 7
 use Symfony\Component\Console\Input\InputArgument;
11 8
 use Symfony\Component\Console\Input\InputInterface;
Please login to merge, or discard this patch.
Imagine/Cache/Resolver/AmazonS3Resolver.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
      *
180 180
      * @param string $path
181 181
      *
182
-     * @return string
182
+     * @return \CFResponse
183 183
      */
184 184
     protected function getObjectUrl($path)
185 185
     {
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
      *
194 194
      * @throws \S3_Exception
195 195
      *
196
-     * @return bool
196
+     * @return boolean|null
197 197
      */
198 198
     protected function objectExists($objectPath)
199 199
     {
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
     }
202 202
 
203 203
     /**
204
-     * @param mixed $message
204
+     * @param string $message
205 205
      */
206 206
     protected function logError($message, array $context = [])
207 207
     {
Please login to merge, or discard this patch.