FilterRuntime::filter() - Code Metrics - Inspection of "Create Lazy-Loaded Twig Extension" - liip/LiipImagineBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 2.x (#1376)

unknown

created 2021-05-26 18:41 UTC

FilterRuntime::filter() A

↳ Parent: FilterRuntime

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	4
Ratio	100 %

Importance

Changes

Metric	Value
dl	4
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	5

<?php

/*
 * This file is part of the `liip/LiipImagineBundle` project.
 *
 * (c) https://github.com/liip/LiipImagineBundle/graphs/contributors
 *
 * For the full copyright and license information, please view the LICENSE.md
 * file that was distributed with this source code.
 */

namespace Liip\ImagineBundle\Templating;

use Liip\ImagineBundle\Imagine\Cache\CacheManager;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Twig\Extension\RuntimeExtensionInterface;

class FilterRuntime implements RuntimeExtensionInterface

{
    /**
     * @var CacheManager
     */
    private $cache;

    public function __construct(CacheManager $cache)
    {
        $this->cache = $cache;
    }

    /**
     * Gets the browser path for the image and filter to apply.
     *
     * @param string      $path
     * @param string      $filter
     * @param string|null $resolver
     * @param int         $referenceType
     *
     * @return string
     */
    public function filter($path, $filter, array $config = [], $resolver = null, $referenceType = UrlGeneratorInterface::ABSOLUTE_URL)
    {
        return $this->cache->getBrowserPath(parse_url($path, PHP_URL_PATH), $filter, $config, $resolver, $referenceType);

    }
}


1		<?php
2
3		/*
4		* This file is part of the `liip/LiipImagineBundle` project.
5		*
6		* (c) https://github.com/liip/LiipImagineBundle/graphs/contributors
7		*
8		* For the full copyright and license information, please view the LICENSE.md
9		* file that was distributed with this source code.
10		*/
11
12		namespace Liip\ImagineBundle\Templating;
13
14		use Liip\ImagineBundle\Imagine\Cache\CacheManager;
15		use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
16		use Twig\Extension\RuntimeExtensionInterface;
17
18	View Code Duplication	class FilterRuntime implements RuntimeExtensionInterface
		0 ignored issues – show Duplication introduced 2021-05-24 13:04 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		/**
21		* @var CacheManager
22		*/
23		private $cache;
24
25		public function __construct(CacheManager $cache)
26		{
27		$this->cache = $cache;
28		}
29
30		/**
31		* Gets the browser path for the image and filter to apply.
32		*
33		* @param string $path
34		* @param string $filter
35		* @param string\|null $resolver
36		* @param int $referenceType
37		*
38		* @return string
39		*/
40		public function filter($path, $filter, array $config = [], $resolver = null, $referenceType = UrlGeneratorInterface::ABSOLUTE_URL)
41		{
42		return $this->cache->getBrowserPath(parse_url($path, PHP_URL_PATH), $filter, $config, $resolver, $referenceType);
		0 ignored issues – show Security Bug introduced 2021-05-24 13:04 UTC by Report Bug Copy Issue Report It seems like `parse_url($path, PHP_URL_PATH)` targeting `parse_url()` can also be of type `false`; however, `Liip\ImagineBundle\Imagi...nager::getBrowserPath()` does only seem to accept `string`, did you maybe forget to handle an error condition? Loading history...
43		}
44		}
45

liip / LiipImagineBundle

Pull Request — 2.x (#1376)

FilterRuntime::filter() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like