Liip\ImagineBundle\Templating\FilterRuntime

Complexity

Total Complexity

2

Size/Duplication

Total Lines	27
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	4	4	1
A	filter()	4	4	1

<?php

/*
 * This file is part of the `liip/LiipImagineBundle` project.
 *
 * (c) https://github.com/liip/LiipImagineBundle/graphs/contributors
 *
 * For the full copyright and license information, please view the LICENSE.md
 * file that was distributed with this source code.
 */

namespace Liip\ImagineBundle\Templating;

use Liip\ImagineBundle\Imagine\Cache\CacheManager;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Twig\Extension\RuntimeExtensionInterface;

class FilterRuntime implements RuntimeExtensionInterface

This class seems to be duplicated in your project.

{
    /**
     * @var CacheManager
     */
    private $cache;

    public function __construct(CacheManager $cache)
    {
        $this->cache = $cache;
    }

    /**
     * Gets the browser path for the image and filter to apply.
     *
     * @param string      $path
     * @param string      $filter
     * @param string|null $resolver
     * @param int         $referenceType
     *
     * @return string
     */
    public function filter($path, $filter, array $config = [], $resolver = null, $referenceType = UrlGeneratorInterface::ABSOLUTE_URL)
    {
        return $this->cache->getBrowserPath(parse_url($path, PHP_URL_PATH), $filter, $config, $resolver, $referenceType);

It seems like parse_url($path, PHP_URL_PATH) targeting parse_url() can also be of type false; however, Liip\ImagineBundle\Imagine\Cache\CacheManager::getBrowserPath() does only seem to accept string, did you maybe forget to handle an error condition?

    }
}