APIMockController::darkSkyMockAction() - Code Metrics - liiinder/ramverk1-module - Measure and Improve Code Quality continuously with Scrutinizer

APIMockController::darkSkyMockAction() A
last analyzed 2019-12-10 18:35 UTC

↳ Parent: APIMockController

Complexity

Conditions	3
Paths	4

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	3
eloc	6
c	2
b	0
f	0
nc	4
nop	0
dl	0
loc	8
ccs	7
cts	7
cp	1
crap	3
rs	10

<?php

namespace Linder\Controller;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;

/**
 * A controller that handles a get request
 * uses a model and returns a Json.
 */
class APIMockController implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;

    /**
     * Main index page, serves as the ip mock
     * @return Array
     */
    public function indexAction() : array
    {
        $ip = $this->di->request->getGet("ip") ?: $this->di->request->getServer("REMOTE_ADDR");

        $ipMock = new \Linder\Mock\IpVerifierMock();
        return [
            $ipMock->getJson($ip)
        ];
    }

    /**
     * Darksky mock route which mocks the return
     * type from the external darksky api
     * @return Array
     */
    public function darkSkyMockAction() : Array
    {
        $darksky = new \Linder\Mock\DarkSkyMock();
        $url = $this->di->request->getCurrentUrl();

        $res = (strpos($url, "?exclude=currently,flags") || $this->di->request->getGet("type") == "past") ?
            $darksky->getWeatherPast() :
            $darksky->getWeatherComing();
        return $res;
    }
}


1		<?php
2
3		namespace Linder\Controller;
4
5		use Anax\Commons\ContainerInjectableInterface;
6		use Anax\Commons\ContainerInjectableTrait;
7
8		/**
9		* A controller that handles a get request
10		* uses a model and returns a Json.
11		*/
12		class APIMockController implements ContainerInjectableInterface
13		{
14		use ContainerInjectableTrait;
15
16		/**
17		* Main index page, serves as the ip mock
18		* @return Array
19		*/
20	1	public function indexAction() : array
21		{
22	1	$ip = $this->di->request->getGet("ip") ?: $this->di->request->getServer("REMOTE_ADDR");
		0 ignored issues – show Bug introduced 2019-12-07 20:53 UTC by Report Bug Copy Issue Report Accessing `request` on the interface `Psr\Container\ContainerInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
23	1	$ipMock = new \Linder\Mock\IpVerifierMock();
24		return [
25	1	$ipMock->getJson($ip)
26		];
27		}
28
29		/**
30		* Darksky mock route which mocks the return
31		* type from the external darksky api
32		* @return Array
33		*/
34	1	public function darkSkyMockAction() : Array
35		{
36	1	$darksky = new \Linder\Mock\DarkSkyMock();
37	1	$url = $this->di->request->getCurrentUrl();
		0 ignored issues – show Bug introduced 2019-12-07 20:53 UTC by Report Bug Copy Issue Report Accessing `request` on the interface `Psr\Container\ContainerInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
38	1	$res = (strpos($url, "?exclude=currently,flags") \|\| $this->di->request->getGet("type") == "past") ?
39	1	$darksky->getWeatherPast() :
40	1	$darksky->getWeatherComing();
41	1	return $res;
42		}
43		}
44

liiinder / ramverk1-module

APIMockController::darkSkyMockAction() A last analyzed 2019-12-10 18:35 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

APIMockController::darkSkyMockAction() A
last analyzed 2019-12-10 18:35 UTC