Linder\Controller\APIMockController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	indexAction()	0	6	2
A	darkSkyMockAction()	0	8	3

<?php

namespace Linder\Controller;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;

/**
 * A controller that handles a get request
 * uses a model and returns a Json.
 */
class APIMockController implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;

    /**
     * Main index page, serves as the ip mock
     * @return Array
     */
    public function indexAction() : array
    {
        $ip = $this->di->request->getGet("ip") ?: $this->di->request->getServer("REMOTE_ADDR");

Accessing request on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $ipMock = new \Linder\Mock\IpVerifierMock();
        return [
            $ipMock->getJson($ip)
        ];
    }

    /**
     * Darksky mock route which mocks the return
     * type from the external darksky api
     * @return Array
     */
    public function darkSkyMockAction() : Array
    {
        $darksky = new \Linder\Mock\DarkSkyMock();
        $url = $this->di->request->getCurrentUrl();

Accessing request on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $res = (strpos($url, "?exclude=currently,flags") || $this->di->request->getGet("type") == "past") ?
            $darksky->getWeatherPast() :
            $darksky->getWeatherComing();
        return $res;
    }
}