Inspection of "Merge pull request #318 from lightspeeddevelopment..." - lightspeeddevelopment/lsx - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8066e5...c2d913 )

by Jacques

created 2020-03-02 10:09 UTC

Status

Spacing +48 added lines, -48 removed lines patch added patch discarded remove patch

@@ -6,11 +6,11 @@  discard block
 block discarded – undo
  * @subpackage the-events-calendar
  */
 
-if ( ! defined( 'ABSPATH' ) ) {
+if ( ! defined('ABSPATH')) {
 	exit;
 }
 
-if ( ! function_exists( 'lsx_tec_scripts_add_styles' ) ) :
+if ( ! function_exists('lsx_tec_scripts_add_styles')) :
 
 	/**
 	 * The Events Calendar enqueue styles.
@@ -22,26 +22,26 @@  discard block
 block discarded – undo
 
 		// Get plugin version.
 		$plugin  = 'the-events-calendar/the-events-calendar.php';
-		$data    = get_plugin_data( WP_PLUGIN_DIR . '/' . $plugin );
+		$data    = get_plugin_data(WP_PLUGIN_DIR . '/' . $plugin);
 		$version = $data['Version'];
 
-		if ( substr( $version, 0, 1 ) >= '5' ) {
+		if (substr($version, 0, 1) >= '5') {
 			// New Version 5.0 and up.
-			wp_enqueue_style( 'the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar/the-events-calendar-5.css', array( 'lsx_main' ), LSX_VERSION );
+			wp_enqueue_style('the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar/the-events-calendar-5.css', array('lsx_main'), LSX_VERSION);
 		} else {
 			// Old Version.
-			wp_enqueue_style( 'the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar/the-events-calendar.css', array( 'lsx_main' ), LSX_VERSION );
+			wp_enqueue_style('the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar/the-events-calendar.css', array('lsx_main'), LSX_VERSION);
 		}
 
-		wp_enqueue_style( 'the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar/the-events-calendar.css', array( 'lsx_main' ), LSX_VERSION );
-		wp_style_add_data( 'the-events-calendar-lsx', 'rtl', 'replace' );
+		wp_enqueue_style('the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar/the-events-calendar.css', array('lsx_main'), LSX_VERSION);
+		wp_style_add_data('the-events-calendar-lsx', 'rtl', 'replace');
 	}
 
-	add_action( 'wp_enqueue_scripts', 'lsx_tec_scripts_add_styles' );
+	add_action('wp_enqueue_scripts', 'lsx_tec_scripts_add_styles');
 
 endif;
 
-if ( ! function_exists( 'lsx_tec_theme_wrapper_start' ) ) :
+if ( ! function_exists('lsx_tec_theme_wrapper_start')) :
 
 	/**
 	 * The Events Calendar wrapper start.
@@ -51,17 +51,17 @@  discard block
 block discarded – undo
 	 */
 	function lsx_tec_theme_wrapper_start() {
 		lsx_content_wrap_before();
-		echo '<div id="primary" class="content-area ' . esc_attr( lsx_main_class() ) . '">';
+		echo '<div id="primary" class="content-area ' . esc_attr(lsx_main_class()) . '">';
 		lsx_content_before();
 		echo '<main id="main" class="site-main" role="main">';
 		lsx_content_top();
 	}
 
-	add_action( 'tribe_events_before_html', 'lsx_tec_theme_wrapper_start', 9 );
+	add_action('tribe_events_before_html', 'lsx_tec_theme_wrapper_start', 9);
 
 endif;
 
-if ( ! function_exists( 'lsx_tec_theme_wrapper_end' ) ) :
+if ( ! function_exists('lsx_tec_theme_wrapper_end')) :
 
 	/**
 	 * The Events Calendar wrapper end.
@@ -77,11 +77,11 @@  discard block
 block discarded – undo
 		lsx_content_wrap_after();
 	}
 
-	add_action( 'tribe_events_after_html', 'lsx_tec_theme_wrapper_end', 11 );
+	add_action('tribe_events_after_html', 'lsx_tec_theme_wrapper_end', 11);
 
 endif;
 
-if ( ! function_exists( 'lsx_tec_global_header_title' ) ) :
+if ( ! function_exists('lsx_tec_global_header_title')) :
 
 	/**
 	 * Move the events title into the global header
@@ -89,98 +89,98 @@  discard block
 block discarded – undo
 	 * @package    lsx
 	 * @subpackage the-events-calendar
 	 */
-	function lsx_tec_global_header_title( $title ) {
+	function lsx_tec_global_header_title($title) {
 
-		if ( tribe_is_community_edit_event_page() ) {
+		if (tribe_is_community_edit_event_page()) {
 
-			$is_route = get_query_var( 'WP_Route' );
-			switch ( $is_route ) {
+			$is_route = get_query_var('WP_Route');
+			switch ($is_route) {
 				case 'ce-edit-route':
-					$title = apply_filters( 'tribe_ce_edit_event_page_title', __( 'Edit an Event', 'lsx' ) );
+					$title = apply_filters('tribe_ce_edit_event_page_title', __('Edit an Event', 'lsx'));
 					break;
 
 				case 'ce-edit-organizer-route':
-					$title = __( 'Edit an Organizer', 'lsx' );
+					$title = __('Edit an Organizer', 'lsx');
 					break;
 
 				case 'ce-edit-venue-route':
-					$title = __( 'Edit a Venue', 'lsx' );
+					$title = __('Edit a Venue', 'lsx');
 					break;
 
 				default:
-					$title = apply_filters( 'tribe_ce_submit_event_page_title', __( 'Submit an Event', 'lsx' ) );
+					$title = apply_filters('tribe_ce_submit_event_page_title', __('Submit an Event', 'lsx'));
 					break;
 			}
-		} elseif ( tribe_is_community_my_events_page() ) {
-			$title = apply_filters( 'tribe_ce_submit_event_page_title', __( 'My Events', 'lsx' ) );
-		} elseif ( tribe_is_event() ) {
+		} elseif (tribe_is_community_my_events_page()) {
+			$title = apply_filters('tribe_ce_submit_event_page_title', __('My Events', 'lsx'));
+		} elseif (tribe_is_event()) {
 			$title = tribe_get_events_title();
 		}
 
 		// Only disable the title after we have retrieved it.
-		add_filter( 'tribe_get_events_title', 'lsx_text_disable_body_title', 200, 1 );
+		add_filter('tribe_get_events_title', 'lsx_text_disable_body_title', 200, 1);
 
-		if ( is_singular( 'tribe_events' ) ) {
-			add_filter( 'the_title', 'lsx_text_disable_body_title', 200, 1 );
+		if (is_singular('tribe_events')) {
+			add_filter('the_title', 'lsx_text_disable_body_title', 200, 1);
 		}
 		return $title;
 	}
-	add_filter( 'lsx_global_header_title', 'lsx_tec_global_header_title', 200, 1 );
+	add_filter('lsx_global_header_title', 'lsx_tec_global_header_title', 200, 1);
 
 endif;
 
-if ( ! function_exists( 'lsx_text_disable_body_title' ) ) :
+if ( ! function_exists('lsx_text_disable_body_title')) :
 	/**
 	 * Disable the events title for the post archive if the dynamic setting is active.
 	 *
 	 * @param $title
 	 * @return string
 	 */
-	function lsx_text_disable_body_title( $title ) {
+	function lsx_text_disable_body_title($title) {
 		$title = '';
-		remove_filter( 'the_title', 'lsx_text_disable_body_title', 200, 1 );
+		remove_filter('the_title', 'lsx_text_disable_body_title', 200, 1);
 		return $title;
 	}
 
 endif;
 
-if ( ! function_exists( 'lsx_tec_breadcrumb_filter' ) ) :
+if ( ! function_exists('lsx_tec_breadcrumb_filter')) :
 	/**
 	 * Fixes the community events breadcrumb
 	 *
 	 * @package    lsx
 	 * @subpackage the-events-calendar
 	 */
-	function lsx_tec_breadcrumb_filter( $crumbs ) {
+	function lsx_tec_breadcrumb_filter($crumbs) {
 
-		if ( tribe_is_venue() || tribe_is_organizer() || tribe_is_community_edit_event_page() || tribe_is_community_my_events_page() ) {
+		if (tribe_is_venue() || tribe_is_organizer() || tribe_is_community_edit_event_page() || tribe_is_community_my_events_page()) {
 			$new_crumbs    = array();
 			$new_crumbs[0] = $crumbs[0];
 
-			if ( function_exists( 'woocommerce_breadcrumb' ) ) {
+			if (function_exists('woocommerce_breadcrumb')) {
 				$new_crumbs[1] = array(
-					0 => __( 'Events', 'lsx' ),
-					1 => get_post_type_archive_link( 'tribe_events' ),
+					0 => __('Events', 'lsx'),
+					1 => get_post_type_archive_link('tribe_events'),
 				);
 			} else {
 				$new_crumbs[1] = array(
-					'text' => __( 'Events', 'lsx' ),
-					'url'  => get_post_type_archive_link( 'tribe_events' ),
+					'text' => __('Events', 'lsx'),
+					'url'  => get_post_type_archive_link('tribe_events'),
 				);
 			}
 
-			if ( tribe_is_community_my_events_page() ) {
+			if (tribe_is_community_my_events_page()) {
 				$new_crumbs[2] = $crumbs[2];
-			} elseif ( tribe_is_community_edit_event_page() ) {
+			} elseif (tribe_is_community_edit_event_page()) {
 
-				if ( function_exists( 'woocommerce_breadcrumb' ) ) {
+				if (function_exists('woocommerce_breadcrumb')) {
 					$new_crumbs[2] = array(
-						0 => apply_filters( 'tribe_ce_submit_event_page_title', __( 'My Events', 'lsx' ) ),
+						0 => apply_filters('tribe_ce_submit_event_page_title', __('My Events', 'lsx')),
 						1 => tribe_community_events_list_events_link(),
 					);
 				} else {
 					$new_crumbs[2] = array(
-						'text' => apply_filters( 'tribe_ce_submit_event_page_title', __( 'My Events', 'lsx' ) ),
+						'text' => apply_filters('tribe_ce_submit_event_page_title', __('My Events', 'lsx')),
 						'url'  => tribe_community_events_list_events_link(),
 					);
 				}
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
 		}
 		return $crumbs;
 	}
-	add_filter( 'wpseo_breadcrumb_links', 'lsx_tec_breadcrumb_filter', 30, 1 );
-	add_filter( 'woocommerce_get_breadcrumb', 'lsx_tec_breadcrumb_filter', 30, 1 );
+	add_filter('wpseo_breadcrumb_links', 'lsx_tec_breadcrumb_filter', 30, 1);
+	add_filter('woocommerce_get_breadcrumb', 'lsx_tec_breadcrumb_filter', 30, 1);
 
 endif;

Please login to merge, or discard this patch.

		@@ -6,11 +6,11 @@ discard block
		block discarded – undo
6	6	* @subpackage the-events-calendar
7	7	*/
8	8
9		-if ( ! defined( 'ABSPATH' ) ) {
	9	+if ( ! defined('ABSPATH')) {
10	10	exit;
11	11	}
12	12
13		-if ( ! function_exists( 'lsx_tec_scripts_add_styles' ) ) :
	13	+if ( ! function_exists('lsx_tec_scripts_add_styles')) :
14	14
15	15	/**
16	16	* The Events Calendar enqueue styles.
		@@ -22,26 +22,26 @@ discard block
		block discarded – undo
22	22
23	23	// Get plugin version.
24	24	$plugin = 'the-events-calendar/the-events-calendar.php';
25		- $data = get_plugin_data( WP_PLUGIN_DIR . '/' . $plugin );
	25	+ $data = get_plugin_data(WP_PLUGIN_DIR . '/' . $plugin);
26	26	$version = $data['Version'];
27	27
28		- if ( substr( $version, 0, 1 ) >= '5' ) {
	28	+ if (substr($version, 0, 1) >= '5') {
29	29	// New Version 5.0 and up.
30		- wp_enqueue_style( 'the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar/the-events-calendar-5.css', array( 'lsx_main' ), LSX_VERSION );
	30	+ wp_enqueue_style('the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar/the-events-calendar-5.css', array('lsx_main'), LSX_VERSION);
31	31	} else {
32	32	// Old Version.
33		- wp_enqueue_style( 'the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar/the-events-calendar.css', array( 'lsx_main' ), LSX_VERSION );
	33	+ wp_enqueue_style('the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar/the-events-calendar.css', array('lsx_main'), LSX_VERSION);
34	34	}
35	35
36		- wp_enqueue_style( 'the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar/the-events-calendar.css', array( 'lsx_main' ), LSX_VERSION );
37		- wp_style_add_data( 'the-events-calendar-lsx', 'rtl', 'replace' );
	36	+ wp_enqueue_style('the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar/the-events-calendar.css', array('lsx_main'), LSX_VERSION);
	37	+ wp_style_add_data('the-events-calendar-lsx', 'rtl', 'replace');
38	38	}
39	39
40		- add_action( 'wp_enqueue_scripts', 'lsx_tec_scripts_add_styles' );
	40	+ add_action('wp_enqueue_scripts', 'lsx_tec_scripts_add_styles');
41	41
42	42	endif;
43	43
44		-if ( ! function_exists( 'lsx_tec_theme_wrapper_start' ) ) :
	44	+if ( ! function_exists('lsx_tec_theme_wrapper_start')) :
45	45
46	46	/**
47	47	* The Events Calendar wrapper start.
		@@ -51,17 +51,17 @@ discard block
		block discarded – undo
51	51	*/
52	52	function lsx_tec_theme_wrapper_start() {
53	53	lsx_content_wrap_before();
54		- echo '<div id="primary" class="content-area ' . esc_attr( lsx_main_class() ) . '">';
	54	+ echo '<div id="primary" class="content-area ' . esc_attr(lsx_main_class()) . '">';
55	55	lsx_content_before();
56	56	echo '<main id="main" class="site-main" role="main">';
57	57	lsx_content_top();
58	58	}
59	59
60		- add_action( 'tribe_events_before_html', 'lsx_tec_theme_wrapper_start', 9 );
	60	+ add_action('tribe_events_before_html', 'lsx_tec_theme_wrapper_start', 9);
61	61
62	62	endif;
63	63
64		-if ( ! function_exists( 'lsx_tec_theme_wrapper_end' ) ) :
	64	+if ( ! function_exists('lsx_tec_theme_wrapper_end')) :
65	65
66	66	/**
67	67	* The Events Calendar wrapper end.
		@@ -77,11 +77,11 @@ discard block
		block discarded – undo
77	77	lsx_content_wrap_after();
78	78	}
79	79
80		- add_action( 'tribe_events_after_html', 'lsx_tec_theme_wrapper_end', 11 );
	80	+ add_action('tribe_events_after_html', 'lsx_tec_theme_wrapper_end', 11);
81	81
82	82	endif;
83	83
84		-if ( ! function_exists( 'lsx_tec_global_header_title' ) ) :
	84	+if ( ! function_exists('lsx_tec_global_header_title')) :
85	85
86	86	/**
87	87	* Move the events title into the global header
		@@ -89,98 +89,98 @@ discard block
		block discarded – undo
89	89	* @package lsx
90	90	* @subpackage the-events-calendar
91	91	*/
92		- function lsx_tec_global_header_title( $title ) {
	92	+ function lsx_tec_global_header_title($title) {
93	93
94		- if ( tribe_is_community_edit_event_page() ) {
	94	+ if (tribe_is_community_edit_event_page()) {
95	95
96		- $is_route = get_query_var( 'WP_Route' );
97		- switch ( $is_route ) {
	96	+ $is_route = get_query_var('WP_Route');
	97	+ switch ($is_route) {
98	98	case 'ce-edit-route':
99		- $title = apply_filters( 'tribe_ce_edit_event_page_title', __( 'Edit an Event', 'lsx' ) );
	99	+ $title = apply_filters('tribe_ce_edit_event_page_title', __('Edit an Event', 'lsx'));
100	100	break;
101	101
102	102	case 'ce-edit-organizer-route':
103		- $title = __( 'Edit an Organizer', 'lsx' );
	103	+ $title = __('Edit an Organizer', 'lsx');
104	104	break;
105	105
106	106	case 'ce-edit-venue-route':
107		- $title = __( 'Edit a Venue', 'lsx' );
	107	+ $title = __('Edit a Venue', 'lsx');
108	108	break;
109	109
110	110	default:
111		- $title = apply_filters( 'tribe_ce_submit_event_page_title', __( 'Submit an Event', 'lsx' ) );
	111	+ $title = apply_filters('tribe_ce_submit_event_page_title', __('Submit an Event', 'lsx'));
112	112	break;
113	113	}
114		- } elseif ( tribe_is_community_my_events_page() ) {
115		- $title = apply_filters( 'tribe_ce_submit_event_page_title', __( 'My Events', 'lsx' ) );
116		- } elseif ( tribe_is_event() ) {
	114	+ } elseif (tribe_is_community_my_events_page()) {
	115	+ $title = apply_filters('tribe_ce_submit_event_page_title', __('My Events', 'lsx'));
	116	+ } elseif (tribe_is_event()) {
117	117	$title = tribe_get_events_title();
118	118	}
119	119
120	120	// Only disable the title after we have retrieved it.
121		- add_filter( 'tribe_get_events_title', 'lsx_text_disable_body_title', 200, 1 );
	121	+ add_filter('tribe_get_events_title', 'lsx_text_disable_body_title', 200, 1);
122	122
123		- if ( is_singular( 'tribe_events' ) ) {
124		- add_filter( 'the_title', 'lsx_text_disable_body_title', 200, 1 );
	123	+ if (is_singular('tribe_events')) {
	124	+ add_filter('the_title', 'lsx_text_disable_body_title', 200, 1);
125	125	}
126	126	return $title;
127	127	}
128		- add_filter( 'lsx_global_header_title', 'lsx_tec_global_header_title', 200, 1 );
	128	+ add_filter('lsx_global_header_title', 'lsx_tec_global_header_title', 200, 1);
129	129
130	130	endif;
131	131
132		-if ( ! function_exists( 'lsx_text_disable_body_title' ) ) :
	132	+if ( ! function_exists('lsx_text_disable_body_title')) :
133	133	/**
134	134	* Disable the events title for the post archive if the dynamic setting is active.
135	135	*
136	136	* @param $title
137	137	* @return string
138	138	*/
139		- function lsx_text_disable_body_title( $title ) {
	139	+ function lsx_text_disable_body_title($title) {
140	140	$title = '';
141		- remove_filter( 'the_title', 'lsx_text_disable_body_title', 200, 1 );
	141	+ remove_filter('the_title', 'lsx_text_disable_body_title', 200, 1);
142	142	return $title;
143	143	}
144	144
145	145	endif;
146	146
147		-if ( ! function_exists( 'lsx_tec_breadcrumb_filter' ) ) :
	147	+if ( ! function_exists('lsx_tec_breadcrumb_filter')) :
148	148	/**
149	149	* Fixes the community events breadcrumb
150	150	*
151	151	* @package lsx
152	152	* @subpackage the-events-calendar
153	153	*/
154		- function lsx_tec_breadcrumb_filter( $crumbs ) {
	154	+ function lsx_tec_breadcrumb_filter($crumbs) {
155	155
156		- if ( tribe_is_venue() \|\| tribe_is_organizer() \|\| tribe_is_community_edit_event_page() \|\| tribe_is_community_my_events_page() ) {
	156	+ if (tribe_is_venue() \|\| tribe_is_organizer() \|\| tribe_is_community_edit_event_page() \|\| tribe_is_community_my_events_page()) {
157	157	$new_crumbs = array();
158	158	$new_crumbs[0] = $crumbs[0];
159	159
160		- if ( function_exists( 'woocommerce_breadcrumb' ) ) {
	160	+ if (function_exists('woocommerce_breadcrumb')) {
161	161	$new_crumbs[1] = array(
162		- 0 => __( 'Events', 'lsx' ),
163		- 1 => get_post_type_archive_link( 'tribe_events' ),
	162	+ 0 => __('Events', 'lsx'),
	163	+ 1 => get_post_type_archive_link('tribe_events'),
164	164	);
165	165	} else {
166	166	$new_crumbs[1] = array(
167		- 'text' => __( 'Events', 'lsx' ),
168		- 'url' => get_post_type_archive_link( 'tribe_events' ),
	167	+ 'text' => __('Events', 'lsx'),
	168	+ 'url' => get_post_type_archive_link('tribe_events'),
169	169	);
170	170	}
171	171
172		- if ( tribe_is_community_my_events_page() ) {
	172	+ if (tribe_is_community_my_events_page()) {
173	173	$new_crumbs[2] = $crumbs[2];
174		- } elseif ( tribe_is_community_edit_event_page() ) {
	174	+ } elseif (tribe_is_community_edit_event_page()) {
175	175
176		- if ( function_exists( 'woocommerce_breadcrumb' ) ) {
	176	+ if (function_exists('woocommerce_breadcrumb')) {
177	177	$new_crumbs[2] = array(
178		- 0 => apply_filters( 'tribe_ce_submit_event_page_title', __( 'My Events', 'lsx' ) ),
	178	+ 0 => apply_filters('tribe_ce_submit_event_page_title', __('My Events', 'lsx')),
179	179	1 => tribe_community_events_list_events_link(),
180	180	);
181	181	} else {
182	182	$new_crumbs[2] = array(
183		- 'text' => apply_filters( 'tribe_ce_submit_event_page_title', __( 'My Events', 'lsx' ) ),
	183	+ 'text' => apply_filters('tribe_ce_submit_event_page_title', __('My Events', 'lsx')),
184	184	'url' => tribe_community_events_list_events_link(),
185	185	);
186	186	}
		@@ -193,7 +193,7 @@ discard block
		block discarded – undo
193	193	}
194	194	return $crumbs;
195	195	}
196		- add_filter( 'wpseo_breadcrumb_links', 'lsx_tec_breadcrumb_filter', 30, 1 );
197		- add_filter( 'woocommerce_get_breadcrumb', 'lsx_tec_breadcrumb_filter', 30, 1 );
	196	+ add_filter('wpseo_breadcrumb_links', 'lsx_tec_breadcrumb_filter', 30, 1);
	197	+ add_filter('woocommerce_get_breadcrumb', 'lsx_tec_breadcrumb_filter', 30, 1);
198	198
199	199	endif;

lightspeeddevelopment / lsx

Push — master ( 8066e5...c2d913 )

Status

Category

Spacing +48 added lines, -48 removed lines patch added patch discarded remove patch