Inspection of "Making sure the Upcoming Events title does not ove..." - lightspeeddevelopment/lsx - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( deb734...53b10b )

by Warwick

created 2019-03-28 05:01 UTC

Status

Spacing +42 added lines, -42 removed lines patch added patch discarded remove patch

@@ -6,11 +6,11 @@  discard block
 block discarded – undo
  * @subpackage the-events-calendar
  */
 
-if ( ! defined( 'ABSPATH' ) ) {
+if ( ! defined('ABSPATH')) {
 	exit;
 }
 
-if ( ! function_exists( 'lsx_tec_scripts_add_styles' ) ) :
+if ( ! function_exists('lsx_tec_scripts_add_styles')) :
 
 	/**
 	 * The Events Calendar enqueue styles.
@@ -19,15 +19,15 @@  discard block
 block discarded – undo
 	 * @subpackage the-events-calendar
 	 */
 	function lsx_tec_scripts_add_styles() {
-		wp_enqueue_style( 'the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar.css', array( 'lsx_main' ), LSX_VERSION );
-		wp_style_add_data( 'the-events-calendar-lsx', 'rtl', 'replace' );
+		wp_enqueue_style('the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar.css', array('lsx_main'), LSX_VERSION);
+		wp_style_add_data('the-events-calendar-lsx', 'rtl', 'replace');
 	}
 
-	add_action( 'wp_enqueue_scripts', 'lsx_tec_scripts_add_styles' );
+	add_action('wp_enqueue_scripts', 'lsx_tec_scripts_add_styles');
 
 endif;
 
-if ( ! function_exists( 'lsx_tec_theme_wrapper_start' ) ) :
+if ( ! function_exists('lsx_tec_theme_wrapper_start')) :
 
 	/**
 	 * The Events Calendar wrapper start.
@@ -37,17 +37,17 @@  discard block
 block discarded – undo
 	 */
 	function lsx_tec_theme_wrapper_start() {
 		lsx_content_wrap_before();
-		echo '<div id="primary" class="content-area ' . esc_attr( lsx_main_class() ) . '">';
+		echo '<div id="primary" class="content-area ' . esc_attr(lsx_main_class()) . '">';
 		lsx_content_before();
 		echo '<main id="main" class="site-main" role="main">';
 		lsx_content_top();
 	}
 
-	add_action( 'tribe_events_before_html', 'lsx_tec_theme_wrapper_start', 9 );
+	add_action('tribe_events_before_html', 'lsx_tec_theme_wrapper_start', 9);
 
 endif;
 
-if ( ! function_exists( 'lsx_tec_theme_wrapper_end' ) ) :
+if ( ! function_exists('lsx_tec_theme_wrapper_end')) :
 
 	/**
 	 * The Events Calendar wrapper end.
@@ -63,11 +63,11 @@  discard block
 block discarded – undo
 		lsx_content_wrap_after();
 	}
 
-	add_action( 'tribe_events_after_html', 'lsx_tec_theme_wrapper_end', 11 );
+	add_action('tribe_events_after_html', 'lsx_tec_theme_wrapper_end', 11);
 
 endif;
 
-if ( ! function_exists( 'lsx_tec_global_header_title' ) ) :
+if ( ! function_exists('lsx_tec_global_header_title')) :
 
 	/**
 	 * Move the events title into the global header
@@ -75,55 +75,55 @@  discard block
 block discarded – undo
 	 * @package    lsx
 	 * @subpackage the-events-calendar
 	 */
-	function lsx_tec_global_header_title( $title ) {
+	function lsx_tec_global_header_title($title) {
 
-		if ( tribe_is_community_edit_event_page() ) {
+		if (tribe_is_community_edit_event_page()) {
 
-			$is_route = get_query_var( 'WP_Route' );
-			switch ( $is_route ) {
+			$is_route = get_query_var('WP_Route');
+			switch ($is_route) {
 				case 'ce-edit-route':
-					$title = apply_filters( 'tribe_ce_edit_event_page_title', __( 'Edit an Event', 'lsx' ) );
+					$title = apply_filters('tribe_ce_edit_event_page_title', __('Edit an Event', 'lsx'));
 					break;
 
 				case 'ce-edit-organizer-route':
-					$title = __( 'Edit an Organizer', 'lsx' );
+					$title = __('Edit an Organizer', 'lsx');
 					break;
 
 				case 'ce-edit-venue-route':
-					$title = __( 'Edit a Venue', 'lsx' );
+					$title = __('Edit a Venue', 'lsx');
 					break;
 
 				default:
-					$title = apply_filters( 'tribe_ce_submit_event_page_title', __( 'Submit an Event', 'lsx' ) );
+					$title = apply_filters('tribe_ce_submit_event_page_title', __('Submit an Event', 'lsx'));
 					break;
 			}
 
-		} else if ( tribe_is_community_my_events_page() ) {
-			$title = apply_filters( 'tribe_ce_submit_event_page_title', __( 'My Events', 'lsx' ) );
-		} else if ( tribe_is_event() ) {
+		} else if (tribe_is_community_my_events_page()) {
+			$title = apply_filters('tribe_ce_submit_event_page_title', __('My Events', 'lsx'));
+		} else if (tribe_is_event()) {
 			$title = tribe_get_events_title();
 		}
 
 		//Only disable the title after we have retrieved it
-		add_filter( 'tribe_get_events_title', 'lsx_text_disable_body_title', 200, 1 );
-		if ( is_singular( 'tribe_events' ) ) {
-			add_filter( 'the_title', 'lsx_text_disable_body_title', 200, 1 );
+		add_filter('tribe_get_events_title', 'lsx_text_disable_body_title', 200, 1);
+		if (is_singular('tribe_events')) {
+			add_filter('the_title', 'lsx_text_disable_body_title', 200, 1);
 		}
 		return $title;
 	}
-	add_filter( 'lsx_global_header_title', 'lsx_tec_global_header_title', 200, 1 );
+	add_filter('lsx_global_header_title', 'lsx_tec_global_header_title', 200, 1);
 
 endif;
 
-if ( ! function_exists( 'lsx_text_disable_body_title' ) ) :
+if ( ! function_exists('lsx_text_disable_body_title')) :
 	/**
 	 * Disable the events title for the post archive if the dynamic setting is active.
 	 * @param $title
 	 *
 	 * @return string
 	 */
-	function lsx_text_disable_body_title ( $title ) {
-		if ( ! class_exists( 'LSX_Banners' ) ) {
+	function lsx_text_disable_body_title($title) {
+		if ( ! class_exists('LSX_Banners')) {
 			$title = '';
 		}
 		return $title;
@@ -131,43 +131,43 @@  discard block
 block discarded – undo
 
 endif;
 
-if ( ! function_exists( 'lsx_tec_breadcrumb_filter' ) ) :
+if ( ! function_exists('lsx_tec_breadcrumb_filter')) :
 	/**
 	 * Fixes the community events breadcrumb
 	 *
 	 * @package    lsx
 	 * @subpackage the-events-calendar
 	 */
-	function lsx_tec_breadcrumb_filter( $crumbs ) {
+	function lsx_tec_breadcrumb_filter($crumbs) {
 
-		if ( tribe_is_venue() || tribe_is_organizer() || tribe_is_community_edit_event_page() || tribe_is_community_my_events_page() ) {
+		if (tribe_is_venue() || tribe_is_organizer() || tribe_is_community_edit_event_page() || tribe_is_community_my_events_page()) {
 			$new_crumbs = array();
 			$new_crumbs[0] = $crumbs[0];
 
-			if ( function_exists( 'woocommerce_breadcrumb' ) ) {
+			if (function_exists('woocommerce_breadcrumb')) {
 				$new_crumbs[1] = array(
 					0	=> 'Events',
-					1	=> get_post_type_archive_link( 'tribe_events' ),
+					1	=> get_post_type_archive_link('tribe_events'),
 				);
 			} else {
 				$new_crumbs[1] = array(
 					'text'	=> 'Events',
-					'url'	=> get_post_type_archive_link( 'tribe_events' ),
+					'url'	=> get_post_type_archive_link('tribe_events'),
 				);
 			}
 
-			if ( tribe_is_community_my_events_page() ) {
+			if (tribe_is_community_my_events_page()) {
 				$new_crumbs[2] = $crumbs[2];
-			} else if ( tribe_is_community_edit_event_page() ) {
+			} else if (tribe_is_community_edit_event_page()) {
 
-				if ( function_exists( 'woocommerce_breadcrumb' ) ) {
+				if (function_exists('woocommerce_breadcrumb')) {
 					$new_crumbs[2] = array(
-						0	=> apply_filters( 'tribe_ce_submit_event_page_title', __( 'My Events', 'lsx' ) ),
+						0	=> apply_filters('tribe_ce_submit_event_page_title', __('My Events', 'lsx')),
 						1	=> tribe_community_events_list_events_link( ),
 					);
 				} else {
 					$new_crumbs[2] = array(
-						'text'	=> apply_filters( 'tribe_ce_submit_event_page_title', __( 'My Events', 'lsx' ) ),
+						'text'	=> apply_filters('tribe_ce_submit_event_page_title', __('My Events', 'lsx')),
 						'url'	=> tribe_community_events_list_events_link( ),
 					);
 				}
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
 		}
 		return $crumbs;
 	}
-	add_filter( 'wpseo_breadcrumb_links', 'lsx_tec_breadcrumb_filter', 30, 1 );
-	add_filter( 'woocommerce_get_breadcrumb', 'lsx_tec_breadcrumb_filter', 30, 1 );
+	add_filter('wpseo_breadcrumb_links', 'lsx_tec_breadcrumb_filter', 30, 1);
+	add_filter('woocommerce_get_breadcrumb', 'lsx_tec_breadcrumb_filter', 30, 1);
 
 endif;

Please login to merge, or discard this patch.

		@@ -6,11 +6,11 @@ discard block
		block discarded – undo
6	6	* @subpackage the-events-calendar
7	7	*/
8	8
9		-if ( ! defined( 'ABSPATH' ) ) {
	9	+if ( ! defined('ABSPATH')) {
10	10	exit;
11	11	}
12	12
13		-if ( ! function_exists( 'lsx_tec_scripts_add_styles' ) ) :
	13	+if ( ! function_exists('lsx_tec_scripts_add_styles')) :
14	14
15	15	/**
16	16	* The Events Calendar enqueue styles.
		@@ -19,15 +19,15 @@ discard block
		block discarded – undo
19	19	* @subpackage the-events-calendar
20	20	*/
21	21	function lsx_tec_scripts_add_styles() {
22		- wp_enqueue_style( 'the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar.css', array( 'lsx_main' ), LSX_VERSION );
23		- wp_style_add_data( 'the-events-calendar-lsx', 'rtl', 'replace' );
	22	+ wp_enqueue_style('the-events-calendar-lsx', get_template_directory_uri() . '/assets/css/the-events-calendar.css', array('lsx_main'), LSX_VERSION);
	23	+ wp_style_add_data('the-events-calendar-lsx', 'rtl', 'replace');
24	24	}
25	25
26		- add_action( 'wp_enqueue_scripts', 'lsx_tec_scripts_add_styles' );
	26	+ add_action('wp_enqueue_scripts', 'lsx_tec_scripts_add_styles');
27	27
28	28	endif;
29	29
30		-if ( ! function_exists( 'lsx_tec_theme_wrapper_start' ) ) :
	30	+if ( ! function_exists('lsx_tec_theme_wrapper_start')) :
31	31
32	32	/**
33	33	* The Events Calendar wrapper start.
		@@ -37,17 +37,17 @@ discard block
		block discarded – undo
37	37	*/
38	38	function lsx_tec_theme_wrapper_start() {
39	39	lsx_content_wrap_before();
40		- echo '<div id="primary" class="content-area ' . esc_attr( lsx_main_class() ) . '">';
	40	+ echo '<div id="primary" class="content-area ' . esc_attr(lsx_main_class()) . '">';
41	41	lsx_content_before();
42	42	echo '<main id="main" class="site-main" role="main">';
43	43	lsx_content_top();
44	44	}
45	45
46		- add_action( 'tribe_events_before_html', 'lsx_tec_theme_wrapper_start', 9 );
	46	+ add_action('tribe_events_before_html', 'lsx_tec_theme_wrapper_start', 9);
47	47
48	48	endif;
49	49
50		-if ( ! function_exists( 'lsx_tec_theme_wrapper_end' ) ) :
	50	+if ( ! function_exists('lsx_tec_theme_wrapper_end')) :
51	51
52	52	/**
53	53	* The Events Calendar wrapper end.
		@@ -63,11 +63,11 @@ discard block
		block discarded – undo
63	63	lsx_content_wrap_after();
64	64	}
65	65
66		- add_action( 'tribe_events_after_html', 'lsx_tec_theme_wrapper_end', 11 );
	66	+ add_action('tribe_events_after_html', 'lsx_tec_theme_wrapper_end', 11);
67	67
68	68	endif;
69	69
70		-if ( ! function_exists( 'lsx_tec_global_header_title' ) ) :
	70	+if ( ! function_exists('lsx_tec_global_header_title')) :
71	71
72	72	/**
73	73	* Move the events title into the global header
		@@ -75,55 +75,55 @@ discard block
		block discarded – undo
75	75	* @package lsx
76	76	* @subpackage the-events-calendar
77	77	*/
78		- function lsx_tec_global_header_title( $title ) {
	78	+ function lsx_tec_global_header_title($title) {
79	79
80		- if ( tribe_is_community_edit_event_page() ) {
	80	+ if (tribe_is_community_edit_event_page()) {
81	81
82		- $is_route = get_query_var( 'WP_Route' );
83		- switch ( $is_route ) {
	82	+ $is_route = get_query_var('WP_Route');
	83	+ switch ($is_route) {
84	84	case 'ce-edit-route':
85		- $title = apply_filters( 'tribe_ce_edit_event_page_title', __( 'Edit an Event', 'lsx' ) );
	85	+ $title = apply_filters('tribe_ce_edit_event_page_title', __('Edit an Event', 'lsx'));
86	86	break;
87	87
88	88	case 'ce-edit-organizer-route':
89		- $title = __( 'Edit an Organizer', 'lsx' );
	89	+ $title = __('Edit an Organizer', 'lsx');
90	90	break;
91	91
92	92	case 'ce-edit-venue-route':
93		- $title = __( 'Edit a Venue', 'lsx' );
	93	+ $title = __('Edit a Venue', 'lsx');
94	94	break;
95	95
96	96	default:
97		- $title = apply_filters( 'tribe_ce_submit_event_page_title', __( 'Submit an Event', 'lsx' ) );
	97	+ $title = apply_filters('tribe_ce_submit_event_page_title', __('Submit an Event', 'lsx'));
98	98	break;
99	99	}
100	100
101		- } else if ( tribe_is_community_my_events_page() ) {
102		- $title = apply_filters( 'tribe_ce_submit_event_page_title', __( 'My Events', 'lsx' ) );
103		- } else if ( tribe_is_event() ) {
	101	+ } else if (tribe_is_community_my_events_page()) {
	102	+ $title = apply_filters('tribe_ce_submit_event_page_title', __('My Events', 'lsx'));
	103	+ } else if (tribe_is_event()) {
104	104	$title = tribe_get_events_title();
105	105	}
106	106
107	107	//Only disable the title after we have retrieved it
108		- add_filter( 'tribe_get_events_title', 'lsx_text_disable_body_title', 200, 1 );
109		- if ( is_singular( 'tribe_events' ) ) {
110		- add_filter( 'the_title', 'lsx_text_disable_body_title', 200, 1 );
	108	+ add_filter('tribe_get_events_title', 'lsx_text_disable_body_title', 200, 1);
	109	+ if (is_singular('tribe_events')) {
	110	+ add_filter('the_title', 'lsx_text_disable_body_title', 200, 1);
111	111	}
112	112	return $title;
113	113	}
114		- add_filter( 'lsx_global_header_title', 'lsx_tec_global_header_title', 200, 1 );
	114	+ add_filter('lsx_global_header_title', 'lsx_tec_global_header_title', 200, 1);
115	115
116	116	endif;
117	117
118		-if ( ! function_exists( 'lsx_text_disable_body_title' ) ) :
	118	+if ( ! function_exists('lsx_text_disable_body_title')) :
119	119	/**
120	120	* Disable the events title for the post archive if the dynamic setting is active.
121	121	* @param $title
122	122	*
123	123	* @return string
124	124	*/
125		- function lsx_text_disable_body_title ( $title ) {
126		- if ( ! class_exists( 'LSX_Banners' ) ) {
	125	+ function lsx_text_disable_body_title($title) {
	126	+ if ( ! class_exists('LSX_Banners')) {
127	127	$title = '';
128	128	}
129	129	return $title;
		@@ -131,43 +131,43 @@ discard block
		block discarded – undo
131	131
132	132	endif;
133	133
134		-if ( ! function_exists( 'lsx_tec_breadcrumb_filter' ) ) :
	134	+if ( ! function_exists('lsx_tec_breadcrumb_filter')) :
135	135	/**
136	136	* Fixes the community events breadcrumb
137	137	*
138	138	* @package lsx
139	139	* @subpackage the-events-calendar
140	140	*/
141		- function lsx_tec_breadcrumb_filter( $crumbs ) {
	141	+ function lsx_tec_breadcrumb_filter($crumbs) {
142	142
143		- if ( tribe_is_venue() \|\| tribe_is_organizer() \|\| tribe_is_community_edit_event_page() \|\| tribe_is_community_my_events_page() ) {
	143	+ if (tribe_is_venue() \|\| tribe_is_organizer() \|\| tribe_is_community_edit_event_page() \|\| tribe_is_community_my_events_page()) {
144	144	$new_crumbs = array();
145	145	$new_crumbs[0] = $crumbs[0];
146	146
147		- if ( function_exists( 'woocommerce_breadcrumb' ) ) {
	147	+ if (function_exists('woocommerce_breadcrumb')) {
148	148	$new_crumbs[1] = array(
149	149	0 => 'Events',
150		- 1 => get_post_type_archive_link( 'tribe_events' ),
	150	+ 1 => get_post_type_archive_link('tribe_events'),
151	151	);
152	152	} else {
153	153	$new_crumbs[1] = array(
154	154	'text' => 'Events',
155		- 'url' => get_post_type_archive_link( 'tribe_events' ),
	155	+ 'url' => get_post_type_archive_link('tribe_events'),
156	156	);
157	157	}
158	158
159		- if ( tribe_is_community_my_events_page() ) {
	159	+ if (tribe_is_community_my_events_page()) {
160	160	$new_crumbs[2] = $crumbs[2];
161		- } else if ( tribe_is_community_edit_event_page() ) {
	161	+ } else if (tribe_is_community_edit_event_page()) {
162	162
163		- if ( function_exists( 'woocommerce_breadcrumb' ) ) {
	163	+ if (function_exists('woocommerce_breadcrumb')) {
164	164	$new_crumbs[2] = array(
165		- 0 => apply_filters( 'tribe_ce_submit_event_page_title', __( 'My Events', 'lsx' ) ),
	165	+ 0 => apply_filters('tribe_ce_submit_event_page_title', __('My Events', 'lsx')),
166	166	1 => tribe_community_events_list_events_link( ),
167	167	);
168	168	} else {
169	169	$new_crumbs[2] = array(
170		- 'text' => apply_filters( 'tribe_ce_submit_event_page_title', __( 'My Events', 'lsx' ) ),
	170	+ 'text' => apply_filters('tribe_ce_submit_event_page_title', __('My Events', 'lsx')),
171	171	'url' => tribe_community_events_list_events_link( ),
172	172	);
173	173	}
		@@ -180,7 +180,7 @@ discard block
		block discarded – undo
180	180	}
181	181	return $crumbs;
182	182	}
183		- add_filter( 'wpseo_breadcrumb_links', 'lsx_tec_breadcrumb_filter', 30, 1 );
184		- add_filter( 'woocommerce_get_breadcrumb', 'lsx_tec_breadcrumb_filter', 30, 1 );
	183	+ add_filter('wpseo_breadcrumb_links', 'lsx_tec_breadcrumb_filter', 30, 1);
	184	+ add_filter('woocommerce_get_breadcrumb', 'lsx_tec_breadcrumb_filter', 30, 1);
185	185
186	186	endif;

lightspeeddevelopment / lsx

Push — master ( deb734...53b10b )

Status

Category

Spacing +42 added lines, -42 removed lines patch added patch discarded remove patch