lifeboat-app / php-sdk

tests/UtilsTest.php

Spacing +6 added lines, -6 removed lines

@@ -21,7 +21,7 @@ 
     public function test_is_associative_array()
     {
         $this->assertEquals(true, ArrayLib::is_associative(['a' => 1]));
-        $this->assertEquals(false, ArrayLib::is_associative([1,2,3]));
+        $this->assertEquals(false, ArrayLib::is_associative([1, 2, 3]));
         $this->assertEquals(false, ArrayLib::is_associative([]));
 
         try {
@@ -42,16 +42,16 @@ 
     public function test_set_get_var()
     {
         $rel_path = '/path';
-        $this->assertEquals($rel_path . '?var=1', URL::setGetVar('var', 1, $rel_path));
+        $this->assertEquals($rel_path.'?var=1', URL::setGetVar('var', 1, $rel_path));
 
         $rel_path_t = '/path/';
-        $this->assertEquals($rel_path_t . '?var=1', URL::setGetVar('var', 1, $rel_path_t));
+        $this->assertEquals($rel_path_t.'?var=1', URL::setGetVar('var', 1, $rel_path_t));
 
         $absolute = 'https://test.com';
-        $this->assertEquals($absolute . '?var=1', URL::setGetVar('var', 1, $absolute));
+        $this->assertEquals($absolute.'?var=1', URL::setGetVar('var', 1, $absolute));
 
         $absolute_t = 'https://test.com/';
-        $this->assertEquals($absolute_t . '?var=1', URL::setGetVar('var', 1, $absolute_t));
+        $this->assertEquals($absolute_t.'?var=1', URL::setGetVar('var', 1, $absolute_t));
     }
 
     /**
@@ -71,7 +71,7 @@ 
         while (count($generated) < 100000) $generated[] = Utils::create_random_string();
         $count  = count($generated);
         $unique = count(array_unique($generated));
-        $random = 100 - ((100 / $count) * $unique);
+        $random = 100-((100 / $count) * $unique);
 
         // Less than 2% repeat
         $this->assertTrue($random < 2);

Braces +3 added lines, -1 removed lines

@@ -68,7 +68,9 @@
 
         // Test the randomness
         $generated = [];
-        while (count($generated) < 100000) $generated[] = Utils::create_random_string();
+        while (count($generated) < 100000) {
+            $generated[] = Utils::create_random_string();
+        }
         $count  = count($generated);
         $unique = count(array_unique($generated));
         $random = 100 - ((100 / $count) * $unique);

src/utils/Curl.php

Braces +24 added lines, -8 removed lines

@@ -40,8 +40,12 @@ 
     public function __construct(string $url, array $data = [], array $headers = [])
     {
         $this->setURL($url);
-        foreach ($data as $name => $value)      $this->addDataParam($name, $value);
-        foreach ($headers as $name => $value)   $this->addHeader($name, $value);
+        foreach ($data as $name => $value) {
+            $this->addDataParam($name, $value);
+        }
+        foreach ($headers as $name => $value) {
+            $this->addHeader($name, $value);
+        }
     }
 
     /**
@@ -98,7 +102,9 @@ 
 
     public function removeDataParam(string $name): Curl
     {
-        if (array_key_exists($name, $this->_data)) unset($this->_data[$name]);
+        if (array_key_exists($name, $this->_data)) {
+            unset($this->_data[$name]);
+        }
         return $this;
     }
 
@@ -127,7 +133,9 @@ 
      */
     public function removeHeader(string $name): Curl
     {
-        if (array_key_exists($name, $this->_headers)) unset($this->_headers[$name]);
+        if (array_key_exists($name, $this->_headers)) {
+            unset($this->_headers[$name]);
+        }
         return $this;
     }
 
@@ -171,13 +179,17 @@ 
         $request_uri    = $this->getURL();
 
         //  Headers
-        foreach ($this->getHeaders() as $k => $v) $send_headers[] = "{$k}: {$v}";
+        foreach ($this->getHeaders() as $k => $v) {
+            $send_headers[] = "{$k}: {$v}";
+        }
 
         // Request Data
         switch ($this->getMethod()) {
             case 'GET':
             case 'DELETE':
-                foreach ($this->getDataParams() as $name => $value) $request_uri = URL::setGetVar($name, $value, $request_uri);
+                foreach ($this->getDataParams() as $name => $value) {
+                    $request_uri = URL::setGetVar($name, $value, $request_uri);
+                }
                 break;
 
             case 'POST':
@@ -208,7 +220,9 @@ 
         curl_setopt($ch, CURLINFO_HEADER_OUT, true);
         curl_setopt($ch, CURLOPT_AUTOREFERER, true);
 
-        if (!empty($send_headers))  curl_setopt($ch, CURLOPT_HTTPHEADER, $send_headers);
+        if (!empty($send_headers)) {
+            curl_setopt($ch, CURLOPT_HTTPHEADER, $send_headers);
+        }
         if (!is_null($post_data))   {
             curl_setopt($ch, CURLOPT_POST, 1);
             curl_setopt($ch, CURLOPT_POSTFIELDS, $post_data);
@@ -218,7 +232,9 @@ 
         $http_code  = curl_getinfo($ch, CURLINFO_HTTP_CODE);
 
         $response = new CurlResponse($http_code, $result);
-        if ($this->_enable_cache && isset($cache_key)) self::$_cache[$cache_key] = $response;
+        if ($this->_enable_cache && isset($cache_key)) {
+            self::$_cache[$cache_key] = $response;
+        }
 
         return $response;
     }

src/utils/URL.php

Spacing +8 added lines, -8 removed lines

@@ -20,13 +20,13 @@ 
     public static function setGetVar(string $key, string $value, string $url): string
     {
         if (!self::is_absolute_url($url)) {
-            $url = 'http://dummy.com/' . ltrim($url, '/');
+            $url = 'http://dummy.com/'.ltrim($url, '/');
         }
 
         // try to parse uri
         $parts = parse_url($url);
         if (empty($parts)) {
-            throw new InvalidArgumentException("Can't parse URL: " . $url);
+            throw new InvalidArgumentException("Can't parse URL: ".$url);
         }
 
         // Parse params and add new variable
@@ -40,18 +40,18 @@ 
         // Generate URI segments and formatting
         $scheme = (array_key_exists('scheme', $parts)) ? $parts['scheme'] : 'http';
         $user = (array_key_exists('user', $parts)) ? $parts['user'] : '';
-        $port = (array_key_exists('port', $parts) && $parts['port']) ? ':' . $parts['port'] : '';
+        $port = (array_key_exists('port', $parts) && $parts['port']) ? ':'.$parts['port'] : '';
 
         if ($user != '') {
             // format in either user:pass@host.com or user@host.com
-            $user .= (array_key_exists('pass', $parts) && $parts['pass']) ? ':' . $parts['pass'] . '@' : '';
+            $user .= (array_key_exists('pass', $parts) && $parts['pass']) ? ':'.$parts['pass'].'@' : '';
         }
 
         // handle URL params which are existing / new
-        $params = ($params) ? '?' . http_build_query($params) : '';
+        $params = ($params) ? '?'.http_build_query($params) : '';
 
         // Recompile URI segments
-        $newUri = $scheme . '://' . $user . $parts['host'] . $port . ($parts['path'] ?? '') . $params;
+        $newUri = $scheme.'://'.$user.$parts['host'].$port.($parts['path'] ?? '').$params;
 
         return str_replace('http://dummy.com', '', $newUri);
     }
@@ -64,10 +64,10 @@ 
     {
         // Strip off the query and fragment parts of the URL before checking
         if (($queryPosition = strpos($url, '?')) !== false) {
-            $url = substr($url, 0, $queryPosition - 1);
+            $url = substr($url, 0, $queryPosition-1);
         }
         if (($hashPosition = strpos($url, '#')) !== false) {
-            $url = substr($url, 0, $hashPosition - 1);
+            $url = substr($url, 0, $hashPosition-1);
         }
         $colonPosition = strpos($url, ':');
         $slashPosition = strpos($url, '/');