Issues in DashboardController.php (develop) - Issues in develop - librenms/librenmsv2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (111)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Api/Controllers/DashboardController.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace App\Api\Controllers;

use App\Models\Dashboard;
use App\Models\UsersWidgets;
use Dingo\Api\Routing\Helpers;
use Illuminate\Http\Request;
use Validator;

class DashboardController extends Controller
{

    use Helpers;

    public function __construct()
    {
    }

    /**
     * Display a listing of all authorized devices
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        $dashboards = Dashboard::allAvailable($request->user())->get();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        return $dashboards;
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response|null
     */
    public function create(Request $request)
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $validation = Validator::make($request->all(), [
            'name' => 'required|max:255',
            'access' => 'required',
        ]);
        if ($validation->passes()) {
            $dashboard = new Dashboard;
            $dashboard->dashboard_name = $request->name;
            $dashboard->access         = $request->access;
            if ($request->user()->dashboards()->save($dashboard)) {
                if (is_numeric($request->copy_from)) {
                    $duplicate_widgets = Dashboard::find($request->copy_from)->widgets()->get();
                    foreach ($duplicate_widgets as $tmp_widget) {
                        /** @var UsersWidgets $tmp_widget */
                        $new_widget               = $tmp_widget->replicate();
                        $new_widget->user_id      = $request->user()->user_id;
                        $new_widget->dashboard_id = $dashboard->dashboard_id;
                        unset($new_widget->user_widget_id);
                        $new_widget->save();
                    }
                }
                return $this->response->array(array('statusText' => 'OK', 'dashboard_id' => $dashboard->dashboard_id));
            } else {
                return $this->response->errorInternal();
            }
        } else {
            $errors = $validation->errors();
            return response()->json($errors, 422);
        }
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response

     */
    public function show(Request $request, $id)
    {
        $dashboard = Dashboard::find($id);
        $widgets   = $dashboard->widgets()->get();

        return array('dashboard' => $dashboard, 'widgets' => $widgets);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response

     */
    public function edit($id)
    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $validation = Validator::make($request->all(), [
            'name' => 'required|max:255',
            'access' => 'required',
        ]);
        if ($validation->passes()) {
            $dashboard = Dashboard::find($id);
            $dashboard->dashboard_name = $request->name;
            $dashboard->access         = $request->access;
            if ($dashboard->save()) {
                return $this->response->array(array('statusText' => 'OK'));
            } else {
                return $this->response->errorInternal();
            }
        } else {
            $errors = $validation->errors();
            return response()->json($errors, 422);
        }
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request, $id)
    {
        if (Dashboard::where('user_id', $request->user()->user_id)->where('dashboard_id', $id)->delete()) {
            if (UsersWidgets::where('dashboard_id', $id)->delete() >= 0) {
                return $this->response->array(array('statusText' => 'OK'));
            } else {
                return $this->response->errorInternal();
            }
        } else {
            return $this->response->errorInternal();
        }
    }

    public function clear($id)
    {
        if (Dashboard::find($id)->widgets()->delete() >= 0) {
            return $this->response->array(array('statusText' => 'OK'));
        } else {
            return $this->response->errorInternal();
        }
    }
}


1		<?php
2
3		namespace App\Api\Controllers;
4
5		use App\Models\Dashboard;
6		use App\Models\UsersWidgets;
7		use Dingo\Api\Routing\Helpers;
8		use Illuminate\Http\Request;
9		use Validator;
10
11		class DashboardController extends Controller
12		{
13
14		use Helpers;
15
16	4	public function __construct()
17		{
18	4	}
19
20		/**
21		* Display a listing of all authorized devices
22		*
23		* @return \Illuminate\Http\Response
24		*/
25	4	public function index(Request $request)
26		{
27	4	$dashboards = Dashboard::allAvailable($request->user())->get();
		0 ignored issues – show Bug introduced 2016-04-16 03:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `get` does only exist in `Illuminate\Database\Query\Builder`, but not in `App\Models\Dashboard`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
28	4	return $dashboards;
29		}
30
31		/**
32		* Show the form for creating a new resource.
33		*
34		* @return \Illuminate\Http\Response\|null
35		*/
36		public function create(Request $request)
37		{
38		//
39		}
40
41		/**
42		* Store a newly created resource in storage.
43		*
44		* @param \Illuminate\Http\Request $request
45		* @return \Illuminate\Http\Response
46		*/
47	1	public function store(Request $request)
48		{
49	1	$validation = Validator::make($request->all(), [
50	1	'name' => 'required\|max:255',
51		'access' => 'required',
52		]);
53	1	if ($validation->passes()) {
54	1	$dashboard = new Dashboard;
55	1	$dashboard->dashboard_name = $request->name;
56	1	$dashboard->access = $request->access;
57	1	if ($request->user()->dashboards()->save($dashboard)) {
58	1	if (is_numeric($request->copy_from)) {
59		$duplicate_widgets = Dashboard::find($request->copy_from)->widgets()->get();
60		foreach ($duplicate_widgets as $tmp_widget) {
61		/** @var UsersWidgets $tmp_widget */
62		$new_widget = $tmp_widget->replicate();
63		$new_widget->user_id = $request->user()->user_id;
64		$new_widget->dashboard_id = $dashboard->dashboard_id;
65		unset($new_widget->user_widget_id);
66		$new_widget->save();
67		}
68		}
69	1	return $this->response->array(array('statusText' => 'OK', 'dashboard_id' => $dashboard->dashboard_id));
70		} else {
71		return $this->response->errorInternal();
72		}
73		} else {
74		$errors = $validation->errors();
75		return response()->json($errors, 422);
76		}
77		}
78
79		/**
80		* Display the specified resource.
81		*
82		* @param int $id
83		* @return \Illuminate\Http\Response
		0 ignored issues – show Documentation introduced 2016-04-15 18:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `array`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
84		*/
85	3	public function show(Request $request, $id)
86		{
87	3	$dashboard = Dashboard::find($id);
88	3	$widgets = $dashboard->widgets()->get();
89
90	3	return array('dashboard' => $dashboard, 'widgets' => $widgets);
91		}
92
93		/**
94		* Show the form for editing the specified resource.
95		*
96		* @param int $id
97		* @return \Illuminate\Http\Response
		0 ignored issues – show Documentation introduced 2016-04-27 11:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `\Illuminate\Http\Response\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
98		*/
99		public function edit($id)
100		{
101		//
102		}
103
104		/**
105		* Update the specified resource in storage.
106		*
107		* @param \Illuminate\Http\Request $request
108		* @param int $id
109		* @return \Illuminate\Http\Response
110		*/
111		public function update(Request $request, $id)
112		{
113		$validation = Validator::make($request->all(), [
114		'name' => 'required\|max:255',
115		'access' => 'required',
116		]);
117		if ($validation->passes()) {
118		$dashboard = Dashboard::find($id);
119		$dashboard->dashboard_name = $request->name;
120		$dashboard->access = $request->access;
121		if ($dashboard->save()) {
122		return $this->response->array(array('statusText' => 'OK'));
123		} else {
124		return $this->response->errorInternal();
125		}
126		} else {
127		$errors = $validation->errors();
128		return response()->json($errors, 422);
129		}
130		}
131
132		/**
133		* Remove the specified resource from storage.
134		*
135		* @param int $id
136		* @return \Illuminate\Http\Response
137		*/
138		public function destroy(Request $request, $id)
139		{
140		if (Dashboard::where('user_id', $request->user()->user_id)->where('dashboard_id', $id)->delete()) {
141		if (UsersWidgets::where('dashboard_id', $id)->delete() >= 0) {
142		return $this->response->array(array('statusText' => 'OK'));
143		} else {
144		return $this->response->errorInternal();
145		}
146		} else {
147		return $this->response->errorInternal();
148		}
149		}
150
151		public function clear($id)
152		{
153		if (Dashboard::find($id)->widgets()->delete() >= 0) {
154		return $this->response->array(array('statusText' => 'OK'));
155		} else {
156		return $this->response->errorInternal();
157		}
158		}
159		}
160

librenms / librenmsv2

Issues (111)

Security Analysis not enabled

app/Api/Controllers/DashboardController.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like