DashboardController   A
last analyzed

Complexity

Total Complexity 18

Size/Duplication

Total Lines 149
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 8

Test Coverage

Coverage 34.54%

Importance

Changes 0
Metric Value
dl 0
loc 149
ccs 19
cts 55
cp 0.3454
rs 10
c 0
b 0
f 0
wmc 18
lcom 1
cbo 8

9 Methods

Rating   Name   Duplication   Size   Complexity  
A index() 0 5 1
A __construct() 0 3 1
A create() 0 4 1
B store() 0 31 5
A show() 0 7 1
A edit() 0 4 1
A update() 0 20 3
A destroy() 0 12 3
A clear() 0 8 2
1
<?php
2
3
namespace App\Api\Controllers;
4
5
use App\Models\Dashboard;
6
use App\Models\UsersWidgets;
7
use Dingo\Api\Routing\Helpers;
8
use Illuminate\Http\Request;
9
use Validator;
10
11
class DashboardController extends Controller
12
{
13
14
    use Helpers;
15
16 4
    public function __construct()
17
    {
18 4
    }
19
20
    /**
21
     * Display a listing of all authorized devices
22
     *
23
     * @return \Illuminate\Http\Response
24
     */
25 4
    public function index(Request $request)
26
    {
27 4
        $dashboards = Dashboard::allAvailable($request->user())->get();
0 ignored issues
show
Bug introduced by
The method get does only exist in Illuminate\Database\Query\Builder, but not in App\Models\Dashboard.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
28 4
        return $dashboards;
29
    }
30
31
    /**
32
     * Show the form for creating a new resource.
33
     *
34
     * @return \Illuminate\Http\Response|null
35
     */
36
    public function create(Request $request)
37
    {
38
        //
39
    }
40
41
    /**
42
     * Store a newly created resource in storage.
43
     *
44
     * @param  \Illuminate\Http\Request  $request
45
     * @return \Illuminate\Http\Response
46
     */
47 1
    public function store(Request $request)
48
    {
49 1
        $validation = Validator::make($request->all(), [
50 1
            'name' => 'required|max:255',
51
            'access' => 'required',
52
        ]);
53 1
        if ($validation->passes()) {
54 1
            $dashboard = new Dashboard;
55 1
            $dashboard->dashboard_name = $request->name;
56 1
            $dashboard->access         = $request->access;
57 1
            if ($request->user()->dashboards()->save($dashboard)) {
58 1
                if (is_numeric($request->copy_from)) {
59
                    $duplicate_widgets = Dashboard::find($request->copy_from)->widgets()->get();
60
                    foreach ($duplicate_widgets as $tmp_widget) {
61
                        /** @var UsersWidgets $tmp_widget */
62
                        $new_widget               = $tmp_widget->replicate();
63
                        $new_widget->user_id      = $request->user()->user_id;
64
                        $new_widget->dashboard_id = $dashboard->dashboard_id;
65
                        unset($new_widget->user_widget_id);
66
                        $new_widget->save();
67
                    }
68
                }
69 1
                return $this->response->array(array('statusText' => 'OK', 'dashboard_id' => $dashboard->dashboard_id));
70
            } else {
71
                return $this->response->errorInternal();
72
            }
73
        } else {
74
            $errors = $validation->errors();
75
            return response()->json($errors, 422);
76
        }
77
    }
78
79
    /**
80
     * Display the specified resource.
81
     *
82
     * @param  int  $id
83
     * @return \Illuminate\Http\Response
0 ignored issues
show
Documentation introduced by
Should the return type not be array?

This check compares the return type specified in the @return annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch.

Loading history...
84
     */
85 3
    public function show(Request $request, $id)
86
    {
87 3
        $dashboard = Dashboard::find($id);
88 3
        $widgets   = $dashboard->widgets()->get();
89
90 3
        return array('dashboard' => $dashboard, 'widgets' => $widgets);
91
    }
92
93
    /**
94
     * Show the form for editing the specified resource.
95
     *
96
     * @param  int  $id
97
     * @return \Illuminate\Http\Response
0 ignored issues
show
Documentation introduced by
Should the return type not be \Illuminate\Http\Response|null?

This check compares the return type specified in the @return annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch.

Loading history...
98
     */
99
    public function edit($id)
100
    {
101
        //
102
    }
103
104
    /**
105
     * Update the specified resource in storage.
106
     *
107
     * @param  \Illuminate\Http\Request  $request
108
     * @param  int  $id
109
     * @return \Illuminate\Http\Response
110
     */
111
    public function update(Request $request, $id)
112
    {
113
        $validation = Validator::make($request->all(), [
114
            'name' => 'required|max:255',
115
            'access' => 'required',
116
        ]);
117
        if ($validation->passes()) {
118
            $dashboard = Dashboard::find($id);
119
            $dashboard->dashboard_name = $request->name;
120
            $dashboard->access         = $request->access;
121
            if ($dashboard->save()) {
122
                return $this->response->array(array('statusText' => 'OK'));
123
            } else {
124
                return $this->response->errorInternal();
125
            }
126
        } else {
127
            $errors = $validation->errors();
128
            return response()->json($errors, 422);
129
        }
130
    }
131
132
    /**
133
     * Remove the specified resource from storage.
134
     *
135
     * @param  int  $id
136
     * @return \Illuminate\Http\Response
137
     */
138
    public function destroy(Request $request, $id)
139
    {
140
        if (Dashboard::where('user_id', $request->user()->user_id)->where('dashboard_id', $id)->delete()) {
141
            if (UsersWidgets::where('dashboard_id', $id)->delete() >= 0) {
142
                return $this->response->array(array('statusText' => 'OK'));
143
            } else {
144
                return $this->response->errorInternal();
145
            }
146
        } else {
147
            return $this->response->errorInternal();
148
        }
149
    }
150
151
    public function clear($id)
152
    {
153
        if (Dashboard::find($id)->widgets()->delete() >= 0) {
154
            return $this->response->array(array('statusText' => 'OK'));
155
        } else {
156
            return $this->response->errorInternal();
157
        }
158
    }
159
}
160