Completed
Pull Request — develop (#100)
by Neil
18:13
created
app/Api/Transformers/Alerting/LogsTransformer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
     /**
34 34
      * Turn this item object into a generic array
35 35
      *
36
-     * @param Notification $logs
36
+     * @param Log $logs
37 37
      * @return array
38 38
      */
39 39
     public function transform(Log $logs)
Please login to merge, or discard this patch.
app/DataTables/Alerting/LogsDataTable.php 3 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,6 @@
 block discarded – undo
25 25
 
26 26
 namespace App\DataTables\Alerting;
27 27
 
28
-use App\Models\Alerting\Alert;
29 28
 use App\Models\Alerting\Log;
30 29
 use Yajra\Datatables\Services\DataTable;
31 30
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@
 block discarded – undo
89 89
      */
90 90
     public function query()
91 91
     {
92
-        $logs = Log::query()->with('device','user','rule')->select('alert_log.*');
92
+        $logs = Log::query()->with('device', 'user', 'rule')->select('alert_log.*');
93 93
         return $this->applyScopes($logs);
94 94
     }
95 95
 
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,8 @@
 block discarded – undo
102 102
             } catch(\Exception $e) {
103 103
                 if(starts_with($e->getMessage(), 'unserialize():')) {
104 104
                     return $value;
105
-                } else {
105
+                }
106
+                else {
106 107
                     throw $e;
107 108
                 }
108 109
             }
Please login to merge, or discard this patch.
app/Http/Controllers/Alerting/LogsController.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,9 +25,9 @@
 block discarded – undo
25 25
 
26 26
 namespace App\Http\Controllers\Alerting;
27 27
 
28
-use Illuminate\Http\Request;
29 28
 use App\DataTables\AlertsDataTable;
30 29
 use App\Http\Controllers\Controller;
30
+use Illuminate\Http\Request;
31 31
 
32 32
 class AlertsController extends Controller
33 33
 {
Please login to merge, or discard this patch.