librenms / librenmsv2

app/Http/Controllers/NotificationController.php

Braces +1 added lines, -2 removed lines

@@ -17,8 +17,7 @@
     public function list_devices(Request $request) {
         if ($request->user()->level >= 10 || $request->user()->level == 5) {
             return Devices::all();
-        }
-        else {
+        } else {
             return User::find($request->user()->user_id)->devices()->get();
         }
     }

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Illuminate\Contracts\Auth\Guard;
 use Dingo\Api\Http;
 use Dingo\Api\Routing\Helpers;
-use Illuminate\Http\Request;
 
 class SetViewVariable
 {

app/Notification.php

Spacing +2 added lines, -2 removed lines

@@ -41,11 +41,11 @@
 
     public function scopeLimit($query)
     {
-        return $query->select('notifications.*','key');
+        return $query->select('notifications.*', 'key');
     }
 
     public function users() {
-        return $this->belongsToMany('App\User')->withPivot('notifications_id','user_id');
+        return $this->belongsToMany('App\User')->withPivot('notifications_id', 'user_id');
     }
 
 }

Doc Comments +3 added lines

@@ -42,6 +42,9 @@
         $this->setAttrib('sticky', $enabled);
     }
 
+    /**
+     * @param string $name
+     */
     private function setAttrib($name, $enabled) {
         if ($enabled === true) {
             $read = new NotificationAttrib;

Braces +1 added lines, -2 removed lines

@@ -17,8 +17,7 @@
     public function list_devices(Request $request) {
         if ($request->user()->level >= 10 || $request->user()->level == 5) {
             return Devices::all();
-        }
-        else {
+        } else {
             return User::find($request->user()->user_id)->devices()->get();
         }
     }

app/Api/Controllers/NotificationController.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Dingo\Api\Http;
 use Dingo\Api\Routing\Helpers;
 use App\Notification;
-use App\NotificationAttrib;
 use Illuminate\Http\Request;
 
 class NotificationController extends Controller

Indentation +2 added lines, -2 removed lines

@@ -43,10 +43,10 @@
         }
 
         if ($action == 'read') {
-           $result = $notification->markRead($enable);
+            $result = $notification->markRead($enable);
         }
         elseif ($action == 'sticky') {
-           $result = $notification->markSticky(false);
+            $result = $notification->markSticky(false);
         }
 
         if ($result === false) {

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
 
         $notification = Notification::find($id);
         $enable = strpos($action, 'un') === false;
-        if(!$enable) {
+        if (!$enable) {
             $action = substr($action, 2);
         }
 

Braces +3 added lines, -6 removed lines

@@ -26,8 +26,7 @@ 
         if ($type === 'archive')
         {
             $notifications = Notification::IsArchived($request)->get();
-        }
-        else {
+        } else {
             $notifications = Notification::IsUnread()->get();
         }
         return $notifications;
@@ -44,15 +43,13 @@ 
 
         if ($action == 'read') {
            $result = $notification->markRead($enable);
-        }
-        elseif ($action == 'sticky') {
+        } elseif ($action == 'sticky') {
            $result = $notification->markSticky(false);
         }
 
         if ($result === false) {
             return $this->response->errorInternal();
-        }
-        else {
+        } else {
             return $this->response->array(array('statusText'=>'OK'));
         }
     }